Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for chat_message_bubble.dart #1518

Closed
palisadoes opened this issue Feb 18, 2023 · 8 comments
Closed

Tests for chat_message_bubble.dart #1518

palisadoes opened this issue Feb 18, 2023 · 8 comments
Assignees
@Amogh35
Labels
good first issue Good for newcomers test Testing application

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Feb 18, 2023 •
edited
Loading

The Talawa code base needs to be 100% reliable. This means we need to have 100% test code coverage.

Tests need to be written for file lib/views/after_auth_screens/chat/widgets/chat_message_bubble.dart

  • When complete, all methods, classes and/or functions in the file will need to be tested.
  • Our test/ folder has the same structure as the lib folder. Place your test file in the equivalent folder under test/. You may need to create the appropriate directory structure to do this.
  • Current test code coverage for this file can be found here

IMPORTANT:

Please refer to the parent issue on how to implement these tests correctly:

PR Acceptance Criteria

  • When complete this file must show 100% coverage when merged into the code base. This will be clearly visible when you submit your PR.
  • The PR will show a report for the code coverage for the file you have added. You can use that as a guide.
  • You can verify your own code coverage by creating an account at Codecov.io
@palisadoes palisadoes added the bug Something isn't working label Feb 18, 2023
@github-actions github-actions bot added parent The issue is generating more sub-issues test Testing application unapproved Unapproved, needs to be triaged labels Feb 18, 2023
@palisadoes palisadoes added points 01 good first issue Good for newcomers and removed bug Something isn't working parent The issue is generating more sub-issues labels Feb 18, 2023
@Amogh35
Copy link
Contributor

Amogh35 commented Feb 19, 2023

Hello @palisadoes,
I am a beginner and want to contribute to Palisadoes. I wanted to work on this issue, but it looks like the test for this file already exists. However, codecov does not show coverage for this file.
Can you please look into this.

@xoldd xoldd assigned Amogh35 and unassigned Amogh35 Feb 19, 2023
@noman2002
Copy link
Member

@Amogh35 test for this file exists but its not at 100%.

@noman2002 noman2002 removed the unapproved Unapproved, needs to be triaged label Feb 19, 2023
@noman2002
Copy link
Member

@Amogh35 Assigned this to you. Please work on it and get it to 100%

@Amogh35
Copy link
Contributor

Amogh35 commented Feb 19, 2023

Thanks, i will look into it.

@noman2002
Copy link
Member

@Amogh35 You already have 2 issues assigned apart from this one. Unassigning this one.

@noman2002 noman2002 added the unapproved Unapproved, needs to be triaged label Feb 19, 2023
@noman2002
Copy link
Member

@Amogh35 You can work on this now.

@noman2002 noman2002 removed the unapproved Unapproved, needs to be triaged label Feb 20, 2023
@Amogh35
Copy link
Contributor

Amogh35 commented Feb 21, 2023 •
edited
Loading

Thanks for assigning this issue to me @noman2002, but after going through the issue, it seems that the coverage for the existing file is already at 100%. Below is the coverage report locally.

image

@noman2002
Copy link
Member

Thanks for the confirmation @Amogh35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Amogh35 Amogh35

Labels
good first issue Good for newcomers test Testing application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@palisadoes @noman2002 @Amogh35