-
-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor : scripts/__mocks__/@pdfme/generator.test.ts
from jest to vitest
#3525
Comments
@syedali237 I am assigning this to you Comment here to get assigned |
@syedali237 There appear to be flags related of jest and combined still in codecov . I think there are few references of them andremove them and make only one flag or else remove flags too |
@varshith257 ok assign it to me. |
@varshith257 should i also remove the "test" script from the package.json that runs jest test cases? |
and also all the jest devDependencies mentioned and also remove jest anywhere mentioned in a file? |
Yes, remove it and replace with vitest |
Do any of these files need to be updated too? There are multiple references to jest related packages |
@syedali237 Remove them we also have equivalent exact syntax in vitest for mockResolveValueOnce etc.. |
@varshith257 should I open a new issue and raise PR for it, as it includes removing dependencies as well? |
Link this issue rather new one |
ok |
sure, will look into that too. |
PTAL to verify. I merged the PR |
Closing. It appears to be working. |
Is your feature request related to a problem? Please describe.
This file is currently tested using Jest. As part of our migration to Vitest, we need to refactor the file's test cases to align with Vitest's syntax and features.
Acceptance Criteria
Additional context
https://github.com/PalisadoesFoundation/talawa-admin/pull/2457/files#diff-9a5a35cf8d7f02b2bba90905714b762560579c4789e9eb4cebb4607980aa3d93
https://vitest.dev/
Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship
The text was updated successfully, but these errors were encountered: