Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAVLink parachute docs - confirm #1977

Open
hamishwillee opened this issue Jul 27, 2022 · 1 comment
Open

MAVLink parachute docs - confirm #1977

hamishwillee opened this issue Jul 27, 2022 · 1 comment
Assignees

Comments

@hamishwillee
Copy link
Collaborator

@MaEtUgR I merged the parachute docs in https://github.com/PX4/PX4-user_guide/pull/1943/files#r919653233 with this comment:

Can you mark up that issue if I got anything wrong, and ideally PR fixes and answer:


I've looked at the code in PX4/PX4-Autopilot#18589 and I want to confirm my understanding

The big picture is clear - the MAV_CMD_DO_PARACHUTE is emitted if the parachute is detected and healthy on failsafe. The COM_PARACHUTE parameter is checked an will warn if a parachute is expected but not present/healthy.

The small picture is less clear:

  • PX4 appears to base its health checks on getting the heartbeat - that then sets SYS_STATUS.onboard_control_sensors_present_extended and .onboard_control_sensors_health_extended for the recovery system bit. Is that right?
  • What about the enabled flag? (onboard_control_sensors_enabled_extended) - doesn't seem to be set. I would kind have expected enabled to be based on the COM_PARACHUTE parameter.
  • I guess we're assuming that a parachute is always "in a good state". Otherwise we need a mechanism for it to actually tell the flight stack it is OK.
  • What is COM_PARACHUTE supposed to do other than be a trigger for sending events when the heartbeat is lost?
  • Should COM_PARACHUTE be set for a PWM parachute? In this case how would you know if it is "healthy" etc? Presumably you will still want to emit this info for a GCS?
  • Is the MAV_CMD_DO_PARACHUTE sent to the specific component that emits the MAV_TYPE_PARACHUTE? What if two are connected? Or is it just sent to current system ID and component 0 (broadcast).
  • Is the MAV_CMD_DO_PARACHUTE command forwarded? i.e. can a GCS trigger the parachute? Should it?
@hamishwillee
Copy link
Collaborator Author

@MaEtUgR When you have a moment, would be good to clarify this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants