Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio buttons not showing up in QR code #6

Open
fuddster opened this issue Feb 5, 2022 · 4 comments
Open

Radio buttons not showing up in QR code #6

fuddster opened this issue Feb 5, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@fuddster
Copy link
Collaborator

fuddster commented Feb 5, 2022

When a radio button does not have a default value and is not manually checked, its code will not show up in the QR code.

The code goes through each element and adds the code only if checked. It should probably add the code anyway and leave it blank if nothing is checked.

It also breaks the "clear form" function.

@fuddster fuddster added the bug Something isn't working label Feb 5, 2022
fuddster added a commit that referenced this issue Dec 23, 2022
@fuddster
Copy link
Collaborator Author

Workaround for now - Always have a default value for Radio buttons. If there is a default then it will always be reset to the default value and that will be reported for the field.

@zaaj
Copy link
Contributor

zaaj commented Oct 27, 2023

To test: does this bug still exist in the refactored getData function?

@zaaj
Copy link
Contributor

zaaj commented Oct 29, 2023

As a test, I just ran through the form, using Inspect Element to clear the default value for the Floor Pick Up field (fpu) so no option was checked. At the QR code screen I used the Display Data button, and among the key=value; pairs I saw: ;fpu=;

So it appears that pull request #75 resolves this issue.

@zaaj
Copy link
Contributor

zaaj commented Nov 1, 2023

Just confirmed in TSV mode as well. I modified the text output to include a ; as well as a tab, since browsers consolidate whitespace in text output, and would not show consecutive tabs, and for the inspect-element-blanked radio button and its surrounding fields, I still got " 0; ; []" - two consecutive ;[tab] sequences, so I think it's safe to mark this bug resolved.

lstone24 added a commit to lstone24/ScoutingPASS that referenced this issue Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants