From 74c7ee8e2edc952cea29b87f52386ecd35edf235 Mon Sep 17 00:00:00 2001
From: Ivor D'Souza <ivor2048@outlook.com>
Date: Thu, 31 Oct 2024 01:50:17 +0000
Subject: [PATCH] fix bot suggestions

---
 pom.xml                               |  2 +-
 src/main/resources/logback-spring.xml | 22 ++++++++++++++--------
 2 files changed, 15 insertions(+), 9 deletions(-)

diff --git a/pom.xml b/pom.xml
index 2d6fde61..d1b7087b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -52,7 +52,7 @@
 		<dependency> 
 			<groupId>co.elastic.logging</groupId> 
 			<artifactId>logback-ecs-encoder</artifactId> 
-			<version>0.4.0</version> 
+			<version>1.3.2</version> 
 		</dependency>
 		<dependency>
 			<groupId>org.springframework.boot</groupId>
diff --git a/src/main/resources/logback-spring.xml b/src/main/resources/logback-spring.xml
index 232d4796..50aecbc8 100644
--- a/src/main/resources/logback-spring.xml
+++ b/src/main/resources/logback-spring.xml
@@ -1,21 +1,27 @@
 <configuration>
-    <property name="LOG_FILE" value="${LOG_FILE:-${LOG_PATH:-${LOG_TEMP:-${java.io.tmpdir:-/tmp}}}/my-api}"/>
-    <include resource="org/springframework/boot/logging/logback/defaults.xml"/>
-    <include resource="org/springframework/boot/logging/logback/console-appender.xml"/>
+    <property name="LOG_FILE"
+        value="${LOG_FILE:-${LOG_PATH:-${LOG_TEMP:-${java.io.tmpdir:-/tmp}}}/my-api}" />
+    <include resource="org/springframework/boot/logging/logback/defaults.xml" />
+    <include resource="org/springframework/boot/logging/logback/console-appender.xml" />
     <appender name="ECS_JSON_FILE" class="ch.qos.logback.core.rolling.RollingFileAppender">
         <file>${LOG_FILE}.json</file>
         <rollingPolicy class="ch.qos.logback.core.rolling.TimeBasedRollingPolicy">
             <fileNamePattern>${LOG_FILE}.json.%d{yyyy-MM-dd}.gz</fileNamePattern>
-            <maxFileSize>10MB</maxFileSize>
+            <maxFileSize>100MB</maxFileSize>
             <maxHistory>0</maxHistory>
-            <totalSizeCap>10MB</totalSizeCap>
             <cleanHistoryOnStart>true</cleanHistoryOnStart>
         </rollingPolicy>
-        <encoder class="co.elastic.logging.logback.EcsEncoder"/>
+        <encoder class="co.elastic.logging.logback.EcsEncoder" />
+    </appender>
+    <appender name="ASYNC_ECS" class="ch.qos.logback.classic.AsyncAppender">
+        <appender-ref ref="ECS_JSON_FILE" />
+        <queueSize>512</queueSize>
+        <discardingThreshold>0</discardingThreshold>
+        <includeCallerData>false</includeCallerData>
     </appender>
 
     <root level="INFO">
-        <appender-ref ref="CONSOLE"/>
-        <appender-ref ref="ECS_JSON_FILE"/>
+        <appender-ref ref="CONSOLE" />
+        <appender-ref ref="ASYNC_ECS" />
     </root>
 </configuration>
\ No newline at end of file