Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release as deb package for hydro #4

Closed
k-okada opened this issue Jun 23, 2014 · 8 comments
Closed

release as deb package for hydro #4

k-okada opened this issue Jun 23, 2014 · 8 comments

Comments

@k-okada
Copy link
Contributor

k-okada commented Jun 23, 2014

if someone create pr2_navigagtion-release repository, I think I can help you, to run bloom to create configuration files and send PR to you.

@UltronDestroyer
Copy link
Contributor

Hi k-okada,

has this been tested at all? I think it's missing testing on a real robot and with simulation. I'm going to go ahead and release this anyway as I don't believe anyone will be using it immediately or trying to at least.

@k-okada
Copy link
Contributor Author

k-okada commented Jul 8, 2014

No I have not tested, but due to everyone is talking that EOL of groovy, I think we should release this ans ask for testing on real robot and/or simulation.

@UltronDestroyer
Copy link
Contributor

Sure. I attempted to release this on Thursday-ish, but I ran into some permissions issues with the bloom command. Are you able to release this? The repo for pr2_navigation has been created

@k-okada
Copy link
Contributor Author

k-okada commented Jul 14, 2014

ok, but could you give me a permission to pr2_navigation-release repo? or could you show me the error message of the bloom command?

@UltronDestroyer
Copy link
Contributor

https://github.com/orgs/PR2/teams/package-release

Added to package-release teams. Let me know if you need anything else to release the package.

@airballking
Copy link

@k-okada At Bremen, we have so far run our navigation and localization code still under Groovy. Today, we played around with the new catkinized code out of the hydro-devel branch of this repo. Thanks for providing this! However, we ran into several problems, e.g. compilation of pr2_navigation_self_test, running stuff out of the overlay on c2, finding some of the plugins...

Before we try to debug these issues in Bremen, have you already got this meta-package running and working in your lab? If yes, what setup or top-level launch-file do you use? If no, I'll keep you posted and provide pull requests as we go along. :)

Just for reference, here is the relevant excerpt out of our launch-file (so that you know what we tried to run):

<include file="$(find pr2_machine)/$(env ROBOT).machine" />
<include file="$(find pr2_navigation_global)/amcl_node.xml" />
<include file="$(find pr2_navigation_teleop)/teleop.xml" />
<include file="$(find pr2_navigation_perception)/lasers_and_filters.xml" />
<include file="$(find pr2_navigation_perception)/ground_plane.xml" />
<include file="$(find pr2_navigation_global)/move_base.xml" />

@k-okada
Copy link
Contributor Author

k-okada commented Jul 24, 2014

Unfortunately I haven't test these code, just to confirm it is working in catkin, I'll check this on our robot during this week with @aginika

@aginika
Copy link
Contributor

aginika commented Sep 3, 2014

@airballking You may have resolved the problems already, but we tested on the real robot with rviz 2d_nav_goal and made sure that navigation seems to work in our environment. Lasers are correctly took into account and the obstacles is shown in costmaps.
We launched the below launch file (please ignore the jsk_maps include file, that is our map server and static tf publishers)

<launch>
  <include file="$(find pr2_machine)/$(env ROBOT).machine" />
  <include file="$(find jsk_maps)/launch/start_map_eng2.launch">
    <arg name="MACHINE" value="c2" />
  </include>
  <include file="$(find pr2_navigation_global)/amcl_node.xml" />
  <include file="$(find pr2_navigation_teleop)/teleop.xml" />
  <include file="$(find pr2_navigation_perception)/lasers_and_filters.xml" />
  <include file="$(find pr2_navigation_perception)/ground_plane.xml" />
  <include file="$(find pr2_navigation_global)/move_base.xml" />
</launch>

Sorry for being late.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants