Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splitting off NonPR2 Functionality #21

Open
DLu opened this issue Jun 18, 2015 · 4 comments
Open

Splitting off NonPR2 Functionality #21

DLu opened this issue Jun 18, 2015 · 4 comments

Comments

@DLu
Copy link

DLu commented Jun 18, 2015

#20 reminded me that there are portions of this "stack" that are not PR2 specific and should likely be spun off into their own non-PR2 based package.
@UltronDestroyer
Copy link
Contributor

Namely what portions? I'm willing to work with separating this out if you take the lead on it.

@DLu
Copy link
Author

DLu commented Jun 18, 2015

Arguably, the three parts with actual code:

  • laser_tilt_controller_filter
  • pr2_navigation_self_filter
  • semantic_point_annotator

However, I'm not sure if anyone is using any of this code for non-PR2 applications, other than the self_filter.

@UltronDestroyer
Copy link
Contributor

Continuing on from #20

@garaemon could you please make a PR to https://github.com/PR2/robot_self_filter?

@garaemon garaemon mentioned this issue Jun 24, 2015
Merged
@garaemon
Copy link
Contributor

I created a PR PR2/robot_self_filter#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@garaemon @DLu @UltronDestroyer