Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dummy masses - can they be removed yet? #287

Open
jesseli2002 opened this issue Oct 8, 2020 · 1 comment
Open

Dummy masses - can they be removed yet? #287

jesseli2002 opened this issue Oct 8, 2020 · 1 comment

Comments

@jesseli2002
Copy link

There's a couple of dummy masses with notes saying "to be removed" - can they be taken out, or at least be documented to indicate why they still need to be there and when they can be removed?

Specific locations - upper_arm.urdf.xacro, shoulder.urdf.xacro, forearm.urdf.xacro. Searching for "dummy" brings them up.

I can submit a PR if there's no reason to keep them.

@v4hn
Copy link
Member

v4hn commented Oct 8, 2020

Try removing them and load a Gazebo environment.
It seems the inertial tags where specified because they were not optional in some tool that read the description.

The specified values (100g mass for all components and low diagonal inertia matrices) clearly do not make much sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants