Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper methods to tools, like dt and skeletonize #989

Open
jgostick opened this issue Sep 16, 2024 · 1 comment
Open

Add helper methods to tools, like dt and skeletonize #989

jgostick opened this issue Sep 16, 2024 · 1 comment
Assignees
Labels
easy enhancement maint PR tag for maintenance related changes

Comments

@jgostick
Copy link
Member

Instead of importing edt from either edt or pyedt all over the place, we should just create a function in tools called get_edt which does this check and returns the correct one.

@jgostick jgostick added easy maint PR tag for maintenance related changes labels Sep 16, 2024
@jgostick
Copy link
Member Author

Having to deal with the skimage deprecation debacle of the last few days, I am now wondering if EVERYTHING should be wrapped? If we only used skimage.morphology.skeletonize_3d in one place (i.e. porespy.tools.skeletonize), then we'd only have to change it in one place. I guess it would be hard to decide where to draw the line. Like we can probably count on scipy and numpy to be stable. I would have expected skimage to be stable too, though that is not the case.

@jgostick jgostick changed the title We should add a dt helper method to tools Add a helper method to tools, like dt and skeletonize Jan 15, 2025
@jgostick jgostick changed the title Add a helper method to tools, like dt and skeletonize Add helper methods to tools, like dt and skeletonize Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy enhancement maint PR tag for maintenance related changes
Projects
None yet
Development

No branches or pull requests

2 participants