Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace overlay with insert_shape_at_point #951

Open
jgostick opened this issue Mar 27, 2024 · 2 comments
Open

Replace overlay with insert_shape_at_point #951

jgostick opened this issue Mar 27, 2024 · 2 comments
Labels
enhancement

Comments

@jgostick
Copy link
Member

The overlay function should accept a mode, which can be one of 'add', 'preserve', 'overwrite'. It's currently only doing 'add'.
@jgostick
Copy link
Member Author

It also does not work in 2D as mentioned in #950 (which I will close)

@jgostick jgostick mentioned this issue Jan 15, 2025
Closed
@jgostick
Copy link
Member Author

In fact, this function is pretty janky as it's written in pure python. It should be re-written as a generic version of the insert_disks_at_points function(s). Instead of passing in r, you pass im_to_insert.

@jgostick jgostick changed the title overlay needs modes Replace overlay with insert_shape_at_point Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jgostick