Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to do in online change #1322

Open
ghaith opened this issue Oct 1, 2024 · 0 comments
Open

Changes to do in online change #1322

ghaith opened this issue Oct 1, 2024 · 0 comments

Comments

@ghaith
Copy link
Collaborator

ghaith commented Oct 1, 2024

Collecting issues that we should still do on online change:

Unwrapping std::sync::Mutex::into_inner does not seem very safe to me - but as you said, since this is hidden behind a feature flag, we can leave it in for now.

Originally posted by @mhasel in #1319 (comment)

Handle the FIXME: comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant