Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About Und_s metric #23

Open
LeeYN-43 opened this issue Dec 23, 2023 · 0 comments
Open

About Und_s metric #23

LeeYN-43 opened this issue Dec 23, 2023 · 0 comments

Comments

@LeeYN-43
Copy link

LeeYN-43 commented Dec 23, 2023

Thanks for you great work!
The "is_contain" function used in computing Und_s seems to have an error.

def is_contain(bb1, bb2):
xl_1, yl_1, xr_1, yr_1 = bb1
xl_2, yl_2, xr_2, yr_2 = bb2
c1 = xl_1 <= xl_2
c2 = yl_1 <= yl_2
"c3 = xr_2 >= xr_2"
c4 = yr_1 >= yr_2
return c1 and c2 and c3 and c4

Shouldn't it be changed to "c3 = xr_1 >= xr_2" ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant