Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No wegihts for loss functions #17

Open
UdonDa opened this issue Aug 17, 2023 · 1 comment
Open

No wegihts for loss functions #17

UdonDa opened this issue Aug 17, 2023 · 1 comment

Comments

@UdonDa
Copy link

UdonDa commented Aug 17, 2023

Hi, @theKinsley!
Thank you for sharing your nice code!

I check your RecLoss.py, then I find that self.weight_dict is not used. So, current your code does not apply any weights for objectives.
https://github.com/PKU-ICST-MIPL/PosterLayout-CVPR2023/blob/main/RecLoss.py#L100

Actually, DETR applies the weight in the training loop.
https://github.com/facebookresearch/detr/blob/3af9fa878e73b6894ce3596450a8d9b89d918ca9/engine.py#L35

It should be applied here or inside of SetCriterion.
Is this a mistake after your refactoring?

@UdonDa UdonDa changed the title No wegihts of loss functions No wegihts for loss functions Aug 17, 2023
@theKinsley
Copy link
Contributor

Hello UdonDa, thank you for reporting the issue.
Exactly, we adopt the partial code from DETR. The weights are as default (unchanged as original) but seems not applied appropriately, so they are actually 1:1:1 during our implementation in this version.
Thank you for pointing this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants