Regression in phpspreadsheet 1.28.0 in comparison to 1.24.1: Euro currency format doesn't work right anymore

[finn-matti]

This is:

- [x] a bug report
- [ ] a feature request
- [ ] **not** a usage question (ask them on https://stackoverflow.com/questions/tagged/phpspreadsheet or https://gitter.im/PHPOffice/PhpSpreadsheet)

What is the expected behavior?

(See the example project below)

The created file should handle numbers formatted as currencies correctly:

What is the current behavior?

It doesn't display them correctly (at least) in Microsoft Excel for Mac 16.16.27:

What are the steps to reproduce?

See: https://github.com/finn-matti/phpspreadsheet-problem for a minimal project.

What features do you think are causing the issue

- [ ] Reader
- [x] Writer
- [ ] Styles
- [ ] Data Validations
- [ ] Formula Calculations
- [ ] Charts
- [ ] AutoFilter
- [ ] Form Elements

Does an issue affect all spreadsheet file formats? If not, which formats are affected?

I have only tested it with xlsx.

Which versions of PhpSpreadsheet and PHP are affected?

1.28.0 and 1.24.1. I have not tested any other versions.

[oleibman]

Your problem appears to have been caused by PR #3377, which changed the definition for the class constant you are using from a style with decimal positions to a style without decimal positions. If you know you will run only on 1.28 or later, you can use NumberFormat::FORMAT_CURRENCY_EUR to achieve the result you want. If you need your code to run on earlier versions as well, you can either hard-code the desired style, or you can use the following really ugly workaround:

    $numberFormat = defined(NumberFormat::class . '::FORMAT_CURRENCY_EUR_INTEGER')
        ? NumberFormat::FORMAT_CURRENCY_EUR
        : NumberFormat::FORMAT_CURRENCY_EUR_SIMPLE;
    $this->worksheet->getStyleByColumnAndRow(1, 1)
                    ->getNumberFormat()
                    ->setFormatCode($numberFormat);

[finn-matti]

@oleibman That's right. That shouldn't have happened. Nothing we can do about it now.

[oleibman]

Agree that it's unfortunate, and that previous behavior can no longer be restored. Closing ticket.

[mjomble]

We still have the option of clearly marking it as an accidental breaking change in the changelog / release notes, etc.

I just ran into the same issue and came here to figure out how I missed a breaking change, but saw the change still marked as a simple deprecation in the changelog.

[oleibman]

I have updated the change log with PR #3787 which I have just merged.