Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create separate implementations instead of extending #12

Open
afilina opened this issue Mar 25, 2021 · 0 comments · May be fixed by #19
Open

Create separate implementations instead of extending #12

afilina opened this issue Mar 25, 2021 · 0 comments · May be fixed by #19

Comments

@afilina
Copy link
Collaborator

afilina commented Mar 25, 2021

Classes should be final and we should not extend implementations. It's okay to copy an existing to make the necessary changes. We can always extract truly reusable elements and inject them as dependencies instead. The test for the new class should encompass the common elements as well, otherwise we're not truly testing them, and any unintended regressions would go unnoticed. Not a deal breaker and I'm happy to address the issue in a subsequent commit.

Originally posted by @afilina in #10 (comment)

@afilina afilina linked a pull request Mar 30, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant