Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error pop up while trying to register #130

Closed
harasees-singh opened this issue Nov 13, 2023 · 8 comments
Closed

error pop up while trying to register #130

harasees-singh opened this issue Nov 13, 2023 · 8 comments
Assignees

Comments

@harasees-singh
Copy link
Contributor

image

NOTE: error spotted on localhost only (on main branch)

@harshjohar
Copy link
Member

What exactly is happening? Please answer the following points:

  • is the registration successful?
  • is the mail getting sent properly?
  • is the user able to login even after this error?
  • was the user already present in db?

@harasees-singh
Copy link
Contributor Author

What exactly is happening? Please answer the following points:

  • is the registration successful? yes
  • is the mail getting sent properly? mail not sent
  • is the user able to login even after this error? won't be able to login since verification mail is not sent
  • was the user already present in db? no

@harshjohar
Copy link
Member

What exactly is happening? Please answer the following points:

  • is the registration successful? yes
  • is the mail getting sent properly? mail not sent
  • is the user able to login even after this error? won't be able to login since verification mail is not sent
  • was the user already present in db? no

Alright, will look into this issue asap

@harshjohar
Copy link
Member

meanwhile, @aadityavvij can use postman to verify his user and start working on #128 ig

@harasees-singh
Copy link
Contributor Author

meanwhile, @aadityavvij can use postman to verify his user and start working on #128 ig

he has already done that

@harasees-singh
Copy link
Contributor Author

harasees-singh commented Nov 13, 2023

I think the issue is that I have not defined the env var NODEMAILER_EMAIL and NODEMAILER_PW. However the error pop up fails to communicate this issue in case this indeed is the issue

@harshjohar
Copy link
Member

Yes, just checked this is the issue. Basically, but we dont need this error handling on prod, because the env vars will always be present there. We can just ask developers to read the README.md and follow all instructions properly.

@harshjohar
Copy link
Member

Screenshot 2023-11-13 at 6 00 36 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants