Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #105 : forgot-password-ui-added #119

Merged
merged 3 commits into from
Nov 5, 2023
Merged

Conversation

aadityavvij
Copy link
Collaborator

issue #105 resolved

Copy link

vercel bot commented Nov 5, 2023

@aadityavvij is attempting to deploy a commit to the ACM HEADS Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@harshjohar harshjohar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the forgot-password.tsx to forgot-password/index.tsx for uniformity. Rest work good!

Comment on lines 110 to 114
await new Promise((resolve) => setTimeout(resolve, 5000));
return { success: true };
} catch (error) {
return { success: false, error: { message: `Error sending email to ${email}` } };
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now return only False, until we push the logic with real backend. So that user feels that it is really failing, not a problem with their id.

Copy link

vercel bot commented Nov 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pecacm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2023 8:01pm

Copy link
Member

@harshjohar harshjohar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PERFECT! (UI is really neat)

@harshjohar harshjohar merged commit 32c945b into PEC-CSS:main Nov 5, 2023
@harshjohar harshjohar linked an issue Nov 5, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forgot password UI
2 participants