Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Langauge choice window modal and unclosable #6517

Open
jfalconnet opened this issue Jun 5, 2021 · 3 comments · Fixed by #6594
Open

[BUG] Langauge choice window modal and unclosable #6517

jfalconnet opened this issue Jun 5, 2021 · 3 comments · Fixed by #6594
Labels

Comments

@jfalconnet
Copy link

Describe the bug
The window to select language is stick. When I click Cancel or Ok nothing happends, and I cant do anything else I have to kill the app.

To Reproduce
Steps to reproduce the behavior:

  1. Lauch PCGEN (6.09.05)
  2. Click on Sources > Load Sources SRD 3.5 for Players
  3. Click on New
  4. Set Intelligence to 12
  5. On the left of summary page, click the "Add Bonus Language"
  6. Click ok. (or cancel)
  7. The Add Bonus Language does not close, and nothing respond anymore.

The behavior is the same if we have chosen a Race before (and thus have chosen a possible language)
The behavior is the same through Add Language via Skill point
The behavior is the same through "Feats & Abilities" > Misc > GM Awards > Add Language : but only if we choose "cancel" (with other sources that allow this GM awards)

Expected behavior
The window should close and we should be able to go on.

Screenshots
PcgenLangBug

Desktop (please complete the following information):

  • OS: Ubuntu
  • Version: 20.04.2 LTS

Additional context
For the "Feats & Abilities" > Misc > GM Awards > Add Language" way, there is a misspell : the window title is "Langauge choice" instead of "Language choice".

@jfalconnet jfalconnet added the bug label Jun 5, 2021
@pokemonpasta
Copy link
Contributor

Reproducible in 6.09.05, Ubuntu 20.04, openjdk-11. I should let you know though that 6.09.05 does have quite a few issues with stuff like pop-up windows hanging indefinitely, due to undergoing work to transition the UI from Java Swing to JavaFX. Development is slow across the board in PCGen, so if you like, 6.08.00RC8 is also supported and doesn't have a lot of these issues.

grimreaper added a commit to grimreaper/pcgen that referenced this issue Sep 23, 2021
grimreaper added a commit to grimreaper/pcgen that referenced this issue Sep 23, 2021
@grimreaper
Copy link
Member

grimreaper commented Sep 23, 2021

Not reproduced on master. In my screen I see this:
image

but am able to hit "okay" or "close"

if instead I choose "add language via skill points" I do see this:
image

but am able to close/cancel/X

perhaps we just need a release?

@grimreaper
Copy link
Member

The referenced bug was a partial fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants