Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couple of improvements that could be made #2

Open
Cilusse opened this issue Jun 26, 2020 · 3 comments
Open

Couple of improvements that could be made #2

Cilusse opened this issue Jun 26, 2020 · 3 comments

Comments

@Cilusse
Copy link

Cilusse commented Jun 26, 2020

Hi!

First of all, thank you for creating this handy little container. I’m running it on my Unraid box to keep my domain name up to date.

Here are a couple of things I thought would be nice to have:

  • Update IP on startup: it doesn’t seem that the container is checking for the IP as soon as it’s started, but only after 15 mins, when the cron job kicks in. Would it make more sense to make it check when starting up and then every 15 mins ?

  • Check interval: would it be possible to add a variable for the cron job frequency ?

  • Logs: right now, the logs button on Unraid Dockers doesn’t show anything, is there a way to link your log file to this ?

  • IP check provider: maybe add a list of different IP checking services to allow the user to select something else than Google for example.

  • Unraid Community Applications: You could also add your container to the CA tab in Unraid, allowing a quick and easy install with variables in a template and improve the usability of your container for Unraid users.

That’s all I could think of right now, let me know if you are still maintaining this container. Maybe you just wrote it for your own use and meeting your needs and requirements, which I would totally understand. I could also fork it and modify to make my own but I wanted to know your position regarding your work first.

Thank you if you read and reply to this!
All the best and stay safe :)

@P4sca1
Copy link
Owner

P4sca1 commented Jun 26, 2020

Hey! All of your suggestions seem quite useful. It would make sense to support other providers too. You are right that I wrote the container for personal use first and wanted to share it with others. I am totally fine with you forking this repo and adding the mentioned features, thanks for asking!

@P4sca1
Copy link
Owner

P4sca1 commented Jun 26, 2020

I may find time to do some of these by myself in the future, but I don’t have much spare time at the moment.

@Cilusse
Copy link
Author

Cilusse commented Jun 26, 2020

Great! I might have a little play around with the code, as a way to learn the basis of Docker. As it is now, the container works perfectly for my use too so I don't really need to modify it, but it could be cool just as an experiment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants