Sort by creative menu

[Fiocher]

None of the existing sorting methods can be ordered like creative menu, including the latest sorting method "by mod".
e.g.

[P3pp3rF1y]

This is very very unlikely to make it to the mod. The reason is performance because it would require creating a sort order based on creative tabs and then using this sort order for sorting and even with caching this is likely going to have very negative effect on server when player sorts

[Fiocher]

This is very very unlikely to make it to the mod. The reason is performance because it would require creating a sort order based on creative tabs and then using this sort order for sorting and even with caching this is likely going to have very negative effect on server when player sorts

Ok, I just think the sorting logic of this mod is unusual and seems a little confusing.
I also find some other mods to compare:

Sort by mod (Sophisticated Backpacks)

Sort by tags (Sophisticated Backpacks)

Sort (Inventory Profiles Next)

JEI

Creative Menu

[P3pp3rF1y]

The sorting is easy - sorts by name if you're sorting by item or mod name (with mod it sorts by mod first)

And IPN is a great example of sorting by creative tabs causing performance issues. They specifically had to make changes to prevent that when sorting even in smallest of inventories. And I believe there's still a switch to block that for server owners so that they can prevent players from tanking their servers by "just" sorting.

Creative tabs or JEI don't sort at all they just show items in the order the mods have initialized the items for them.

[Fiocher]

The sorting is easy - sorts by name if you're sorting by item or mod name (with mod it sorts by mod first)

And IPN is a great example of sorting by creative tabs causing performance issues. They specifically had to make changes to prevent that when sorting even in smallest of inventories. And I believe there's still a switch to block that for server owners so that they can prevent players from tanking their servers by "just" sorting.

Creative tabs or JEI don't sort at all they just show items in the order the mods have initialized the items for them.

I seem to understand a little, if sort by the initialized items of the mod, are there any performance issues?

[P3pp3rF1y]

There most definitely are issues if you try to sort by it yes. As said creative tabs or JEI don't sort items they only show whatever mc / mods provided them for the list of item. So for example in my dev environment where I only have a very minimal list of mods added on top of sophisticated there's about 20,000 items in creative tabs so when creative tabs display they only have to get this list from mods (only for search tab because for the other tabs it's limited to specific mod), JEI caches the list so it only gets it once when you open a world and from there on just displays it.

Now if you wanted to apply sorting against this of let's say 100 items (about what diamond single chest or iron double chest can hold so this number can get much larger) that would mean looking up 100 items in that list of 20,000, on average that would take about 100 x 10,000 or 1,000,000 operations to lookup and just meager about 700 operations to compare the order which is what it does today.
But now you also have to count in additional things like

• bigger than very minimalistic modpacks are likely to have much larger number of items so we're speaking of probably something like 100,000 items in an average one and even more in big ones like ATM and the average number of operations would get to something like 5,000,000
• the comparisons of names done at the moment are pretty simple, but with comparisons against the sorted list you need to keep in mind that many of these items have nbt so nbt would need to be compared so those millions of operations are also much more CPU intesive
• the other thing with nbt is that the one stored in creative tab is going to be different from the one that you have in your backpack e.g. you charge the building gadget that's different nbt, you change mode on the building gadget that's different nbt, ... So in fact there may need to be even more expensive operations of partially comparing nbt when figuring out where the item is in the sort order

And with creative tabs / JEI they only initialize their list on client and I am sure player is cool with their client spending some cycles on that however sorting needs to be done on server so all of this would be pushed on server and I am sure the first thing I would see from server owners is request for setting to disable this and making it disabled by default

[Fiocher]

There most definitely are issues if you try to sort by it yes. As said creative tabs or JEI don't sort items they only show whatever mc / mods provided them for the list of item. So for example in my dev environment where I only have a very minimal list of mods added on top of sophisticated there's about 20,000 items in creative tabs so when creative tabs display they only have to get this list from mods (only for search tab because for the other tabs it's limited to specific mod), JEI caches the list so it only gets it once when you open a world and from there on just displays it.

Now if you wanted to apply sorting against this of let's say 100 items (about what diamond single chest or iron double chest can hold so this number can get much larger) that would mean looking up 100 items in that list of 20,000, on average that would take about 100 x 10,000 or 1,000,000 operations to lookup and just meager about 700 operations to compare the order which is what it does today. But now you also have to count in additional things like

• bigger than very minimalistic modpacks are likely to have much larger number of items so we're speaking of probably something like 100,000 items in an average one and even more in big ones like ATM and the average number of operations would get to something like 5,000,000
• the comparisons of names done at the moment are pretty simple, but with comparisons against the sorted list you need to keep in mind that many of these items have nbt so nbt would need to be compared so those millions of operations are also much more CPU intesive
• the other thing with nbt is that the one stored in creative tab is going to be different from the one that you have in your backpack e.g. you charge the building gadget that's different nbt, you change mode on the building gadget that's different nbt, ... So in fact there may need to be even more expensive operations of partially comparing nbt when figuring out where the item is in the sort order

And with creative tabs / JEI they only initialize their list on client and I am sure player is cool with their client spending some cycles on that however sorting needs to be done on server so all of this would be pushed on server and I am sure the first thing I would see from server owners is request for setting to disable this and making it disabled by default

Thank you for your detailed explanation! 👍

When it comes to IPN, I have a question, IPN has a continuous crafting feature, which is useful for crafting items that can't be stacked, but this feature is not available on Sophisticated Backpacks.

If want to make both compatible, to whom should I create compatibility request?

[P3pp3rF1y]

I have that feature on the list of future features on my side, not really as a compatibility, but one that's directly included in sophisticated.

[Fiocher]

I have that feature on the list of future features on my side, not really as a compatibility, but one that's directly included in sophisticated.

It's great. I'm looking forward to it.