Added mean temperature and light report at predictions.csv #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It might be a good idea to add an error catch in case columns temperature or light are not present in the raw data. |
angerhang
requested changes
Jul 23, 2024
| # Grouping by time | ||
| grouped = data.groupby(pd.Grouper(key='time', freq='30S', origin=data['time'].min())) | ||
| # Calculating the mean temperature and light for each group | ||
| mean_values = grouped[['temperature', 'light']].mean().iloc[:-1] |
There was a problem hiding this comment.
Could you include an exception handler here to exit the file processing when no temperature or light data is available? No all the devices have these information.
There was a problem hiding this comment.
Also some of the CI testes failed. Would be good if these are also addressed :D
https://github.com/OxWearables/asleep/actions/runs/9999071709/job/27810403819?pr=53
There was a problem hiding this comment.
@spiousas the CI test still failed though. The formatting should be easy to fix :D
There was a problem hiding this comment.
I am sorry, I missed some fixes. Now it should be OK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an optional report of the mean temperature and light for each 30-second interval. This will work only for wearables containing temperature and light data stored in columns named
temperatureandlight, respectively (for example, Axivity AX3).When adding the parameter
--report_light_and_tempto theget_sleepfunction call, two columns will be added to the predictions.csv file. They contain the mean light and temperature for the interval in the units and scale the wearable provides.Use:
Example output: