add CF support for Logs::SubscriptionFilter resources

Author: whummer

localstack/services/cloudformation/service_models.py

@@ -285,6 +285,62 @@ def fetch_state(self, stack_name, resources):
         groups = logs.describe_log_groups(logGroupNamePrefix=group_name)['logGroups']
         return ([g for g in groups if g['logGroupName'] == group_name] or [None])[0]
 
+    @staticmethod
+    def get_deploy_templates():
+        return {
+            'create': {
+                'function': 'create_log_group',
+                'parameters': {
+                    'logGroupName': 'LogGroupName'
+                }
+            },
+            'delete': {
+                'function': 'delete_log_group',
+                'parameters': {
+                    'logGroupName': 'LogGroupName'
+                }
+            }
+        }
+
+
+class LogsSubscriptionFilter(GenericBaseModel):
+    @staticmethod
+    def cloudformation_type():
+        return 'AWS::Logs::SubscriptionFilter'
+
+    def get_physical_resource_id(self, attribute=None, **kwargs):
+        return self.props.get('LogGroupName')
+
+    def fetch_state(self, stack_name, resources):
+        props = self.props
+        group_name = self.resolve_refs_recursively(stack_name, props.get('LogGroupName'), resources)
+        filter_pattern = self.resolve_refs_recursively(stack_name, props.get('FilterPattern'), resources)
+        logs = aws_stack.connect_to_service('logs')
+        groups = logs.describe_subscription_filters(logGroupName=group_name)
+        groups = [g for g in groups['subscriptionFilters'] if g.get('filterPattern') == filter_pattern]
+        return (groups or [None])[0]
+
+    @staticmethod
+    def get_deploy_templates():
+        return {
+            'create': {
+                'function': 'put_subscription_filter',
+                'parameters': {
+                    'logGroupName': 'LogGroupName',
+                    'filterName': 'LogGroupName',  # there can only be one filter associated with a log group
+                    'filterPattern': 'FilterPattern',
+                    'destinationArn': 'DestinationArn'
+                }
+            },
+            'delete': {
+                'function': 'delete_subscription_filter',
+                'parameters': {
+                    'logGroupName': 'LogGroupName',
+                    'filterName': 'LogGroupName'
+                }
+            }
+        }
+
 
 class CloudFormationStack(GenericBaseModel):
     @staticmethod

localstack/services/route53/route53_listener.py

@@ -12,6 +12,8 @@ class Route53Backend(RegionBackend):
     def __init__(self):
         # maps zone ID to association details
         self.vpc_hosted_zone_associations = {}
+        # maps delegation set ID to reusable delegation set details
+        self.reusable_delegation_sets = {}
 
 
 class ProxyListenerRoute53(PersistingProxyListener):

localstack/utils/cloudformation/template_deployer.py

@@ -146,20 +146,6 @@ def get_apigw_resource_params(params, **kwargs):
             }
         }
     },
-    'Logs::LogGroup': {
-        'create': {
-            'function': 'create_log_group',
-            'parameters': {
-                'logGroupName': 'LogGroupName'
-            }
-        },
-        'delete': {
-            'function': 'delete_log_group',
-            'parameters': {
-                'logGroupName': 'LogGroupName'
-            }
-        }
-    },
     'Lambda::Version': {
         'create': {
             'function': 'publish_version',

tests/integration/templates/template23.yaml

@@ -30,6 +30,18 @@ Resources:
 #        - - aws/lambda/
 #          - !Ref Environment
 #          - -function
+  LogSubscription:
+    Type: AWS::Logs::SubscriptionFilter
+    Properties:
+      LogGroupName: !Ref LogGroup
+      FilterPattern: "{$.userIdentity.type = Root}"
+      DestinationArn: !GetAtt KinesisStream.Arn
+
+  KinesisStream:
+    Type: AWS::Kinesis::Stream
+    Properties:
+      Name: stream-logs-sub-tgt-512
+      ShardCount: 1
 
   Role:
     Type: AWS::IAM::Role
@@ -105,4 +117,4 @@ Resources:
         }
       - {
         apiKey: !Ref ApiKey
-      }
+      }