Skip to content

Commit d076378

Browse files
authored
Merge pull request #7 from thdaele/master
fix: feather-gen change now updates the versionlist and dependencies
2 parents 11e8d25 + 6005c02 commit d076378

File tree

1 file changed

+21
-13
lines changed

1 file changed

+21
-13
lines changed

public/develop.js

Lines changed: 21 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,10 @@ import {
2323
gen1: document.getElementById("generation-gen1"),
2424
gen2: document.getElementById("generation-gen2")
2525
}
26-
document.getElementById("calamus-gen-selectors").addEventListener("change", async (e) => {
27-
const gen = Object.entries(genSelectorRadios).find(([_, button]) => button === e.target)[0];
28-
minecraftStableVersions = await getMinecraftStableVersions(gen);
29-
minecraftAllVersions = await getMinecraftVersions(gen);
30-
})
3126
const versionSelectorInput = document.getElementById("mc-version");
3227
const versionListElement = document.getElementById("version-list");
3328
const allowSnapshotsCheck = document.getElementById("allow-snapshots");
29+
const featherGenSelector = document.getElementById("calamus-gen-selectors");
3430

3531
function setExtraMsg(message) {
3632
document.getElementById("dependencies-extra-message").innerText = message;
@@ -47,6 +43,9 @@ import {
4743
async function updateOrnitheDependencies() {
4844
if (possibleVersions.some(version => versionSelectorInput.value === version)) {
4945
document.getElementById("ornithe-dependencies").innerText = await constructOrnitheDependenciesMessage();
46+
} else {
47+
document.getElementById("ornithe-dependencies").innerText = "Please select a valid Minecraft version!";
48+
setExtraMsg("");
5049
}
5150
}
5251

@@ -164,27 +163,36 @@ import {
164163

165164
versionSelectorInput.addEventListener("input", async _ => await updateOrnitheDependencies())
166165

167-
allowSnapshotsCheck.addEventListener("change", _ => {
166+
allowSnapshotsCheck.addEventListener("change", async _ => {
167+
updateVersionList();
168+
await updateOrnitheDependencies();
169+
})
170+
171+
featherGenSelector.addEventListener("change", async (e) => {
172+
const gen = Object.entries(genSelectorRadios).find(([_, button]) => button === e.target)[0];
173+
minecraftStableVersions = await getMinecraftStableVersions(gen);
174+
minecraftAllVersions = await getMinecraftVersions(gen);
175+
176+
updateVersionList();
177+
// Update the dependencies message since it depends on the feather gen
178+
await updateOrnitheDependencies();
179+
})
180+
181+
function updateVersionList() {
168182
if (allowSnapshotsCheck.checked) {
169183
possibleVersions = minecraftAllVersions;
170184
} else {
171185
possibleVersions = minecraftStableVersions;
172186
}
173-
updateVersionList();
174-
updateOrnitheDependencies();
175-
})
176187

177-
function updateVersionList() {
178-
const list = possibleVersions;
179188
while (versionListElement.firstChild) versionListElement.removeChild(versionListElement.lastChild);
180-
list.forEach(e => {
189+
possibleVersions.forEach(e => {
181190
const opt = new Option();
182191
opt.value = e;
183192
versionListElement.appendChild(opt);
184193
});
185194
}
186195

187-
possibleVersions = minecraftStableVersions;
188196
updateVersionList()
189197
await updateOrnitheDependencies()
190198

0 commit comments

Comments
 (0)