Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block uris with non-ascii characters #349

Open
lsat12357 opened this issue Aug 21, 2022 · 1 comment · May be fixed by #350
Open

block uris with non-ascii characters #349

lsat12357 opened this issue Aug 21, 2022 · 1 comment · May be fixed by #350
Assignees

Comments

@lsat12357
Copy link
Contributor

Currently, the crosswalk metadata service is allowing uris with non-ascii characters to pass through, and they are persisted in hyrax, only to blow up when the indexer runs. This in turn can cause other assets to blow up as well during nested indexing.
Since we are already doing a superficial check for the presence of a uri in any property that should have one, we can also check that the uri is ascii_only? and fail the migration before it tries to persist.

@lsat12357 lsat12357 self-assigned this Aug 21, 2022
@lsat12357
Copy link
Contributor Author

we should also add this check to preflight.

@lsat12357 lsat12357 linked a pull request Aug 22, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant