-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Controlled vocab terms standardize the protocol on stored uris #1342
Comments
Assigned @wickr to review and make sure I didn't miss or misunderstand anything. Then tag with ready for work and features |
Ensure that this works for typeahead label lookup in the form as well. |
QA Fail. Test work: https://staging.oregondigital.org/concern/images/cv43nw84m?locale=en#data_sources Test URIs for Creator: |
@wickr Can I have you check out the test work you did again? I figure out that the cacheing was the issue the label was not displaying for the those weird So I am currently trying to resave all works on staging so it can update it cacheing but the issue should be fix now hopefully and was wondering if you could do another test on it? Thank you! |
Still QA Fail @lamtu1 But I made another one, and added some different URIs. Some work, some don't. The new URIs for Artist work. They both seem to save as But I was able to save one for Photographer as I then added 2 more URIs in Subject. Both looked ok in the form, label fetched there. But when I saved, both URIs only saved as Test URIs for Photographer: Test URIs for Artist: Test URIs for Subject |
There's a needed discussion about the bigger picture on this and other parts as well regarding of |
Descriptive summary
Controlled vocab terms should be permissive in what they accept and rigorous with what they store. Before a fetch, controlled vocab terms should accept either http:// or https:// in uris, but when they receive the response it should be stored back in a standard protocol.
This is to help with bulk editing later, when you have thousands of values in a column and trying to sort on that column sorts on protocol first.
@wickr I assume this should be configurable at the vocabulary level? So we can force all the uris from an individual authority to be the same.
Expected behavior
URIs can come in as either http:// or https:// from the work form and bulk edit workflows, and the fetch request will gracefully handle communicating with the authority.
URIs are stored back in fedora and solr as either http:// or https://, configurable by the authority/vocab, regardless of input, request, or response.
Related work
Accessibility Concerns
The text was updated successfully, but these errors were encountered: