Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#157] On opacity screen, add a border around the view showing the opacity #162

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

[#157] On opacity screen, add a border around the view showing the opacity #162

wants to merge 1 commit into from
+8 −4

Conversation

ludovic35
Copy link
Member

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Description

Motivation & Context

Types of change

  • Bug fix (non-breaking which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • Design review has been done
  • Accessibiltiy review has been done
  • Q/A team has tested the evolution
  • Documentation has been updated if relevant
  • Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues

@ludovic35 ludovic35 linked an issue Oct 4, 2024 that may be closed by this pull request
[Demo App] On opacity screen, add a border around the view showing the opacity #157
Open
1 task
@ludovic35 ludovic35 marked this pull request as draft October 4, 2024 12:05
pylapp

This comment was marked as outdated.

Sign in to view

pylapp
pylapp requested changes Oct 4, 2024
View reviewed changes
CHANGELOG.md
@@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Added

- [DemoApp] On opacity screen, add a border around the view showing the opacity ([#157](https://github.com/Orange-OpenSource/ouds-ios/issues/157))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il faut que tu mettes à jour ta branche car le CHANGELOG n'est pas bon ; cette ligne est censée être dans la nouvelle section (unreleased) vierge de tout ajout aujourd'hui

@pylapp
Copy link
Member

pylapp commented Oct 4, 2024 •
edited
Loading

@ludovic35 Si ta PR est prête à être relue, retire l'état "draft". J'ai été notifié que tu voulais une revue, donc je m'attends naturellement à ce que la PR ne soit pas en draft.

Il faut aussi que tu synchronises (via rebase) ta branche avec develop qui a bougé depuis.

D'ailleurs tu n'as coché aucune case de ta PR ; or il y a une bonne partie que tu peux remplir ou remplacer par NA comme indiqué dans le template. On ne peut pas se permettre de devoir remettre d'équerre les PR de chacun ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pylapp pylapp pylapp requested changes

@Tayebsed93 Tayebsed93 Awaiting requested review from Tayebsed93 Tayebsed93 is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@ludovic35 ludovic35

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Demo App] On opacity screen, add a border around the view showing the opacity
2 participants
@ludovic35 @pylapp