Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Token] Spacing (semantic) modifications after Figma updates (4th of October) #156

Open
julien-deramond opened this issue Oct 4, 2024 · 0 comments
Assignees

Comments

@julien-deramond
Copy link
Member

Description

Some modifications have been done on Figma's side. Here's a diff showing what's been modified the 4th of October by the designers.

diff --git a/build/ios/semantic/SpaceSemanticTokens.swift b/build/ios/semantic/SpaceSemanticTokens.swift
index 5dad41c..df084f7 100644
--- a/build/ios/semantic/SpaceSemanticTokens.swift
+++ b/build/ios/semantic/SpaceSemanticTokens.swift
@@ -12,36 +12,36 @@
 // 
 
 public enum SpaceSemanticTokens {
-    public static let spaceScaledTabletTallest = dimension600
-    public static let spaceScaledTabletTaller = dimension500
-    public static let spaceScaledTabletTall = dimension400
-    public static let spaceScaledTabletSpacious = dimension700
-    public static let spaceScaledTabletSmash = dimension50
-    public static let spaceScaledTabletShortest = dimension100
-    public static let spaceScaledTabletShorter = dimension150
-    public static let spaceScaledTabletShort = dimension200
-    public static let spaceScaledTabletNone = dimension0
-    public static let spaceScaledTabletMedium = dimension300
-    public static let spaceScaledMobileTallest = dimension500
-    public static let spaceScaledMobileTaller = dimension400
-    public static let spaceScaledMobileTall = dimension300
-    public static let spaceScaledMobileSpacious = dimension600
-    public static let spaceScaledMobileSmash = dimension25
-    public static let spaceScaledMobileShortest = dimension50
-    public static let spaceScaledMobileShorter = dimension100
-    public static let spaceScaledMobileShort = dimension150
-    public static let spaceScaledMobileNone = dimension0
-    public static let spaceScaledMobileMedium = dimension200
-    public static let spaceScaledDesktopTallest = dimension700
-    public static let spaceScaledDesktopTaller = dimension600
-    public static let spaceScaledDesktopTall = dimension500
-    public static let spaceScaledDesktopSpacious = dimension800
-    public static let spaceScaledDesktopSmash = dimension50
-    public static let spaceScaledDesktopShortest = dimension100
-    public static let spaceScaledDesktopShorter = dimension200
-    public static let spaceScaledDesktopShort = dimension300
-    public static let spaceScaledDesktopNone = dimension0
-    public static let spaceScaledDesktopMedium = dimension400
+    public static let spaceScaledTallestTablet = dimension600
+    public static let spaceScaledTallestMobile = dimension500
+    public static let spaceScaledTallestDesktop = dimension700
+    public static let spaceScaledTallerTablet = dimension500
+    public static let spaceScaledTallerMobile = dimension400
+    public static let spaceScaledTallerDesktop = dimension600
+    public static let spaceScaledTallTablet = dimension400
+    public static let spaceScaledTallMobile = dimension300
+    public static let spaceScaledTallDesktop = dimension500
+    public static let spaceScaledSpaciousTablet = dimension700
+    public static let spaceScaledSpaciousMobile = dimension600
+    public static let spaceScaledSpaciousDesktop = dimension800
+    public static let spaceScaledSmashTablet = dimension50
+    public static let spaceScaledSmashMobile = dimension25
+    public static let spaceScaledSmashDesktop = dimension50
+    public static let spaceScaledShortestTablet = dimension100
+    public static let spaceScaledShortestMobile = dimension50
+    public static let spaceScaledShortestDesktop = dimension100
+    public static let spaceScaledShorterTablet = dimension150
+    public static let spaceScaledShorterMobile = dimension100
+    public static let spaceScaledShorterDesktop = dimension200
+    public static let spaceScaledShortTablet = dimension200
+    public static let spaceScaledShortMobile = dimension150
+    public static let spaceScaledShortDesktop = dimension300
+    public static let spaceScaledNoneTablet = dimension0
+    public static let spaceScaledNoneMobile = dimension0
+    public static let spaceScaledNoneDesktop = dimension0
+    public static let spaceScaledMediumTablet = dimension300
+    public static let spaceScaledMediumMobile = dimension200
+    public static let spaceScaledMediumDesktop = dimension400
     public static let spaceFixedTallest = dimension500
     public static let spaceFixedTallest = dimension500
     public static let spaceFixedTaller = dimension400
     public static let spaceFixedTall = dimension300
@@ -66,22 +66,24 @@ public enum SpaceSemanticTokens {
     public static let spaceRowGapShort = dimension9xs
     public static let spaceRowGapNone = dimensionNone
     public static let spaceRowGapMedium = dimension8xs
-    public static let spacePaddingInlineWithIconTallest = dimension3xs
-    public static let spacePaddingInlineWithIconTaller = dimension5xs
-    public static let spacePaddingInlineWithIconTall = dimension7xs
-    public static let spacePaddingInlineWithIconShorter = dimension10xs
-    public static let spacePaddingInlineWithIconShort = dimension9xs
+    public static let spacePaddingInlineWithIconTallest = dimension2xs
+    public static let spacePaddingInlineWithIconTaller = dimension3xs
+    public static let spacePaddingInlineWithIconTall = dimension5xs
+    public static let spacePaddingInlineWithIconShortest = dimension10xs
+    public static let spacePaddingInlineWithIconShorter = dimension9xs
+    public static let spacePaddingInlineWithIconShort = dimension8xs
     public static let spacePaddingInlineWithIconNone = dimensionNone
-    public static let spacePaddingInlineWithIconMedium = dimension8xs
+    public static let spacePaddingInlineWithIconMedium = dimension7xs
     public static let spacePaddingInlineWithArrowTallest = dimension3xs
-    public static let spacePaddingInlineWithArrowTaller = dimension5xs
-    public static let spacePaddingInlineWithArrowTall = dimension7xs
-    public static let spacePaddingInlineWithArrowShorter = dimension10xs
-    public static let spacePaddingInlineWithArrowShort = dimension9xs
+    public static let spacePaddingInlineWithArrowTaller = dimension4xs
+    public static let spacePaddingInlineWithArrowTall = dimension6xs
+    public static let spacePaddingInlineWithArrowShortest = dimension10xs
+    public static let spacePaddingInlineWithArrowShorter = dimension9xs
+    public static let spacePaddingInlineWithArrowShort = dimension8xs
     public static let spacePaddingInlineWithArrowNone = dimensionNone
-    public static let spacePaddingInlineWithArrowMedium = dimension8xs
-    public static let spacePaddingInlineTallest = dimensionMd
-    public static let spacePaddingInlineTaller = dimensionXs
+    public static let spacePaddingInlineWithArrowMedium = dimension7xs
+    public static let spacePaddingInlineTallest = dimensionXs
+    public static let spacePaddingInlineTaller = dimension2xs
     public static let spacePaddingInlineTall = dimension3xs
     public static let spacePaddingInlineShorter = dimension9xs
     public static let spacePaddingInlineShort = dimension7xs

Sorry, the parser is not yet able to handle transitivity (that's why there are values such as "dimension7xs", etc.). Here's the mapping table to help you understand the modifications based on what you have in the library:

public static let dimensionXs = dimension400
public static let dimensionXl = dimension600
public static let dimensionSm = dimension450
public static let dimensionNone = dimension0
public static let dimensionMd = dimension500
public static let dimensionLg = dimension550
public static let dimension9xs = dimension50
public static let dimension9xl = dimension1400
public static let dimension8xs = dimension75
public static let dimension8xl = dimension1200
public static let dimension7xs = dimension100
public static let dimension7xl = dimension1000
public static let dimension6xs = dimension150
public static let dimension6xl = dimension900
public static let dimension5xs = dimension200
public static let dimension5xl = dimension800
public static let dimension4xs = dimension250
public static let dimension4xl = dimension750
public static let dimension3xs = dimension300
public static let dimension3xl = dimension700
public static let dimension2xs = dimension350
public static let dimension2xl = dimension650
public static let dimension11xl = dimension1800
public static let dimension10xs = dimension25
public static let dimension10xl = dimension1600
@pylapp pylapp self-assigned this Oct 4, 2024
@pylapp pylapp changed the title Spacing (semantic) modifications after Figma updates (4th of October) [Token] Spacing (semantic) modifications after Figma updates (4th of October) Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants