Upgrade Opencast PHP Library to 1.8.0 + Api Version setting (OC 16 Support) + Moodle 4.4 Required Changes #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferishili
changed the title
ferishili
changed the title
|
Because this PR is being use in some new changes in block_opencast plugin, specifically for the sake of passing workflow configurations into the ingest api, therefore a new branch out of this PR has been created: https://github.com/Opencast-Moodle/moodle-tool_opencast/tree/oc-16-support |
|
I think we should hardcode the minimum required API version, as it should be a developer thing to decide which API version is needed if we want to support different feature sets based on a configuration to support several Opencast Versions; it should be a curated version List, maybe with just the Opencast Version as the API version only changes with major releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #62.
It consists of two part:
New settings:
Admins are now able to add the api version for each instance:
configuring it improves performance by eliminating an automated step by which the api version is extracted.
If not sure how to find it just use this link format to get is: [your opencast address]/docs.html?path=/api#getversiondefault-8
By leaving it empty, it does what it did like before!
Please note:
This PR also contains the required changes to Moodle 4.4, otherwise the Actions "CI"s won't work