Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI #16

Closed
4meta5 opened this issue Oct 4, 2024 · 3 comments
Closed

CI #16

4meta5 opened this issue Oct 4, 2024 · 3 comments
Assignees

Comments

@4meta5
Copy link
Collaborator

4meta5 commented Oct 4, 2024

Ideally CI would verify that the macros output valid Rust code. Compiling the crate itself is not as helpful because it does not tell us if the macro expansion is valid Rust.

Note that this ideal may first require #8 because most of our macro output isn't valid Rust until deps include all that are required.

@ggonzalez94
Copy link
Collaborator

@4meta5 we could add a step that expands the macros(but I think we will need tests or examples for this to be useful)

- name: Expand macros
      run: cargo expand 

Aditionally we could trybuild for testing
WDYT?

@ggonzalez94
Copy link
Collaborator

I created #18 since I wasn't sure what to add for verifying the macro itself, but if we are happy with this we can close the issues with #19

@ggonzalez94
Copy link
Collaborator

Marking this as closed in favor of #18. If we find things we need to add specific to macros we can come back and reopen this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants