Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ethers 5.7 dependency with @metamask/abi-utils and ethereum-cryptography #56

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Replace ethers 5.7 dependency with @metamask/abi-utils and ethereum-cryptography #56

wants to merge 9 commits into from

Conversation

Amxx
Copy link
Contributor

@Amxx Amxx commented Oct 9, 2024 •
edited
Loading

Fixes #55

@Amxx Amxx requested review from frangio and ernestognw October 9, 2024 15:20
frangio
frangio reviewed Oct 9, 2024
View reviewed changes
src/bytes.ts Outdated Show resolved Hide resolved
@frangio frangio mentioned this pull request Oct 9, 2024
Open
@frangio frangio changed the title Replace ethers 5.7 dependency with @metamask/utils and ethereum-cryptography Replace ethers 5.7 dependency with @metamask/abi-utils and ethereum-cryptography Nov 2, 2024
@frangio
Copy link
Contributor

frangio commented Nov 2, 2024

I've removed @metamask/utils, utilities and conversions are present in ethereum-cryptography already.

ernestognw
ernestognw approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we're having an issue with the coverage report. I don't have access to update the token but perhaps some of you do.

I'll create and IT request otherwise

@Amxx
Copy link
Contributor Author

Amxx commented Nov 18, 2024

I don't see any error. Did it resolve itself ?

@Amxx
Copy link
Contributor Author

Amxx commented Nov 18, 2024

Note: I understand that having a stronger HexString type that forces the 0x prefix may be breaking or too much. But I think its something that we should consider if we ever do a breaking changes to this library (probably never?)

@frangio
Copy link
Contributor

frangio commented Nov 18, 2024

Did it resolve itself ?

Yes I reran CI and it worked.

But I think its something that we should consider if we ever do a breaking changes to this library

I wouldn't be opposed to it, but I'm not convinced of its value.

@frangio
Copy link
Contributor

frangio commented Nov 18, 2024

Feel free to merge and release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio left review comments

@ernestognw ernestognw ernestognw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump @ethersproject/signing-key dependency from 5.7.0 to 6.x
3 participants
@Amxx @frangio @ernestognw