Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gamepad support #943

Open
QuaiGoner opened this issue Jan 25, 2022 · 20 comments
Open

Gamepad support #943

QuaiGoner opened this issue Jan 25, 2022 · 20 comments
Assignees
@Xottab-DUTY
Labels
Enhancement Gameplay Help wanted Player Experience UI

Comments

@QuaiGoner
Copy link

That feature already have some ground work, engine does register inputs, axis included, but when we try to bind controls it maps to a keyboard and does not maps axis.
Would be great to have propeg diput/xinput support in S.T.A.L.K.E.R. series before S.T.A.L.K.E.R. 2 comes out.
@Xottab-DUTY
Copy link
Member

Xottab-DUTY commented Jan 25, 2022 •
edited
Loading

It already maps axes in the latest dev builds :)
And you can even play with it. (but keyboard and mouse is still needed for inventory, dialogs, PDA)

@Xottab-DUTY
Copy link
Member

Xottab-DUTY commented Jan 25, 2022 •
edited
Loading

What is left to do:

  • Gamepad support for entire UI system. The most important.
  • Cursor behaviour:
    • Hide cursor if controller is being used
    • Show cursor anyway if mouse is being used in the middle of a controller gameplay
    • Hide it again if controller is being used again
  • Weapon selection wheel. (gamepad doesn't have much buttons, so we need something like this)
  • Double click support for key binding system #386
  • Aim assist.
  • Sticks sensitivity options, separate for X and Y axis.
  • Y axis invert options. (0e8e874)

@QuaiGoner
Copy link
Author

QuaiGoner commented Jan 25, 2022 •
edited
Loading

It already maps axes in the latest dev builds :) And you can even play with it. (but keyboard and mouse is still needed for inventory, dialogs, PDA)

Только что скачал с Appveyor крайний билд Gold - крашится при запуске новой игры и в меню геймпад не мапится (хотя мышка двигается правым стиком) - использую DS4 + DS4Windows, может быть я не тот билд взял?
OpenXRay_error_report_220125-131518.zip
Прикладываю лог после нажатия новой игры

@Xottab-DUTY
Copy link
Member

Xottab-DUTY commented Jan 25, 2022 •
edited
Loading

  1. Попробуй убрать папку versions из папки с игрой.
    Произошёл прикол. Игра, похоже, начала грузить файлы ТЧ из этой папки...
  2. Биндить геймпад можно только из отдельного окошка, которое добавляется геймдатой. Она есть в December 2020 Preview, а нерелизные билды идут без геймдаты. Ну, и, я более новую геймдату не выложил даже нигде ещё. (в декабрьском релизе старая, хотя она тоже подойдёт)
    Вот новая геймдата:
    gamedata.zip
    После распаковки, в меню управления появится кнопка переключения на настройки геймпада)

@QuaiGoner
Copy link
Author

QuaiGoner commented Jan 25, 2022 •
edited
Loading

Это я параллельно играюсь с version switcher, был интересно как оно работает)
Папку переименовал и добавил вашу геймдату.
Пару моментов:

  1. Имплементация левого стика - с шагом - бегом - быстрым бегом - просто гениально + сэкономлено столько кнопок
  2. Правый стик имеет дикую чувствительность - чувствительность мыши не влияет, возможно привязка к фпс ( у меня более 150)
  3. Для более-менее играбельного сотояния имхо было бы досточно навигации через D-pad в меню и инвентаре + кнопка для вызова контекстного меню в инвентаре на которое переключился бы фокус д-пада + та же история для диалогов - D-PAD + A&B
    В целом - моё почтение, очень круто получилось, спасибо за помощь

@Xottab-DUTY
Copy link
Member

References on weapon selector:
image
image

Xottab-DUTY added a commit that referenced this issue Feb 13, 2022
@Xottab-DUTY
Support gamepad gyroscope when aiming (#943)
663133a
@Xottab-DUTY
Copy link
Member

Useful articles:
http://blog.hypersect.com/interpreting-analog-sticks/
http://blog.hypersect.com/analog-to-digital-input-translation/

fgsfdsfgs pushed a commit to fgsfdsfgs/xray-16 that referenced this issue Feb 18, 2022
@Xottab-DUTY @fgsfdsfgs
Support gamepad gyroscope when aiming (OpenXRay#943)
7473205
@Xottab-DUTY Xottab-DUTY self-assigned this Mar 23, 2022
@banq007
Copy link

banq007 commented May 25, 2022

А получится ли aim-assist из уже какого-то готового проекта опенсурсного выдернуть, типа xash3d?

@QuaiGoner
Copy link
Author

Или билда одного. Но это скорее будет нарушением лицензии

@Xottab-DUTY
Copy link
Member

Xottab-DUTY commented Nov 8, 2022 •
edited
Loading

References on weapon selector: image image

Code references on wheel (pie) menu: ocornut/imgui#434

@Xottab-DUTY
Copy link
Member

Useful articles: http://blog.hypersect.com/interpreting-analog-sticks http://blog.hypersect.com/analog-to-digital-input-translation

Useful talk on designing input/controls in game:
https://www.youtube.com/watch?v=iHieM3u-lJ0

@Xottab-DUTY
Copy link
Member

References on weapon selector: image image

It's an interesting idea to make some cells in the wheel menu bigger, so they can fit big guns better

Xottab-DUTY added a commit that referenced this issue Aug 9, 2023
@Xottab-DUTY
Contextual input bindings
5f9ca4b 
Depending on the context (e.g. different UI windows) input mapping can be different.
This feature is needed for gamepads, because they have limited amount of buttons. (#943)
Xottab-DUTY added a commit that referenced this issue Aug 10, 2023
@Xottab-DUTY
Added initial support for gamepad and keyboard input for PDA window (#…
3063652 
…943)
Xottab-DUTY added a commit that referenced this issue Aug 10, 2023
@Xottab-DUTY
Initial support for gamepad and keyboard input for Talk window (#943)
30b97b1
Xottab-DUTY added a commit that referenced this issue Aug 11, 2023
@Xottab-DUTY
Added ability to open tasks list in the PDA using gamepad and keyboard (
8eedccb 
#943)

Added two UI actions stubs
@FaV0RiT77
Copy link

Trying to use third party software for gamepad support not working. Maybe it's conflicting with current implementation. Could you pinpoint me to a config or whatever where i can find and make the engine ignore gamepad for now?

@Xottab-DUTY
Copy link
Member

@FaV0RiT77, I just added -no_gamepad command line key for this. Nightly build with this key will be available within 1-2 hours.

@Xottab-DUTY Xottab-DUTY pinned this issue Nov 7, 2023
@Xottab-DUTY Xottab-DUTY moved this to To do in Roadmap Nov 15, 2023
@Xottab-DUTY Xottab-DUTY mentioned this issue Apr 23, 2024
Open
4 tasks
Xottab-DUTY added a commit that referenced this issue May 23, 2024
@Xottab-DUTY
UI Focus system WIP (#943)
6e3a069
@johndoe71rus
Copy link

need fix linux biuld after 6e3a069
xray-16_build_error.txt

@Xottab-DUTY
Copy link
Member

need fix linux biuld after 6e3a069 xray-16_build_error.txt

Fixed. Unfortunately, glibc or GCC itself is not conformant to C++ standard :(

@Atomlxe
Copy link

Atomlxe commented Oct 14, 2024

not sure if anyone else is getting this bug but for some reason the only things i can do on controller are aim down sights and shoot, no other controls work or are even registered in the gamepad setup menu

@Xottab-DUTY
Copy link
Member

not sure if anyone else is getting this bug but for some reason the only things i can do on controller are aim down sights and shoot, no other controls work or are even registered in the gamepad setup menu

What version of OpenXRay you are using?
Any messages about input/gamepad/controller in the log?

@Atomlxe
Copy link

Atomlxe commented Oct 14, 2024

not sure if anyone else is getting this bug but for some reason the only things i can do on controller are aim down sights and shoot, no other controls work or are even registered in the gamepad setup menu

What version of OpenXRay you are using? Any messages about input/gamepad/controller in the log?

forgot to edit the post but it seems to be an issue with my controller specifically as another one i tried works, although camera movement is very broken
im currently using the latest nightly version

@Atomlxe
Copy link

Atomlxe commented Oct 15, 2024

only issue im currently having is i cant move my camera on the Y axis, moving the right stick in a circle just moves my camera left or right depending on which direction i rotate the stick

Xottab-DUTY added a commit that referenced this issue Dec 20, 2024
@Xottab-DUTY
Remade cursor autohide mechanism (#943)
9e4a07d 
Now CUIDialogHolder is responsible for cursor visibility, it's the best
place for this purpose. Previously, the cursor was tracking itself.

For now, until other UI windows are adapted to change, the cursor will
be visible like in vanilla.
Xottab-DUTY added a commit that referenced this issue Dec 23, 2024
@Xottab-DUTY
Fix cursor disappearing after 9e4a07d (#943)
ca697e8 
Also restored cursor show/hide code in StartMenu/StopMenu that was removed.
It fits there.
Xottab-DUTY added a commit that referenced this issue Dec 23, 2024
@Xottab-DUTY
Basic cursor demand system implementation (#943)
a278e3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xottab-DUTY Xottab-DUTY

Labels
Enhancement Gameplay Help wanted Player Experience UI
Projects
Roadmap
Status: To do
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Xottab-DUTY @johndoe71rus @QuaiGoner @banq007 @Atomlxe @FaV0RiT77