Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gen-req overwrites an existing request without confirmation #1178

Closed
TinCanTech opened this issue Jun 26, 2024 · 0 comments · Fixed by #1177
Closed

gen-req overwrites an existing request without confirmation #1178

TinCanTech opened this issue Jun 26, 2024 · 0 comments · Fixed by #1177
Assignees
Labels
Milestone

Comments

@TinCanTech
Copy link
Collaborator

gen-req only checks for an existing key file.

This means that when a request is received without a key file, it is entirely possible to destroy the request accidentally. By generating another request, in the same name, the original request, tied to the correct private key, will be overwritten and will require a new private key to be distributed.

This bug has existed since at least v3.0.8, time to fix it.

@TinCanTech TinCanTech self-assigned this Jun 26, 2024
@TinCanTech TinCanTech added the BUG label Jun 26, 2024
@TinCanTech TinCanTech added this to the v3.2.1 milestone Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant