Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saving the modified user doc for Role Elevation from User to Author should propogate the change in role across active sessions #1109

Open
Martii opened this issue May 10, 2017 · 0 comments
Open

Saving the modified user doc for Role Elevation from User to Author should propogate the change in role across active sessions #1109

Martii opened this issue May 10, 2017 · 0 comments
Labels
bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment.

Comments

@Martii
Copy link
Member

Martii commented May 10, 2017 •
edited
Loading

As per @sizzlemctwizzle comment from #1107 (comment) and #1107 (comment) :

... call the update method of libs/modifySessions.js to make sure the change is propagated in the session store.

This is followup for the perceived missing logic in that code section that was not there before the PR of #1108

NOTES:

  • Missing aReq object to call existing modifySessions.update e.g. not in top level function signature.
  • RepoManager.loadScripts doesn't currently have aReq with a user in it on import scripts from GH (e.g. webhook won't be able to elevate using current modifySessions.update)
@Martii Martii added bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. sooner Sooner would be appreciated. labels May 10, 2017
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue May 17, 2017
Use static nums for role elevation check
646d80f 
* I never have liked this test and mathematial calc... it's just asking for a security breach if there is an error somewhere else
* Set to static numbers... we have static numbers all over the place so continue to use these

Applies to OpenUserJS#1109 and OpenUserJS#1107
@Martii Martii mentioned this issue May 17, 2017
Merged
Martii added a commit that referenced this issue May 17, 2017
@Martii
Use static nums for role elevation check (#1137)
1562c6f 
* I never have liked this test and mathematical calc... it's just asking for a security breach if there is an error somewhere else
* Set to static numbers... we have static numbers all over the place so continue to use these

Applies to #1109 and #1107

Auto-merge
@Martii Martii removed the sooner Sooner would be appreciated. label May 18, 2017
Martii added a commit to Martii/OpenUserJS.org that referenced this issue Oct 23, 2020
@Martii
Save role weight in flag model
e908b4e 
* When promoting/demoting a User future flagging/unflagging can wreak havoc on critical *(relative)* flags properties.
* Project bump since requires a bit of migration
* Needs followup testing with OpenUserJS#1109

Applies to OpenUserJS#126 and post OpenUserJS#641
@Martii Martii mentioned this issue Oct 23, 2020
Merged
Martii added a commit that referenced this issue Oct 23, 2020
@Martii
Save role weight in flag model (#1772)
76b018e 
* When promoting/demoting a User future flagging/unflagging can wreak havoc on critical *(relative)* flags properties.
* Project bump since requires a bit of migration
* Needs followup testing with #1109

Applies to #126 and post #641

Auto-merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment.
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Martii