Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to update the update-browserslist-db #167

Open
fabianospinelli opened this issue May 14, 2024 · 3 comments
Open

Request to update the update-browserslist-db #167

fabianospinelli opened this issue May 14, 2024 · 3 comments

Comments

@fabianospinelli
Copy link
Contributor

After installing Contribution-Tool, when I run it I obtain in the screen messages the need to update the update-browserslist-db.
So, I executed the command "npx update-browserslist-db@latest" (and I inserted it in the Dockerfile because I use Contribution-Tool in a docker container) and everything works fine. Is it right what I done or there is another way to resolve this update message?
Thanks!

@clementbiron
Copy link
Member

Hello Fabiano,

A pull request should be opened to update autoprefixer because browserslist is a dependency of it. This will resolve the update message.

@clementbiron
Copy link
Member

Sorry Fabiano, I was a bit hasty and closed the issue without giving you a chance to reply.

Your question is a good one, and you were right to open up a issue. What you've done will temporarily update the Browsertlist database, but it's not the best way to do it. As I said in the previous comment, you need to update autoprefixer because it's this package which itself has a browserslist dependency. This should be done in a pull request, making sure that updating these packages by running npm update autoprefixer has no implications for the UI components.

Can you take care of it?

I'll leave it to you to close this issue if my answer is satisfactory ;)

@clementbiron clementbiron reopened this May 16, 2024
@fabianospinelli
Copy link
Contributor Author

Thanks Clement! Currently I'm working on other 2 contributions to the code, i.e. to add the GitLab support to the CT and the engine. I plan to finish testing and do the first PR already today. I could be able to work on this at a later stage. In the meantime I will try it modifying the Dockerfile, removing the "npx update-browserslist-db@latest" and adding the command you suggested me. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants