Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR tests #77

Open
gonX opened this issue Nov 30, 2023 · 3 comments
Open

Add PR tests #77

gonX opened this issue Nov 30, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@gonX
Copy link
Member

gonX commented Nov 30, 2023

Some ideas:

JSON Key Check
Name ^.{2,}$ (2 characters or more)
Description same as Name
Owner ^[^\s]+$
SupportedDriverVersion Must be lower than newest release, and have all 4 version subvalues (e.g. 0.6.4.0, not 0.6.4)
PluginVersion ^\d+(\.\d+){1,2}$ or less strict
*Url must be curl'able (or similar)
CompressionFormat Whatever we support, zip only for now? Can skip this check
LicenseIdentifier Ideally, something from a predermined list, but otherwise same check as Owner

Already covered in tests:

  • SHA256
  • DownloadUrl
@gonX
Copy link
Member Author

gonX commented Nov 30, 2023

Oops, we already have some tests:
https://github.com/OpenTabletDriver/Plugin-Repository/blob/acc79dccf8325459e2e3f6b2be8bd4c197c222ed/validate.sh

Looks like SHA256 (and DownloadUrl) are the only ones getting tested there, as well as checking whether the file is parseable at all.

@InfinityGhost InfinityGhost added the enhancement New feature or request label Mar 11, 2024
@gonX
Copy link
Member Author

gonX commented Mar 18, 2024

Updated OP to address issues fixed in #89

@gonX
Copy link
Member Author

gonX commented Mar 18, 2024

Also need to test for path as seen in #90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants