Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobuf splitting to reduce size of what is accessed at runtime #1141

Open
bsstephan opened this issue Sep 17, 2024 · 1 comment
Open

Protobuf splitting to reduce size of what is accessed at runtime #1141

bsstephan opened this issue Sep 17, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@bsstephan
Copy link
Contributor

From @arntsonl in #1123:

Memory size is getting pretty big, I think its a good time to think about board settings vs user settings protobuf packages. We're at the point where calling protobuf breaks our core1 usb code, so we might want to think deeper on how to break up those two components.

So user settings MUST be under a certain size to ensure we don't break usb host, and board settings can be some big size.

My intuition is that the whole config is a "user config" in that it can be changed by the user, so rather than board vs. user, an alternative way to think about this is firmware initialization config (can be loaded at boot, isn't changed at runtime (instead only changed via webconfig)) vs. runtime config (changes at runtime, e.g. profile number, LS/DP/RS, etc.).

@bsstephan bsstephan added the enhancement New feature or request label Sep 17, 2024
@arntsonl
Copy link
Contributor

Totally agreed on naming:

Boot Config (During Initialization) - huge size limit
Run-Time Config (Changed at Run-Time) - very small, doesn't disconnect usb host on save hopefully

We will have to play with how small/lage protobuf can be before it has an impact on core1 PIOs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants