fix: review changes

Signed-off-by: romanetar <[email protected]>

Author: romanetar

app/Jobs/Emails/Registration/PromoCodes/SponsorPromoCodeEmail.php

@@ -54,12 +54,7 @@ public function __construct
         $summit = $promo_code->getSummit();
         $payload = [];
         $sponsor = $promo_code->getSponsor();
-        $sponsorships = $sponsor->getSponsorships();
-        $sponsor_tier_names = [];
-        foreach ($sponsorships as $sponsorship) {
-            $sponsor_tier_names[] = $sponsorship->getType()->getType()->getName();
-        }
-        $payload[IMailTemplatesConstants::sponsor_tier_name] = implode(',', $sponsor_tier_names);
+        $payload[IMailTemplatesConstants::sponsor_tier_name] = implode(',', $sponsor->getSponsorshipTierNames());
         $payload[IMailTemplatesConstants::promo_code] = $promo_code->getCode();
         $payload[IMailTemplatesConstants::company_name] = '';
         $company = $sponsor->getCompany();

app/ModelSerializers/SerializerRegistry.php

@@ -115,6 +115,7 @@
 use App\ModelSerializers\Summit\SummitScheduleConfigSerializer;
 use App\ModelSerializers\Summit\SummitSchedulePreFilterElementConfigSerializer;
 use App\ModelSerializers\Summit\SummitSignSerializer;
+use App\ModelSerializers\Summit\SummitSponsorshipSerializer;
 use App\ModelSerializers\Summit\SummitSponsorshipTypeSerializer;
 use App\ModelSerializers\Summit\TrackTagGroups\TrackTagGroupAllowedTagSerializer;
 use App\ModelSerializers\Summit\TrackTagGroups\TrackTagGroupSerializer;
@@ -566,6 +567,7 @@ private function __construct()
         // summit sponsors
 
         $this->registry['SponsorshipType'] = SponsorshipTypeSerializer::class;
+        $this->registry['SummitSponsorship'] = SummitSponsorshipSerializer::class;
         $this->registry['SummitSponsorshipType'] = SummitSponsorshipTypeSerializer::class;
         $this->registry['Sponsor'] = SponsorSerializer::class;
         $this->registry['SponsorAd'] = SponsorAdSerializer::class;

app/ModelSerializers/Summit/SponsorSerializer.php

@@ -83,7 +83,7 @@ public function serialize($expand = null, array $fields = [], array $relations =
         if (in_array('sponsorships', $relations)) {
             $sponsorships = [];
             foreach ($sponsor->getSponsorships() as $sponsorship) {
-                $sponsorships[] = $sponsorship->getType()->getId();
+                $sponsorships[] = $sponsorship->getId();
             }
             $values['sponsorships'] = $sponsorships;
         }
@@ -178,7 +178,7 @@ public function serialize($expand = null, array $fields = [], array $relations =
                                 unset($values['sponsorships']);
                                 $sponsorship_types = [];
                                 foreach ($sponsorships as $sponsorship) {
-                                    $sponsorship_types[] = SerializerRegistry::getInstance()->getSerializer($sponsorship->getType())->serialize
+                                    $sponsorship_types[] = SerializerRegistry::getInstance()->getSerializer($sponsorship)->serialize
                                     (
                                         AbstractSerializer::filterExpandByPrefix($expand, $relation),
                                         AbstractSerializer::filterFieldsByPrefix($fields, $relation),

app/ModelSerializers/Summit/SummitSponsorshipSerializer.php

@@ -0,0 +1,43 @@
+<?php namespace App\ModelSerializers\Summit;
+use Libs\ModelSerializers\Many2OneExpandSerializer;
+use Libs\ModelSerializers\One2ManyExpandSerializer;
+use ModelSerializers\SilverStripeSerializer;
+
+/**
+ * Copyright 2025 OpenStack Foundation
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ **/
+
+/**
+ * Class SummitSponsorshipSerializer
+ * @package ModelSerializers
+ */
+final class SummitSponsorshipSerializer extends SilverStripeSerializer
+{
+    protected static $array_mappings = [
+        'Id' => 'id:json_int',
+        'SponsorID' => 'sponsor_id:json_int',
+        'TypeID' => 'type_id:json_int'
+    ];
+
+    protected static $expand_mappings = [
+        'add_ons' => [
+            'type' => Many2OneExpandSerializer::class,
+            'getter' => 'getAddOns',
+        ],
+        'type' => [
+            'type' => One2ManyExpandSerializer::class,
+            'original_attribute' => 'type_id',
+            'getter' => 'getType',
+            'has' => 'hasType'
+        ],
+    ];
+}

app/Models/Foundation/Summit/Factories/SponsorFactory.php

@@ -32,7 +32,6 @@ public static function build(array $data):Sponsor{
      * @param Sponsor $sponsor
      * @param array $data
      * @return Sponsor
-     * @throws ValidationException
      */
     public static function populate(Sponsor $sponsor, array $data):Sponsor{
 

app/Models/Foundation/Summit/Sponsor.php

@@ -976,4 +976,12 @@ public function clearSponsorships(): void
         $this->sponsorships->clear();
         $this->sponsorships = null;
     }
+
+    /**
+     * @return array
+     */
+    public function getSponsorshipTierNames(): array
+    {
+        return array_map(fn($sponsorship) => $sponsorship->getType()->getType()->getName(), $this->sponsorships);
+    }
 }

app/Models/Foundation/Summit/SummitSponsorship.php

@@ -27,6 +27,14 @@ class SummitSponsorship extends SilverstripeBaseModel
 {
     use One2ManyPropertyTrait;
 
+    protected $getIdMappings = [
+        'getTypeId' => 'type',
+    ];
+
+    protected $hasPropertyMappings = [
+        'hasType' => 'type',
+    ];
+
     /**
      * @var Sponsor
      */