Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ToTabPane on Pyramid create lots of child elements #208

Open
LANDAISB opened this issue Sep 25, 2024 · 2 comments
Open

Adding ToTabPane on Pyramid create lots of child elements #208

LANDAISB opened this issue Sep 25, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@LANDAISB
Copy link

I try to add a ToTabPane on Pyramid.

Maybe two probelms :

  1. It creates a ToTabPane with a body (ToPane) and a header (ToTabPaneHeader). The header contains 3 childs ToPane and one of them contains also 3 childs (ToElement and ToPane).
    It seems it's a lot of childs/subchilds, is it normal ?

  2. If I save and re-open Pyramid, it duplicates all childs under each ToTabPane

toTabPanePyramid

@LANDAISB LANDAISB added the bug Something isn't working label Sep 25, 2024
@Nyan11
Copy link
Collaborator

Nyan11 commented Sep 27, 2024

The bug is present because the ToTabPane is a subclass of ToPane, and in Toplo-Serialization i decided to serialize the children of ToPane.

But it does not make sense to serialize the children of ToTabPane, we should only serialize the "tabs" and not the children

@Nyan11
Copy link
Collaborator

Nyan11 commented Sep 27, 2024

I fix the serialization, it should not recreate the elements infinitly.
But ToTabPane uses BlockClosure and it is complicated to serialized BlockClosure.

Currently the ToTabPane will try to serialize the ToTab.
I can deactivate this functionnality if needed

@labordep labordep modified the milestone: alpha 6 Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants