Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded dependencies #40

Open
mojoaxel opened this issue Apr 15, 2016 · 3 comments
Open

Remove unneeded dependencies #40

mojoaxel opened this issue Apr 15, 2016 · 3 comments
Milestone

Comments

@mojoaxel
Copy link
Collaborator

The app is already quite big. We should try removing unnecessary dependencies.

@mojoaxel mojoaxel added this to the v1.0 milestone Apr 15, 2016
@mojoaxel
Copy link
Collaborator Author

mojoaxel commented Apr 15, 2016

I think we could get rid of the following (big) dependencies:

  • jquery
  • react-boostrap

@aAXEe
Copy link
Collaborator

aAXEe commented Oct 15, 2016

The webpack js bundle was > 5 MB.
ddc4aad fixes the include of all icons instead the needed ones. The bundle size is now about 2 MB.

$ webpack-bundle-size-analyzer debug/webpack.json 
openlayers: 2.61 MB (50.8%)
react: 620.28 KB (11.8%)
lodash: 522.36 KB (9.95%)
react-bootstrap: 381.1 KB (7.26%)
jquery: 260.93 KB (4.97%)
intl: 192.53 KB (3.67%)
react-overlays: 68.45 KB (1.30%)
react-intl: 60.63 KB (1.16%)
babel-runtime: 45.11 KB (0.859%)
  core-js: 40.78 KB (90.4%)
  <self>: 4.33 KB (9.59%)
intl-messageformat-parser: 36.82 KB (0.701%)
fbjs: 31.13 KB (0.593%)
redux: 23.33 KB (0.444%)
  symbol-observable: 996 B (4.17%)
  <self>: 22.36 KB (95.8%)
react-redux: 19.37 KB (0.369%)
react-icons: 17.43 KB (0.332%)
intl-messageformat: 17.18 KB (0.327%)
dom-helpers: 15.56 KB (0.296%)
intl-relativeformat: 14.66 KB (0.279%)
uncontrollable: 9.57 KB (0.182%)
react-toggle: 7.16 KB (0.136%)
style-loader: 6.99 KB (0.133%)
rc-progress: 6.72 KB (0.128%)
react-prop-types: 6.04 KB (0.115%)
uniloc: 5.67 KB (0.108%)
process: 4.4 KB (0.0839%)
intl-format-cache: 3.99 KB (0.0759%)
keycode: 2.7 KB (0.0513%)
object-assign: 1.95 KB (0.0371%)
react-icon-base: 1.84 KB (0.0351%)
warning: 1.76 KB (0.0336%)
invariant: 1.48 KB (0.0282%)
css-loader: 1.47 KB (0.0280%)
hoist-non-react-statics: 1.35 KB (0.0258%)
classnames: 1.08 KB (0.0205%)
repo-path-parse: 821 B (0.0153%)
parse-author: 499 B (0.00928%)
parse-authors: 438 B (0.00815%)
intl-messageformat/lib/main.js|/home/axel/OpenSeaMap/map-nextGen2: 288 B (0.00536%)
  intl-relativeformat: 288 B (100%)
  <self>: 0 B (0.00%)
author-regex: 279 B (0.00519%)
webpack: 251 B (0.00467%)
global: 243 B (0.00452%)
screen-size: 187 B (0.00348%)
react-addons-pure-render-mixin: 72 B (0.00134%)
react-dom: 63 B (0.00117%)
intl-messageformat .: 15 B (0.000279%)
intl-relativeformat .: 15 B (0.000279%)
intl .: 15 B (0.000279%)
<self>: 187.73 KB (3.58%)

@aAXEe
Copy link
Collaborator

aAXEe commented Nov 11, 2016

After using the release build for openlayers for the production build (b6e708c):

webpack-bundle-size-analyzer debug/webpack.json 
react: 620.28 KB (20.5%)
lodash: 530.17 KB (17.5%)
openlayers: 460.65 KB (15.2%)
react-bootstrap: 384.76 KB (12.7%)
jquery: 260.93 KB (8.62%)
react-intl: 69.24 KB (2.29%)
react-overlays: 67.29 KB (2.22%)
babel-runtime: 45.19 KB (1.49%)
  core-js: 40.78 KB (90.3%)
  <self>: 4.4 KB (9.74%)
intl-messageformat-parser: 36.82 KB (1.22%)
fbjs: 31.21 KB (1.03%)
intl: 23.48 KB (0.776%)
react-icons: 23.26 KB (0.769%)
redux: 22.36 KB (0.739%)
react-redux: 19.37 KB (0.640%)
intl-messageformat: 17.18 KB (0.568%)
dom-helpers: 15.56 KB (0.514%)
intl-relativeformat: 14.66 KB (0.485%)
uncontrollable: 9.57 KB (0.316%)
rc-progress: 7.37 KB (0.244%)
react-toggle: 7.16 KB (0.236%)
style-loader: 6.99 KB (0.231%)
react-prop-types: 6.04 KB (0.200%)
uniloc: 5.67 KB (0.187%)
process: 5.17 KB (0.171%)
intl-format-cache: 3.99 KB (0.132%)
keycode: 2.7 KB (0.0891%)
object-assign: 1.95 KB (0.0643%)
react-icon-base: 1.84 KB (0.0608%)
warning: 1.76 KB (0.0583%)
invariant: 1.48 KB (0.0489%)
css-loader: 1.47 KB (0.0486%)
hoist-non-react-statics: 1.35 KB (0.0448%)
symbol-observable: 1.12 KB (0.0371%)
classnames: 1.08 KB (0.0356%)
repo-path-parse: 821 B (0.0265%)
parse-author: 499 B (0.0161%)
parse-authors: 438 B (0.0141%)
intl-messageformat/lib/main.js|/home/axel/OpenSeaMap/map-nextGen2: 288 B (0.00929%)
  intl-relativeformat: 288 B (100%)
  <self>: 0 B (0.00%)
author-regex: 279 B (0.00900%)
global: 243 B (0.00784%)
webpack: 241 B (0.00778%)
screen-size: 187 B (0.00603%)
react-addons-pure-render-mixin: 72 B (0.00232%)
react-dom: 63 B (0.00203%)
intl-relativeformat .: 15 B (0.000484%)
intl-messageformat .: 15 B (0.000484%)
<self>: 313.84 KB (10.4%)
Starting 'size-report'...
┌───────────────────────────────────────┬───────────┬───────────┐
│ File                                  │  Original │   Gzipped │
├───────────────────────────────────────┼───────────┼───────────┤
│ rev-manifest.json                     │     197 B │     145 B │
├───────────────────────────────────────┼───────────┼───────────┤
│ images/OpenSeaMap-Logo-0491e29e46.svg │   6.61 kB │   2.66 kB │
├───────────────────────────────────────┼───────────┼───────────┤
│ javascripts/app-f7bf2aeb23.js         │   1.43 MB │ 371.85 kB │
├───────────────────────────────────────┼───────────┼───────────┤
│ stylesheets/global-425948a9cb.css     │ 116.76 kB │  20.29 kB │
├───────────────────────────────────────┼───────────┼───────────┤
│                                       │   1.55 MB │ 394.95 kB │
└───────────────────────────────────────┴───────────┴───────────┘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants