Skip to content
This repository has been archived by the owner on Jan 3, 2023. It is now read-only.

Remove obsolete cve_scanner package #93

Open
mpreisler opened this issue Aug 10, 2016 · 7 comments
Open

Remove obsolete cve_scanner package #93

mpreisler opened this issue Aug 10, 2016 · 7 comments
Assignees
Milestone

Comments

@mpreisler
Copy link
Member

CVE scanning is now done as a task, the cve_scanner package is of no use. Let's remove it so that we don't have to maintain it any more.

@mpreisler mpreisler added this to the 0.2.0 milestone Aug 10, 2016
@jan-cerny
Copy link
Member

jan-cerny commented Sep 6, 2018

I don't think we can remove it, because oscapd-cli scan uses cli_scan which uses CVEScanListAsync which uses Worker which is defined in cve_scanner package.
@dahaic @mpreisler @matejak @yuumasato @Mildass @matusmarhefka Do we want to drop this functionality from oscapd-cli?

@matusmarhefka
Copy link
Member

@jan-cerny Is atomic scan using oscapd-cli in any way? I think it uses oscapd-evaluate.

@dahaic
Copy link
Member

dahaic commented Sep 6, 2018

@matusmarhefka atomic scan is just using daemon. Let's look at this problem from the perspective of daemon, not of one particular use case.

@jan-cerny I would suggest to preserve the functionality.

@jan-cerny
Copy link
Member

@matusmarhefka I think it isn't using oscapd-cli. I think you're right that it uses oscapd-evaluate.

@jan-cerny
Copy link
Member

@dahaic I agree that we should preserve the functionality.

@jan-cerny
Copy link
Member

Do you think we should rework the code to avoid using the cve_scanner package?

@mpreisler
Copy link
Member Author

the cli_scan stuff is virtually unused, it was replaced with oscapd-evaluate and the task API VulnerabilityScan mode. We can remove cli_scan IMO, it's obsolete anyway.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants