Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate thumbnail previews during the Wikimedia Commons batch file upload process #34

Closed
trnstlntk opened this issue Nov 7, 2021 · 13 comments
Assignees
Labels
UI Creation or improvement of UI elements wikicommons

Comments

@trnstlntk
Copy link
Contributor

trnstlntk commented Nov 7, 2021

See https://commons.wikimedia.org/wiki/Commons_talk:OpenRefine

Request received in a conversation in the Wikimedia Commons Telegram channel. During a batch upload process of media files, it is extremely helpful if one can (easily) see thumbnail previews of the media files that are being uploaded.

Some existing Wikimedia Commons (batch) upload tools support this indeed (the default UploadWizard, for instance), others don't (Pattypan only shows previews of files and their infoboxes during the checking phase of the upload process, after all data has been prepared already).

OpenRefine is essentially a data-centric tool, so this may be a stretch, but it's good to have this request on the radar, as it makes a lot of sense IMO.

@thadguidry
Copy link
Member

The extension can and should be developed to support what users need irregardless of OpenRefine. That's the beauty of an extension. Extending in ways the original program had no need for.

@wetneb
Copy link
Member

wetneb commented Apr 29, 2022

@trnstlntk, @lozanaross and I have discussed this during a training workshop with users from cultural institutions, and one attendee asked if the feature could be available for projects that are unrelated to Wikimedia Commons.

The issue could indeed be formulated like this: say I have a dataset where one column contains local paths to images, I would like to have OpenRefine display small thumbnails of those images in the corresponding cells.

Given that we currently do not have any extension point which would let extensions customize cell rendering (as far as I can tell), it seems that we have two reasons to implement this in the core directly. I think this could go in some sort of view options of a given column, potentially?

@wetneb wetneb added the UI Creation or improvement of UI elements label Apr 29, 2022
@trnstlntk
Copy link
Contributor Author

@lozanaross has created various wireframes that include file previews. A selection from the latest (April 26) version of the wireframes:

While working on a project:
image

We're also considering a functionality to make the thumbnail bigger here, especially useful when the user will be working with many similar media files that they want to compare:
image
image

During upload (schema) preview:
image

@trnstlntk
Copy link
Contributor Author

Assigning this task to @lozanaross (design; work in progress) and @j-sal (development of this feature). I didn't see an explicit deadline attached during the roadmapping exercise we did last week, but we placed this task around July so I'm provisionally adding a July 31 deadline.

@trnstlntk
Copy link
Contributor Author

trnstlntk commented Apr 30, 2022

@trnstlntk, @lozanaross and I have discussed this during a training workshop with users from cultural institutions, and one attendee asked if the feature could be available for projects that are unrelated to Wikimedia Commons.

The issue could indeed be formulated like this: say I have a dataset where one column contains local paths to images, I would like to have OpenRefine display small thumbnails of those images in the corresponding cells.

Given that we currently do not have any extension point which would let extensions customize cell rendering (as far as I can tell), it seems that we have two reasons to implement this in the core directly. I think this could go in some sort of view options of a given column, potentially?

I'll be happy to edit this issue to reflect the broader scope. We could also split it in separate tasks?

For Wikimedia Commons, we identified distinct use cases that will need (as I understood it) different development approaches:

  • User wants to use OpenRefine to add structured data to existing files from Wikimedia Commons. They load a series of file paths from Wikimedia Commons and then display thumbnails of these in OpenRefine. This can build further upon the work by @eugeneegbe on the Commons Reconciliation Service. (This is the first use case we want to tackle; deadline July 31)
  • User wants to use OpenRefine to upload new files to Wikimedia Commons, from harddrive. They select a set of files from their harddrive. We need to develop a way to display thumbnails for these in OpenRefine.
  • User wants to use OpenRefine to upload new files to Wikimedia Commons, from the web. They select a set of URLs (or start a project from API, or similar). We need to develop a way to display thumbnails for these in OpenRefine.

For the second and third scenario: we placed work on this task around September 2022 in our roadmap. Due to time constraints perhaps we won't get there during the current grant.

@wetneb
Copy link
Member

wetneb commented Apr 30, 2022

Yes we could potentially have three separate issues I think.

@lozanaross
Copy link

I think we discussed this and indeed we need separate issues, I'll set the others up - I think we also agreed the deadline for this first case (Commons images) is July 01 because we want it for wikimania?

@lozanaross
Copy link

The way the issue is framed at the moment makes me think it belongs in the extension repo, not in the main repo btw. I think it needs to be abstracted and possibly created later (after this issue is closed) in the main OpenRefine repo.

@trnstlntk
Copy link
Contributor Author

I think we discussed this and indeed we need separate issues, I'll set the others up - I think we also agreed the deadline for this first case (Commons images) is July 01 because we want it for wikimania?

We didn't put a deadline on that specific post it note 😅 but we indeed placed it right before Wikimania, so I'd say yes.

@lozanaross
Copy link

The way the issue is framed at the moment makes me think it belongs in the extension repo, not in the main repo btw. I think it needs to be abstracted and possibly created later (after this issue is closed) in the main OpenRefine repo.

Replying to myself - this is a dumb comment because I realize you cannot move issues across repos in Github (unless I am just not seeing how?? it is possible in Gitlab). I guess we should keep this here for now, but it's technically part of the SDC extension because we're first developing the thumbs for commons only, right? Then later the options to render local / remote files?

@wetneb
Copy link
Member

wetneb commented May 3, 2022

I realize you cannot move issues across repos in Github

Yes you can, it is called "Transfer issue" on the right-hand side, and as a member of the organization it should be available to you.

@lozanaross lozanaross transferred this issue from OpenRefine/OpenRefine May 3, 2022
@lozanaross
Copy link

Wow, learning new things every day :-) Just transferred it. I hope that's ok!

@trnstlntk
Copy link
Contributor Author

Separate issues for the three scenarios:

As we now have these separate issues, I will close this one.

Repository owner moved this from WMF grant - in progress to SDC (WMF) grant 2021-22 - done in Structured Data on Commons Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI Creation or improvement of UI elements wikicommons
Projects
Status: SDC (WMF) grant 2021-22 - done
Development

No branches or pull requests

5 participants