Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move osrd-ui into main osrd repository #451

Open
emersion opened this issue Sep 10, 2024 · 0 comments
Open

Move osrd-ui into main osrd repository #451

emersion opened this issue Sep 10, 2024 · 0 comments
Assignees

Comments

@emersion
Copy link
Member

emersion commented Sep 10, 2024

Description and goal

A pain point when working on osrd-ui is that it's tricky to work on osrd-ui and test the changes in OSRD in a real-world scenario instead of a storybook. Additionally, osrd-ui changes are costly: each time we want to update osrd-ui (e.g. for a bugfix or small enhancement) we need to create a new osrd-ui release and then bump the osrd-ui dependency in OSRD's package.json.

We could move osrd-ui into a subdirectory of the main OSRD repository. osrd-ui's NPM packages would continue to work as usual. OSRD's front could pull osrd-ui from a local directory instead of the NPM registry.

Possible roadblocks:

  • How do we integrate osrd-ui's multi-package/lerna setup into OSRD's front build process ?
  • Do we want to retain git history? (It's possible)
  • yarn vs npm?
  • Release process? Right now we use git tags, GitHub releases and a GitHub actions workflow.

Acceptance criteria

.

@emersion emersion self-assigned this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant