-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added soviet ballistic missiles #702
Conversation
gonna test this one: -) |
OK, in terms of basic functionality and damage values it looks ok.
Lastly og RA2 dreadnought behaviour was to wait for the 2 missiles to be reloaded to launch. This can be a gameplay functionality (less wait time but less overall damage in current behaviour). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment above, but they're mostly cosmetics.
Only major change is maybe, making dreadnought wait for the 2 missiles to launch, or not
eea29b0
to
9db9ad2
Compare
Added the launch sounds and improved the Dreadnought firing all missiles at once. The launch animation which tilts the missile and the steeper pitch need an engine update or rather several. |
How so? What is needed on engine to make that work, so we can build a issue? |
Something like OpenRA/OpenRA#17796. |
Added the v3 launch animation. |
9c4a2ec
to
e95f0e1
Compare
Checked now:
Noticed one other thing, in OG ra2 Tanya and other commandos that use C4 could use them to destroy Dreadnoughts in one go (In fact the first allied mission used that to bump Tanya to elite status). At the moment she attacks normally, not using the C4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to have demolishable by C4 in dreadnought
Is it just me or do those missiles fly a lot faster than original. |
Added C4 demolition to all ships. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It shouldn't be in a general rule, only Big ships are C4 targetable (Dreadnought, aircraft carrier and in Yuri's revenge Boomer). Although in normal cases normally it is forgotten.
da45001
to
32b1f6e
Compare
Fixed. |
It looks good to me. When a C4 unit targets Dreadnought or Aircraft carrier, the cursor changes to C4 cursor and after 1 second the units is destroyed. |
32b1f6e
to
3c8f25e
Compare
Added acceleration to the missiles and fixed the Dreadnought not facing the targets. |
The following exception occurred when testing the dreadnought. OpenRA engine version release-20200202 I think it was when the missiles were launched and it was still visible, but then the kirov that was giving vision died, and no more vision when launching. Video when crash occured: |
I already fixed it in OpenRA/OpenRA#17965. The engine here is outdated. |
Can you update the engine in the pull request? |
No. |
This branch needs to be rebased and conflicts resolved |
3c8f25e
to
b547618
Compare
Rebased. |
This could use a rebase too, it is still on previous engine version. And the balistic missile code in RV has been updated since to include proper take off which seems to be missing here. The ones on the custom engine, old code is still kept on RV's SDK level dll for easter egg unit that still catapults the missile. This could also include Vladimir's Dreadnought campaign unit, while you are in it. |
The rebase is quite huge and I don't have proper IDE support for legacy .NET so I am closing this. |
Closes #118
Closes #696