Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Installer Generation can fail, if mod uses a different version naming scheme than usual. #195

Open
MustaphaTR opened this issue Nov 4, 2023 · 0 comments

Comments

@MustaphaTR
Copy link
Member

https://github.com/OpenRA/OpenRAModSDK/blob/master/packaging/windows/buildpackage.sh#L113 seems to switch around the parts of version name before and after the dash, iirc that's because version numbers here needs to start with a number.

My D2k mod do not use the date based version numbering, but a more standard one but starting with a v. So upcoming release would be v2.2, which the code above do not modify and cause an error for not starting with a number. https://github.com/MustaphaTR/MustaphaTR-s-D2K-Mod/actions/runs/6753957395/job/18360972248

While it is kinda my fault not using the date version and i can edit buildpackage.sh locally (i don't want to change versioning scheme at this point), i feel like SDK should be more customisable with this. Perhaps the backwards version should be manually defined somewhere else? Mod.config?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant