Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YAML or JSON to replace hard-coding PIVSettings in windef #293

Open
alexlib opened this issue Mar 14, 2023 · 0 comments
Open

YAML or JSON to replace hard-coding PIVSettings in windef #293

alexlib opened this issue Mar 14, 2023 · 0 comments
Labels
extension good first issue Good issue to start when you want to learn how to contribute to this open source project

Comments

@alexlib
Copy link
Member

alexlib commented Mar 14, 2023

Is your feature request related to a problem? Please describe.
The problem is a set of default PIVSettings which is not transparent to the user. It has to be coded everytime before running windef.piv function and it can lead to problems with the set of parameters.

Describe the solution you'd like
Create a default config file in YAML or JSON that will be clear what's used in windef.piv and be stored next to the results - so every run will also have a logbook of the session used. Similar to the TK GUI configuration files.

Describe alternatives you've considered
See pull request @PR

Additional context
#177
@alexlib alexlib added good first issue Good issue to start when you want to learn how to contribute to this open source project extension labels Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
extension good first issue Good issue to start when you want to learn how to contribute to this open source project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexlib