Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SICER2 does not support rheMac10 out of the box #21

Open
skchronicles opened this issue Oct 20, 2023 · 0 comments
Open

SICER2 does not support rheMac10 out of the box #21

skchronicles opened this issue Oct 20, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@skchronicles
Copy link
Contributor

SICER2 has information pertaining to genome chromosome lengths hard-coded in the following file:
https://github.com/zanglab/SICER2/blob/master/sicer/lib/GenomeData.py

To add support for a new reference genome, a user must do the following:
image

I emailed the author of SICER2 asking if it would be possible to implement any of the suggestions here. It is worth also noting, if one were to make these changes, one should also update the dtype set for chr. At the current moment, it is set to U6 or a unicode string of length 6, which may not be long enough in some edge-cases (could cause a string to get truncated and cause collisions).

For the time being, we will turn off sicer2 when the reference genome is rheMac10; however, we should explore other solutions if the author cannot implement this on their side:

  • Fork and add functionality described in issue 23
  • Fork, update sicer/lib/GenomeData.py with rheMac10 information and build docker image
@skchronicles skchronicles self-assigned this Oct 20, 2023
@skchronicles skchronicles added the enhancement New feature or request label Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant