Resolve draft modified time from commit history instead of cache #3174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds message, time, and renames hexsha to refs (not all refs are a hexsha)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3174 +/- ##
==========================================
- Coverage 44.16% 42.86% -1.30%
==========================================
Files 593 549 -44
Lines 37838 36201 -1637
Branches 1132 1132
==========================================
- Hits 16710 15517 -1193
+ Misses 20926 20482 -444
Partials 202 202 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was served from an infrequently updated cache of the time changed. Most queries already request draft information here, this extends the worker service to return the authored time of the commit in the same request and uses that instead. If this is cached, it's keyed by the commit reference and will remain consistent.
Fixes #3173