[1.12.2] Crash on newer Forge

[Diamondman121314]

NEC crashes on the newer 1.12.2 Forge versions, which would be 2852+.

https://gist.github.com/Diamondman121314/8ce028767f32f74bac4da69b5493bc5a

[Dakedres]

please fix tbh

[ghost]

(a typical request for a fix)

[DDX5-DX12-Media]

Same Happens To Me. I Think It May Be The Sound Lib Playing Havoc Here, Not The Mod's Fault.

[boq]

It's Forge issue, caused by removal of exclude "paulscode/**" from signing task: MinecraftForge/MinecraftForge@db6ab2a#diff-c197962302397baf3a4cc36463dce5eaL246

[DDX5-DX12-Media]

@boq Do You Know The Paulscode Version Used

[boq]

Paulscode version is not a matter here, it's Forge signing one of their classes (https://github.com/MinecraftForge/MinecraftForge/blob/1.12.x/src/main/java/paulscode/sound/codecs/CodecIBXM.java)

[DDX5-DX12-Media]

@boq I see That, Have You Tried To Add A Dependency For The Paulscode Lib So It Overrides The Forge Embedded Lib Instead

[DDX5-DX12-Media]

My Bad, Forgot To Elaborate. Open The Build.gradle file And Add The Following.
compile group: 'com.github.nifty-gui', name: 'nifty-pauls-soundsystem', version: '1.4.2'

[boq]

That won't fix anything, as mod classes are loaded after Forge. Also compile does not mean it will be available during loading in modding setup, as everything needs to be inside single jar file.

Solutions are either to repackage CodecWav (not doing that due to license problems) or remove WAV support (and I don't want to do narrow supported formats), so I don't see that being resolved on my side any time soon.

[DDX5-DX12-Media]

I See, That's A Bit Of A Shame That They Had To Do That.

[ChromaPIE]

In case anyone missed it, there's a fork available for newer forge: https://www.curseforge.com/minecraft/mc-mods/justenoughcodec