Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OMSens and aggregate models #13

Open
GianniFerretti opened this issue Feb 7, 2021 · 8 comments
Open

OMSens and aggregate models #13

GianniFerretti opened this issue Feb 7, 2021 · 8 comments
Assignees

Comments

@GianniFerretti
Copy link

Good afternoon,

I tried OMSens with a simple cascade of two first order systems:

image
image

It didn't work:

image

I would also suggest to set the analysis results destination folder in the same directory of the model to be analyzed.

It is not possible to distinguish the state variables:

image
image

It is not possible to distinguish the parameters of the blocks:

image
image

I would also suggest to select the parameters to be considered for the analysis through an annotation.

Best Regards

Gianni

@casella
Copy link

casella commented Mar 4, 2021

@adrpo wrote me somewhere (I can't find it now) that he probably has a clue about the error. Can @adrpo or @adeas31 take care of that?

The tool seems quite powerful, but if you can't use libraries and you can only use self-contained models, its usability is very severely restricted.

Thanks!

@adeas31
Copy link
Member

adeas31 commented Mar 4, 2021

I remember @JKRT did some work on it. Basically his idea was to write a sort of wrapper model and propagate variables to it so OMSens can use them.

@casella
Copy link

casella commented Mar 4, 2021

@JKRT, maybe we can discuss this at the next devmeeting on Monday? This should be clarified for end users.

@Vivek106singh
Copy link

I tried making a wrapper model but still getting same error.
Please provide some small example

@JKRT
Copy link
Member

JKRT commented Oct 21, 2021

I remember @JKRT did some work on it. Basically his idea was to write a sort of wrapper model and propagate variables to it so OMSens can use them.

That is true I did indeed! I need to find this email...
I have a vague memory that I helped some students a while back with exactly this issue (Or if I resolved it for myself).
The problem is as usual with me that I have a memory of a goldfish..
Seems I missed this issue but I think that was due to me having Covid-19 around that time last year..
@JKRT, maybe we can discuss this at the next devmeeting on Monday? This should be clarified for end users.
Yes and I also have some other questions for you I wish to discuss:) (Concerning what you know about related research in Equation oriented language in general. I have some sort of a mockup for VSS now but I need to know what to focus on so I am bugging everyone currently..)

//John/Night Owl

@GianniFerretti
Copy link
Author

At this link you can download the file

https://www.dropbox.com/s/xajttmyhwbxlstp/ADM1.rar?dl=0

containing the BSM2_Framework package, defining the monolithic ADM1 model, while in the class Example the same aggregated model is defined.
OMSens seems to work of the monolithic but not on the aggregate model.

Best regards

Gianni

@casella
Copy link

casella commented Apr 11, 2024

Thanks @adrpo, this is highly appreciated 😃

@casella
Copy link

casella commented Apr 11, 2024

@adrpo can you please port this to maintenance/v1.23, so we also get it in the 1.23.0 release? Thanks!

@casella casella reopened this Apr 11, 2024
@casella casella moved this to In progress in Release 1.23.0 plan Apr 11, 2024
adrpo added a commit to adrpo/OpenModelica that referenced this issue Apr 29, 2024
…a#12208)

* Use model instance to generate the data needed by OMSens
- should fix OpenModelica/OMSens#13

* update OMSens_Qt to fix running on Linux
casella pushed a commit to OpenModelica/OpenModelica that referenced this issue Apr 29, 2024
…12345)

* update OMSens_Qt submodule to get the latest fixes

* Use model instance to generate the data needed by OMSens (#12208)

* Use model instance to generate the data needed by OMSens
- should fix OpenModelica/OMSens#13

* update OMSens_Qt to fix running on Linux
@casella casella moved this from In progress to Done in Release 1.23.0 plan Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

No branches or pull requests

6 participants