diff --git a/.phpmd.dist.xml b/.phpmd.dist.xml index 1fb0e62b4f2..7ce16d16f86 100644 --- a/.phpmd.dist.xml +++ b/.phpmd.dist.xml @@ -9,13 +9,12 @@ - diff --git a/.phpstan.dist.baseline.neon b/.phpstan.dist.baseline.neon index f9f7f2e4abb..6769af6f986 100644 --- a/.phpstan.dist.baseline.neon +++ b/.phpstan.dist.baseline.neon @@ -3684,12 +3684,6 @@ parameters: count: 1 path: app/code/core/Mage/Customer/Model/Customer/Api/V2.php - - - message: '#^Parameter \#1 \$customer of method Mage_Customer_Model_Resource_Customer\:\:_saveAddresses\(\) expects Mage_Customer_Model_Customer, Varien_Object given\.$#' - identifier: argument.type - count: 1 - path: app/code/core/Mage/Customer/Model/Resource/Customer.php - - message: '#^Parameter \#2 \$entityId of method Mage_Eav_Model_Entity_Abstract\:\:load\(\) expects int, string given\.$#' identifier: argument.type @@ -6084,12 +6078,6 @@ parameters: count: 2 path: app/code/core/Mage/Tax/Helper/Data.php - - - message: '#^Method Mage_Tax_Helper_Data\:\:needPriceConversion\(\) should return int\|false but returns bool\.$#' - identifier: return.type - count: 1 - path: app/code/core/Mage/Tax/Helper/Data.php - - message: '#^Parameter \#1 \$shippingAddress of method Mage_Tax_Model_Calculation\:\:getRateRequest\(\) expects Mage_Sales_Model_Quote_Address\|false\|null, Mage_Customer_Model_Address\|null given\.$#' identifier: argument.type diff --git a/app/Mage.php b/app/Mage.php index ec7df4782f2..d92c8184b10 100644 --- a/app/Mage.php +++ b/app/Mage.php @@ -318,7 +318,7 @@ public static function registry($key) public static function setRoot($appRoot = '') { if (self::$_appRoot) { - return ; + return; } if ($appRoot === '') { diff --git a/app/code/core/Mage/Admin/Model/Acl/Assert/Ip.php b/app/code/core/Mage/Admin/Model/Acl/Assert/Ip.php index 924940aaf7b..a03bbdd706d 100644 --- a/app/code/core/Mage/Admin/Model/Acl/Assert/Ip.php +++ b/app/code/core/Mage/Admin/Model/Acl/Assert/Ip.php @@ -27,6 +27,7 @@ class Mage_Admin_Model_Acl_Assert_Ip implements Zend_Acl_Assert_Interface * * @param string|null $privilege * @return bool|null + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function assert( Mage_Admin_Model_Acl $acl, @@ -39,6 +40,7 @@ public function assert( /** * @param string|false $ip + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _isCleanIP($ip) { diff --git a/app/code/core/Mage/Admin/Model/Acl/Assert/Time.php b/app/code/core/Mage/Admin/Model/Acl/Assert/Time.php index 602a03c76fa..fd16168f085 100644 --- a/app/code/core/Mage/Admin/Model/Acl/Assert/Time.php +++ b/app/code/core/Mage/Admin/Model/Acl/Assert/Time.php @@ -27,6 +27,7 @@ class Mage_Admin_Model_Acl_Assert_Time implements Zend_Acl_Assert_Interface * * @param string|null $privilege * @return bool|null + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function assert( Mage_Admin_Model_Acl $acl, @@ -39,6 +40,7 @@ public function assert( /** * @param int $time + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _isCleanTime($time) { diff --git a/app/code/core/Mage/Admin/Model/Observer.php b/app/code/core/Mage/Admin/Model/Observer.php index 2fee461b49e..237f7cf42a1 100644 --- a/app/code/core/Mage/Admin/Model/Observer.php +++ b/app/code/core/Mage/Admin/Model/Observer.php @@ -28,6 +28,7 @@ class Mage_Admin_Model_Observer * Handler for controller_action_predispatch event * * @param Varien_Event_Observer $observer + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function actionPreDispatchAdmin($observer) { @@ -105,6 +106,7 @@ public function actionPreDispatchAdmin($observer) * * @deprecated after 1.4.0.1, logic moved to admin session * @param Varien_Event_Observer $event + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function actionPostDispatchAdmin($event) {} diff --git a/app/code/core/Mage/AdminNotification/Helper/Data.php b/app/code/core/Mage/AdminNotification/Helper/Data.php index deb14518784..46df2c0d25c 100644 --- a/app/code/core/Mage/AdminNotification/Helper/Data.php +++ b/app/code/core/Mage/AdminNotification/Helper/Data.php @@ -71,6 +71,7 @@ public function getUnreadNoticeCount($severity) * @param bool $withExt * @return string * @deprecated v19.4.16 + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getPopupObjectUrl($withExt = false) { diff --git a/app/code/core/Mage/AdminNotification/Model/Observer.php b/app/code/core/Mage/AdminNotification/Model/Observer.php index 64cac5079ac..86b3e29dd9a 100644 --- a/app/code/core/Mage/AdminNotification/Model/Observer.php +++ b/app/code/core/Mage/AdminNotification/Model/Observer.php @@ -24,6 +24,8 @@ class Mage_AdminNotification_Model_Observer { /** * Predispath admin action controller + * + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function preDispatch(Varien_Event_Observer $observer) { diff --git a/app/code/core/Mage/AdminNotification/Model/Resource/Inbox.php b/app/code/core/Mage/AdminNotification/Model/Resource/Inbox.php index 889afe42d3b..b2545383c51 100644 --- a/app/code/core/Mage/AdminNotification/Model/Resource/Inbox.php +++ b/app/code/core/Mage/AdminNotification/Model/Resource/Inbox.php @@ -60,6 +60,7 @@ public function loadLatestNotice(Mage_AdminNotification_Model_Inbox $object) * Get notifications grouped by severity * * @return array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getNoticeStatus(Mage_AdminNotification_Model_Inbox $object) { @@ -76,6 +77,8 @@ public function getNoticeStatus(Mage_AdminNotification_Model_Inbox $object) /** * Save notifications (if not exists) + * + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function parse(Mage_AdminNotification_Model_Inbox $object, array $data) { diff --git a/app/code/core/Mage/Adminhtml/Block/Cache/Grid.php b/app/code/core/Mage/Adminhtml/Block/Cache/Grid.php index 0052b72901d..b30584f3346 100644 --- a/app/code/core/Mage/Adminhtml/Block/Cache/Grid.php +++ b/app/code/core/Mage/Adminhtml/Block/Cache/Grid.php @@ -102,6 +102,7 @@ protected function _prepareColumns() * Decorate status column values * * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function decorateStatus($value, $row, $column, $isExport) { @@ -122,6 +123,7 @@ public function decorateStatus($value, $row, $column, $isExport) * Get row edit url * * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getRowUrl($row) { diff --git a/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Composite/Fieldset/Grouped.php b/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Composite/Fieldset/Grouped.php index 94c99f14383..e68ba66e173 100644 --- a/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Composite/Fieldset/Grouped.php +++ b/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Composite/Fieldset/Grouped.php @@ -104,6 +104,7 @@ public function setPreconfiguredValue() * * @param Mage_Catalog_Model_Product $product * @return bool + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getCanShowProductPrice($product) { diff --git a/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Composite/Fieldset/Options.php b/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Composite/Fieldset/Options.php index 555d43684d8..ca0ace50f17 100644 --- a/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Composite/Fieldset/Options.php +++ b/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Composite/Fieldset/Options.php @@ -35,7 +35,6 @@ public function __construct() /** * Get option html block * - * * @return string */ public function getOptionHtml(Mage_Catalog_Model_Product_Option $option) diff --git a/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Frontend/Product/Watermark.php b/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Frontend/Product/Watermark.php index d68dca3ccfb..a443b3bf47c 100644 --- a/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Frontend/Product/Watermark.php +++ b/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Frontend/Product/Watermark.php @@ -85,6 +85,9 @@ protected function _getHeaderHtml($element) return $html . ''; } + /** + * @SuppressWarnings("PHPMD.UnusedFormalParameter") + */ protected function _getFooterHtml($element) { return ''; diff --git a/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Helper/Form/Gallery.php b/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Helper/Form/Gallery.php index 2a818ba7dbe..7bde9642f22 100644 --- a/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Helper/Form/Gallery.php +++ b/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Helper/Form/Gallery.php @@ -138,7 +138,6 @@ public function getDataObject() /** * Retrieve attribute field name * - * * @param Mage_Catalog_Model_Resource_Eav_Attribute $attribute * @return string */ diff --git a/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Helper/Form/Price.php b/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Helper/Form/Price.php index c6d36600d8d..40951e40046 100644 --- a/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Helper/Form/Price.php +++ b/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Helper/Form/Price.php @@ -76,6 +76,7 @@ protected function _getTaxObservingCode($attribute) /** * @param null $index deprecated * @return string|null + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getEscapedValue($index = null) { diff --git a/app/code/core/Mage/Adminhtml/Block/Report/Grid/Abstract.php b/app/code/core/Mage/Adminhtml/Block/Report/Grid/Abstract.php index 0ca6a38a784..7e197803445 100644 --- a/app/code/core/Mage/Adminhtml/Block/Report/Grid/Abstract.php +++ b/app/code/core/Mage/Adminhtml/Block/Report/Grid/Abstract.php @@ -315,6 +315,7 @@ protected function _addOrderStatusFilter($collection, $filterData) * @param Mage_Sales_Model_Resource_Report_Collection_Abstract $collection * @param Varien_Object $filterData * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _addCustomFilter($collection, $filterData) { diff --git a/app/code/core/Mage/Adminhtml/Block/Review/Rating/Detailed.php b/app/code/core/Mage/Adminhtml/Block/Review/Rating/Detailed.php index c35c5f5a1ee..e320cdf58e9 100644 --- a/app/code/core/Mage/Adminhtml/Block/Review/Rating/Detailed.php +++ b/app/code/core/Mage/Adminhtml/Block/Review/Rating/Detailed.php @@ -94,6 +94,9 @@ public function setIndependentMode() return $this; } + /** + * @SuppressWarnings("PHPMD.UnusedFormalParameter") + */ public function isSelected($option, $rating) { if ($this->getIsIndependentMode()) { diff --git a/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Form/Abstract.php b/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Form/Abstract.php index 2fab48adc38..7bd68186962 100644 --- a/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Form/Abstract.php +++ b/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Form/Abstract.php @@ -109,6 +109,7 @@ protected function _getAdditionalFormElementRenderers() * Add additional data to form element * * @return Mage_Adminhtml_Block_Sales_Order_Create_Form_Abstract + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _addAdditionalFormElementData(Varien_Data_Form_Element_Abstract $element) { diff --git a/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Giftmessage/Form.php b/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Giftmessage/Form.php index dedc745041c..63c25660ca4 100644 --- a/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Giftmessage/Form.php +++ b/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Giftmessage/Form.php @@ -170,7 +170,6 @@ public function _prepareForm() * Prepare form fieldset * All fields are hidden * - * * @return $this */ protected function _prepareHiddenFields(Varien_Data_Form_Element_Fieldset $fieldset) @@ -204,7 +203,6 @@ protected function _prepareHiddenFields(Varien_Data_Form_Element_Fieldset $field * Prepare form fieldset * All fields are visible * - * * @return $this */ protected function _prepareVisibleFields(Varien_Data_Form_Element_Fieldset $fieldset) diff --git a/app/code/core/Mage/Adminhtml/Block/Sales/Order/Status/Grid.php b/app/code/core/Mage/Adminhtml/Block/Sales/Order/Status/Grid.php index 993683d0fd5..cf2d97574eb 100644 --- a/app/code/core/Mage/Adminhtml/Block/Sales/Order/Status/Grid.php +++ b/app/code/core/Mage/Adminhtml/Block/Sales/Order/Status/Grid.php @@ -90,6 +90,7 @@ protected function _prepareColumns() * Decorate status column values * * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function decorateState($value, $row, $column, $isExport) { @@ -101,6 +102,9 @@ public function decorateState($value, $row, $column, $isExport) return $cell; } + /** + * @SuppressWarnings("PHPMD.UnusedFormalParameter") + */ public function decorateAction($value, $row, $column, $isExport) { $cell = ''; diff --git a/app/code/core/Mage/Adminhtml/Block/System/Config/Form.php b/app/code/core/Mage/Adminhtml/Block/System/Config/Form.php index 62f8e44c0f7..d9ccae7b423 100644 --- a/app/code/core/Mage/Adminhtml/Block/System/Config/Form.php +++ b/app/code/core/Mage/Adminhtml/Block/System/Config/Form.php @@ -536,7 +536,6 @@ protected function _prepareFieldTooltip($element, $helper) /** * Append dependence block at then end of form block * - * */ protected function _afterToHtml($html) { diff --git a/app/code/core/Mage/Adminhtml/Block/System/Config/Form/Field/Array/Abstract.php b/app/code/core/Mage/Adminhtml/Block/System/Config/Form/Field/Array/Abstract.php index 8d9776f577d..1597fe88a1d 100644 --- a/app/code/core/Mage/Adminhtml/Block/System/Config/Form/Field/Array/Abstract.php +++ b/app/code/core/Mage/Adminhtml/Block/System/Config/Form/Field/Array/Abstract.php @@ -107,6 +107,8 @@ protected function _getElementHtml(Varien_Data_Form_Element_Abstract $element) /** * Prepare existing row data object + * + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _prepareArrayRow(Varien_Object $row) { diff --git a/app/code/core/Mage/Adminhtml/Block/System/Config/Form/Fieldset.php b/app/code/core/Mage/Adminhtml/Block/System/Config/Form/Fieldset.php index d627fa8a0d5..d0afc2a5f46 100644 --- a/app/code/core/Mage/Adminhtml/Block/System/Config/Form/Fieldset.php +++ b/app/code/core/Mage/Adminhtml/Block/System/Config/Form/Fieldset.php @@ -168,6 +168,7 @@ protected function _getFooterHtml($element) * @param Varien_Data_Form_Element_Abstract $element * @param bool $tooltipsExist Init tooltips observer or not * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _getExtraJs($element, $tooltipsExist = false) { diff --git a/app/code/core/Mage/Adminhtml/Block/Widget/Container.php b/app/code/core/Mage/Adminhtml/Block/Widget/Container.php index a8fbc946cc1..ac7b19535e2 100644 --- a/app/code/core/Mage/Adminhtml/Block/Widget/Container.php +++ b/app/code/core/Mage/Adminhtml/Block/Widget/Container.php @@ -32,7 +32,6 @@ class Mage_Adminhtml_Block_Widget_Container extends Mage_Adminhtml_Block_Templat /** * Array of buttons * - * * @var array */ protected $_buttons = [ diff --git a/app/code/core/Mage/Adminhtml/Block/Widget/Form.php b/app/code/core/Mage/Adminhtml/Block/Widget/Form.php index a4910e18e85..744630dbe0a 100644 --- a/app/code/core/Mage/Adminhtml/Block/Widget/Form.php +++ b/app/code/core/Mage/Adminhtml/Block/Widget/Form.php @@ -243,6 +243,7 @@ protected function _getAdditionalElementTypes() /** * @param Varien_Data_Form_Element_Abstract $element * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _getAdditionalElementHtml($element) { diff --git a/app/code/core/Mage/Adminhtml/Block/Widget/Grid/Serializer.php b/app/code/core/Mage/Adminhtml/Block/Widget/Grid/Serializer.php index 81daf87d84d..15e6bb445a8 100644 --- a/app/code/core/Mage/Adminhtml/Block/Widget/Grid/Serializer.php +++ b/app/code/core/Mage/Adminhtml/Block/Widget/Grid/Serializer.php @@ -94,7 +94,6 @@ public function getDataAsJSON() * Get serialize data to manage it (called specified method, that return data to manage) * Also use reload param name for saving grid checked boxes states * - * * @param Mage_Adminhtml_Block_Widget_Grid | string $grid grid object or grid block name * @param string $callback block method to retrieve data to serialize * @param string $hiddenInputName hidden input name where serialized data will be store diff --git a/app/code/core/Mage/Adminhtml/Controller/Action.php b/app/code/core/Mage/Adminhtml/Controller/Action.php index 2c84c954b55..199e526e918 100644 --- a/app/code/core/Mage/Adminhtml/Controller/Action.php +++ b/app/code/core/Mage/Adminhtml/Controller/Action.php @@ -296,6 +296,9 @@ public function loadLayout($ids = null, $generateBlocks = true, $generateXml = t return $this; } + /** + * @SuppressWarnings("PHPMD.UnusedFormalParameter") + */ public function norouteAction($coreRoute = null) { $this->getResponse()->setHeader('HTTP/1.1', '404 Not Found'); diff --git a/app/code/core/Mage/Adminhtml/Helper/Data.php b/app/code/core/Mage/Adminhtml/Helper/Data.php index c2e04803818..333df72497e 100644 --- a/app/code/core/Mage/Adminhtml/Helper/Data.php +++ b/app/code/core/Mage/Adminhtml/Helper/Data.php @@ -56,6 +56,7 @@ public function getPageHelpUrl($url = null, $suffix = null) * @param null|string $suffix * @return $this * @deprecated + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function setPageHelpUrl($url = null, $suffix = null) { diff --git a/app/code/core/Mage/Adminhtml/Model/Config.php b/app/code/core/Mage/Adminhtml/Model/Config.php index d4dfdf68d16..9ae012fbfc4 100644 --- a/app/code/core/Mage/Adminhtml/Model/Config.php +++ b/app/code/core/Mage/Adminhtml/Model/Config.php @@ -49,6 +49,7 @@ class Mage_Adminhtml_Model_Config extends Varien_Simplexml_Config * @param string $websiteCode * @param string $storeCode * @return Varien_Simplexml_Element + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getSections($sectionCode = null, $websiteCode = null, $storeCode = null) { @@ -156,6 +157,7 @@ public function getSection($sectionCode = null, $websiteCode = null, $storeCode * @param string $storeCode * @param bool $isField * @return bool + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function hasChildren($node, $websiteCode = null, $storeCode = null, $isField = false) { diff --git a/app/code/core/Mage/Adminhtml/Model/System/Config/Backend/Admin/Observer.php b/app/code/core/Mage/Adminhtml/Model/System/Config/Backend/Admin/Observer.php index 7eac2f0a9c4..0bf744a4d0c 100644 --- a/app/code/core/Mage/Adminhtml/Model/System/Config/Backend/Admin/Observer.php +++ b/app/code/core/Mage/Adminhtml/Model/System/Config/Backend/Admin/Observer.php @@ -25,6 +25,7 @@ class Mage_Adminhtml_Model_System_Config_Backend_Admin_Observer * * @param Varien_Event_Observer $observer * @SuppressWarnings("PHPMD.ExitExpression") + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function afterCustomUrlChanged($observer) { diff --git a/app/code/core/Mage/Adminhtml/Model/System/Config/Source/Currency.php b/app/code/core/Mage/Adminhtml/Model/System/Config/Source/Currency.php index 70e41c1e603..bca4874bc5c 100644 --- a/app/code/core/Mage/Adminhtml/Model/System/Config/Source/Currency.php +++ b/app/code/core/Mage/Adminhtml/Model/System/Config/Source/Currency.php @@ -22,6 +22,9 @@ class Mage_Adminhtml_Model_System_Config_Source_Currency { protected $_options; + /** + * @SuppressWarnings("PHPMD.UnusedFormalParameter") + */ public function toOptionArray($isMultiselect) { if (!$this->_options) { diff --git a/app/code/core/Mage/Adminhtml/Model/System/Config/Source/Currency/Service.php b/app/code/core/Mage/Adminhtml/Model/System/Config/Source/Currency/Service.php index 93da3b63ad0..3ad34ae7e26 100644 --- a/app/code/core/Mage/Adminhtml/Model/System/Config/Source/Currency/Service.php +++ b/app/code/core/Mage/Adminhtml/Model/System/Config/Source/Currency/Service.php @@ -22,6 +22,9 @@ class Mage_Adminhtml_Model_System_Config_Source_Currency_Service { protected $_options; + /** + * @SuppressWarnings("PHPMD.UnusedFormalParameter") + */ public function toOptionArray($isMultiselect) { if (!$this->_options) { diff --git a/app/code/core/Mage/Adminhtml/controllers/NotificationController.php b/app/code/core/Mage/Adminhtml/controllers/NotificationController.php index 8da12e14ff4..f68d8b166d6 100644 --- a/app/code/core/Mage/Adminhtml/controllers/NotificationController.php +++ b/app/code/core/Mage/Adminhtml/controllers/NotificationController.php @@ -43,7 +43,7 @@ public function markAsReadAction() if (!$model->getId()) { $session->addError(Mage::helper('adminnotification')->__('Unable to proceed. Please, try again.')); $this->_redirect('*/*/'); - return ; + return; } try { @@ -99,7 +99,7 @@ public function removeAction() if (!$model->getId()) { $this->_redirect('*/*/'); - return ; + return; } try { diff --git a/app/code/core/Mage/Adminhtml/controllers/Sales/Order/CreditmemoController.php b/app/code/core/Mage/Adminhtml/controllers/Sales/Order/CreditmemoController.php index 78a5b89b17b..156f14c291c 100644 --- a/app/code/core/Mage/Adminhtml/controllers/Sales/Order/CreditmemoController.php +++ b/app/code/core/Mage/Adminhtml/controllers/Sales/Order/CreditmemoController.php @@ -83,6 +83,7 @@ protected function _initInvoice($order) * * @return Mage_Sales_Model_Order_Creditmemo|false * @throws Mage_Core_Exception + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _initCreditmemo($update = false) { diff --git a/app/code/core/Mage/Adminhtml/controllers/Sales/Order/InvoiceController.php b/app/code/core/Mage/Adminhtml/controllers/Sales/Order/InvoiceController.php index 8b7dc0b97c4..9c96fe3a356 100644 --- a/app/code/core/Mage/Adminhtml/controllers/Sales/Order/InvoiceController.php +++ b/app/code/core/Mage/Adminhtml/controllers/Sales/Order/InvoiceController.php @@ -36,6 +36,7 @@ protected function _getItemQtys() * * @return Mage_Sales_Model_Order_Invoice|false * @throws Mage_Core_Exception + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _initInvoice($update = false) { diff --git a/app/code/core/Mage/Adminhtml/controllers/System/StoreController.php b/app/code/core/Mage/Adminhtml/controllers/System/StoreController.php index 29ad5f08df9..1a377e35530 100644 --- a/app/code/core/Mage/Adminhtml/controllers/System/StoreController.php +++ b/app/code/core/Mage/Adminhtml/controllers/System/StoreController.php @@ -266,12 +266,12 @@ public function deleteWebsiteAction() if (!$model = Mage::getModel('core/website')->load($itemId)) { $session->addError(Mage::helper('core')->__('Unable to proceed. Please, try again.')); $this->_redirect('*/*/'); - return ; + return; } if (!$model->isCanDelete()) { $session->addError(Mage::helper('core')->__('This website cannot be deleted.')); $this->_redirect('*/*/editWebsite', ['website_id' => $itemId]); - return ; + return; } $this->_addDeletionNotice('website'); @@ -297,12 +297,12 @@ public function deleteGroupAction() if (!$model = Mage::getModel('core/store_group')->load($itemId)) { $session->addError(Mage::helper('core')->__('Unable to proceed. Please, try again.')); $this->_redirect('*/*/'); - return ; + return; } if (!$model->isCanDelete()) { $session->addError(Mage::helper('core')->__('This store cannot be deleted.')); $this->_redirect('*/*/editGroup', ['group_id' => $itemId]); - return ; + return; } $this->_addDeletionNotice('store'); @@ -328,12 +328,12 @@ public function deleteStoreAction() if (!$model = Mage::getModel('core/store')->load($itemId)) { $session->addError(Mage::helper('core')->__('Unable to proceed. Please, try again.')); $this->_redirect('*/*/'); - return ; + return; } if (!$model->isCanDelete()) { $session->addError(Mage::helper('core')->__('This store view cannot be deleted.')); $this->_redirect('*/*/editStore', ['store_id' => $itemId]); - return ; + return; } $this->_addDeletionNotice('store view'); @@ -355,12 +355,12 @@ public function deleteWebsitePostAction() if (!$model = Mage::getModel('core/website')->load($itemId)) { $this->_getSession()->addError(Mage::helper('core')->__('Unable to proceed. Please, try again')); $this->_redirect('*/*/'); - return ; + return; } if (!$model->isCanDelete()) { $this->_getSession()->addError(Mage::helper('core')->__('This website cannot be deleted.')); $this->_redirect('*/*/editWebsite', ['website_id' => $model->getId()]); - return ; + return; } $this->_backupDatabase('*/*/editWebsite', ['website_id' => $itemId]); @@ -369,7 +369,7 @@ public function deleteWebsitePostAction() $model->delete(); $this->_getSession()->addSuccess(Mage::helper('core')->__('The website has been deleted.')); $this->_redirect('*/*/'); - return ; + return; } catch (Mage_Core_Exception $e) { $this->_getSession()->addError($e->getMessage()); } catch (Exception $e) { @@ -385,12 +385,12 @@ public function deleteGroupPostAction() if (!$model = Mage::getModel('core/store_group')->load($itemId)) { $this->_getSession()->addError(Mage::helper('core')->__('Unable to proceed. Please, try again.')); $this->_redirect('*/*/'); - return ; + return; } if (!$model->isCanDelete()) { $this->_getSession()->addError(Mage::helper('core')->__('This store cannot be deleted.')); $this->_redirect('*/*/editGroup', ['group_id' => $model->getId()]); - return ; + return; } $this->_backupDatabase('*/*/editGroup', ['group_id' => $itemId]); @@ -399,7 +399,7 @@ public function deleteGroupPostAction() $model->delete(); $this->_getSession()->addSuccess(Mage::helper('core')->__('The store has been deleted.')); $this->_redirect('*/*/'); - return ; + return; } catch (Mage_Core_Exception $e) { $this->_getSession()->addError($e->getMessage()); } catch (Exception $e) { @@ -419,12 +419,12 @@ public function deleteStorePostAction() if (!$model = Mage::getModel('core/store')->load($itemId)) { $this->_getSession()->addError(Mage::helper('core')->__('Unable to proceed. Please, try again')); $this->_redirect('*/*/'); - return ; + return; } if (!$model->isCanDelete()) { $this->_getSession()->addError(Mage::helper('core')->__('This store view cannot be deleted.')); $this->_redirect('*/*/editStore', ['store_id' => $model->getId()]); - return ; + return; } $this->_backupDatabase('*/*/editStore', ['store_id' => $itemId]); @@ -436,7 +436,7 @@ public function deleteStorePostAction() $this->_getSession()->addSuccess(Mage::helper('core')->__('The store view has been deleted.')); $this->_redirect('*/*/'); - return ; + return; } catch (Mage_Core_Exception $e) { $this->_getSession()->addError($e->getMessage()); } catch (Exception $e) { diff --git a/app/code/core/Mage/Adminhtml/controllers/Tax/Class/CustomerController.php b/app/code/core/Mage/Adminhtml/controllers/Tax/Class/CustomerController.php index f352f2e6b7e..a5627dbaef9 100644 --- a/app/code/core/Mage/Adminhtml/controllers/Tax/Class/CustomerController.php +++ b/app/code/core/Mage/Adminhtml/controllers/Tax/Class/CustomerController.php @@ -140,7 +140,7 @@ public function deleteAction() $session->addSuccess(Mage::helper('tax')->__('The tax class has been deleted.')); $this->getResponse()->setRedirect($this->getUrl('*/*/')); - return ; + return; } catch (Mage_Core_Exception $e) { $session->addError($e->getMessage()); } catch (Exception $e) { diff --git a/app/code/core/Mage/Api/Model/Acl/Assert/Ip.php b/app/code/core/Mage/Api/Model/Acl/Assert/Ip.php index bddee3907be..4349f5ad8cb 100644 --- a/app/code/core/Mage/Api/Model/Acl/Assert/Ip.php +++ b/app/code/core/Mage/Api/Model/Acl/Assert/Ip.php @@ -27,6 +27,7 @@ class Mage_Api_Model_Acl_Assert_Ip implements Zend_Acl_Assert_Interface * * @param string|null $privilege * @return bool|null + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function assert( Mage_Api_Model_Acl $acl, @@ -39,6 +40,7 @@ public function assert( /** * @param bool $ip + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _isCleanIP($ip) { diff --git a/app/code/core/Mage/Api/Model/Acl/Assert/Time.php b/app/code/core/Mage/Api/Model/Acl/Assert/Time.php index 5c21198dfda..994f99218fb 100644 --- a/app/code/core/Mage/Api/Model/Acl/Assert/Time.php +++ b/app/code/core/Mage/Api/Model/Acl/Assert/Time.php @@ -27,6 +27,7 @@ class Mage_Api_Model_Acl_Assert_Time implements Zend_Acl_Assert_Interface * * @param string|null $privilege * @return bool|null + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function assert( Mage_Api_Model_Acl $acl, @@ -39,6 +40,7 @@ public function assert( /** * @param bool $time + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _isCleanTime($time) { diff --git a/app/code/core/Mage/Api/Model/Cron.php b/app/code/core/Mage/Api/Model/Cron.php index 13669c00cff..d9772fe90f7 100644 --- a/app/code/core/Mage/Api/Model/Cron.php +++ b/app/code/core/Mage/Api/Model/Cron.php @@ -20,6 +20,7 @@ class Mage_Api_Model_Cron * * @param Mage_Cron_Model_Schedule $schedule * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function cleanOldSessions($schedule) { diff --git a/app/code/core/Mage/Api/Model/Session.php b/app/code/core/Mage/Api/Model/Session.php index f9e272ee069..6281ffea85d 100644 --- a/app/code/core/Mage/Api/Model/Session.php +++ b/app/code/core/Mage/Api/Model/Session.php @@ -45,6 +45,7 @@ public function start($sessionName = null) * @param string $namespace * @param string|null $sessionName * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function init($namespace, $sessionName = null) { diff --git a/app/code/core/Mage/Api2/Block/Adminhtml/Roles/Grid.php b/app/code/core/Mage/Api2/Block/Adminhtml/Roles/Grid.php index 066dbe592e3..9bdafe6c1e4 100644 --- a/app/code/core/Mage/Api2/Block/Adminhtml/Roles/Grid.php +++ b/app/code/core/Mage/Api2/Block/Adminhtml/Roles/Grid.php @@ -114,6 +114,7 @@ public function getRowUrl($row) * @param Mage_Adminhtml_Block_Widget_Grid_Column $column * @param bool $isExport * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function decorateUserType($renderedValue, $row, $column, $isExport) { diff --git a/app/code/core/Mage/Api2/Block/Adminhtml/Roles/Tab/Users.php b/app/code/core/Mage/Api2/Block/Adminhtml/Roles/Tab/Users.php index 1a844dbe565..e9702937c64 100644 --- a/app/code/core/Mage/Api2/Block/Adminhtml/Roles/Tab/Users.php +++ b/app/code/core/Mage/Api2/Block/Adminhtml/Roles/Tab/Users.php @@ -111,6 +111,7 @@ public function getGridUrl() * * @param Mage_Api2_Model_Acl_Global_Role $row * @return string|null + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getRowUrl($row) { diff --git a/app/code/core/Mage/Api2/Model/Acl.php b/app/code/core/Mage/Api2/Model/Acl.php index b235e5f7b90..e31ee8b96fe 100644 --- a/app/code/core/Mage/Api2/Model/Acl.php +++ b/app/code/core/Mage/Api2/Model/Acl.php @@ -163,6 +163,7 @@ protected function _setRules() * @param int $roleId Role identifier * @param Zend_Acl_Role_Interface|string|array $parents * @return Zend_Acl Provides a fluent interface + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function addRole($roleId, $parents = null) { diff --git a/app/code/core/Mage/Api2/Model/Acl/Global/Rule/Tree.php b/app/code/core/Mage/Api2/Model/Acl/Global/Rule/Tree.php index dd1213ff628..a8fd9bffde5 100644 --- a/app/code/core/Mage/Api2/Model/Acl/Global/Rule/Tree.php +++ b/app/code/core/Mage/Api2/Model/Acl/Global/Rule/Tree.php @@ -430,6 +430,7 @@ protected function _addOperations(&$item, Varien_Simplexml_Element $node, $name) * @param string $name Node name * @param string $privilege Privilege name * @return bool + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _addAttribute(&$item, Varien_Simplexml_Element $node, $name, $privilege) { diff --git a/app/code/core/Mage/Api2/Model/Request/Interpreter/Xml.php b/app/code/core/Mage/Api2/Model/Request/Interpreter/Xml.php index b49873c4308..1da227edb3c 100644 --- a/app/code/core/Mage/Api2/Model/Request/Interpreter/Xml.php +++ b/app/code/core/Mage/Api2/Model/Request/Interpreter/Xml.php @@ -130,6 +130,7 @@ protected function _toArray(SimpleXMLElement $xmlObject) * @param string $errstr * @param string $errfile * @param int $errline + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _loadErrorHandler($errno, $errstr, $errfile, $errline) { diff --git a/app/code/core/Mage/Authorizenet/Helper/Data.php b/app/code/core/Mage/Authorizenet/Helper/Data.php index 7f2ad4d45a1..057ce33bd88 100644 --- a/app/code/core/Mage/Authorizenet/Helper/Data.php +++ b/app/code/core/Mage/Authorizenet/Helper/Data.php @@ -107,7 +107,8 @@ public function getPlaceOrderAdminUrl() * Retrieve place order url * * @param array $params - * @return string + * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getSuccessOrderUrl($params) { diff --git a/app/code/core/Mage/Authorizenet/Model/Directpost.php b/app/code/core/Mage/Authorizenet/Model/Directpost.php index f6206256437..e28ae5395fe 100644 --- a/app/code/core/Mage/Authorizenet/Model/Directpost.php +++ b/app/code/core/Mage/Authorizenet/Model/Directpost.php @@ -58,6 +58,7 @@ public function validate() * @param float $amount * @return void * @throws Mage_Core_Exception + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function authorize(Varien_Object $payment, $amount) { @@ -127,7 +128,8 @@ public function canRefund() /** * Check void availability * - * @return bool + * @return bool + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function canVoid(Varien_Object $payment) { @@ -519,7 +521,6 @@ protected function _matchAmount($amount) * Operate with order using information from Authorize.net. * Authorize order or authorize and capture it. * - * * @throws Exception */ protected function _authOrder(Mage_Sales_Model_Order $order) diff --git a/app/code/core/Mage/Bundle/Block/Adminhtml/Sales/Order/Items/Renderer.php b/app/code/core/Mage/Bundle/Block/Adminhtml/Sales/Order/Items/Renderer.php index 96fca19317f..60558c2e6b3 100644 --- a/app/code/core/Mage/Bundle/Block/Adminhtml/Sales/Order/Items/Renderer.php +++ b/app/code/core/Mage/Bundle/Block/Adminhtml/Sales/Order/Items/Renderer.php @@ -160,6 +160,7 @@ public function getSelectionAttributes($item) /** * @param null $item deprecated * @return array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getOrderOptions($item = null) { diff --git a/app/code/core/Mage/Bundle/Block/Checkout/Cart/Item/Renderer.php b/app/code/core/Mage/Bundle/Block/Checkout/Cart/Item/Renderer.php index 2893c1121ba..2606ebbd496 100644 --- a/app/code/core/Mage/Bundle/Block/Checkout/Cart/Item/Renderer.php +++ b/app/code/core/Mage/Bundle/Block/Checkout/Cart/Item/Renderer.php @@ -30,6 +30,7 @@ class Mage_Bundle_Block_Checkout_Cart_Item_Renderer extends Mage_Checkout_Block_ * * @param bool $useCache * @return array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _getBundleOptions($useCache = true) { diff --git a/app/code/core/Mage/Bundle/Model/CatalogIndex/Data/Bundle.php b/app/code/core/Mage/Bundle/Model/CatalogIndex/Data/Bundle.php index 69bacdd697c..8055d997dbd 100644 --- a/app/code/core/Mage/Bundle/Model/CatalogIndex/Data/Bundle.php +++ b/app/code/core/Mage/Bundle/Model/CatalogIndex/Data/Bundle.php @@ -68,6 +68,7 @@ protected function _getLinkSettings() * @param string $whereField * @param int $id * @param array $additionalWheres + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _prepareLinkFetchSelect($store, $table, $idField, $whereField, $id, $additionalWheres = []) { diff --git a/app/code/core/Mage/Bundle/Model/Product/Type.php b/app/code/core/Mage/Bundle/Model/Product/Type.php index 5d8f1886832..88a6a2277e1 100644 --- a/app/code/core/Mage/Bundle/Model/Product/Type.php +++ b/app/code/core/Mage/Bundle/Model/Product/Type.php @@ -457,6 +457,7 @@ public function updateQtyOption($options, Varien_Object $option, $value, $produc * @param mixed $qty * @param Mage_Catalog_Model_Product $product * @return int + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function prepareQuoteItemQty($qty, $product = null) { @@ -884,6 +885,7 @@ public function hasOptions($product = null) * * @param Mage_Catalog_Model_Product $product * @return true + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getForceChildItemQtyChanges($product = null) { @@ -994,6 +996,7 @@ public function getProductsToPurchaseByReqGroups($product = null) * @param Mage_Catalog_Model_Product $product * @param Varien_Object $buyRequest * @return array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function processBuyRequest($product, $buyRequest) { @@ -1028,6 +1031,7 @@ public function canConfigure($product = null) * @param Mage_Catalog_Model_Product $product * @param int $visibility * @return bool|null + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function isMapEnabledInOptions($product, $visibility = null) { diff --git a/app/code/core/Mage/Bundle/Model/Sales/Order/Pdf/Items/Abstract.php b/app/code/core/Mage/Bundle/Model/Sales/Order/Pdf/Items/Abstract.php index 0a49779b723..18c3e1cd9b5 100644 --- a/app/code/core/Mage/Bundle/Model/Sales/Order/Pdf/Items/Abstract.php +++ b/app/code/core/Mage/Bundle/Model/Sales/Order/Pdf/Items/Abstract.php @@ -160,6 +160,7 @@ public function isChildCalculated($item = null) * * @param Varien_Object $item * @return array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getBundleOptions($item = null) { @@ -196,6 +197,7 @@ public function getSelectionAttributes($item) * * @param Varien_Object $item * @return array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getOrderOptions($item = null) { diff --git a/app/code/core/Mage/Captcha/Model/Observer.php b/app/code/core/Mage/Captcha/Model/Observer.php index 57b302cc680..ff529134ab8 100644 --- a/app/code/core/Mage/Captcha/Model/Observer.php +++ b/app/code/core/Mage/Captcha/Model/Observer.php @@ -144,6 +144,7 @@ public function checkRegisterCheckout($observer) * * @param Varien_Event_Observer $observer * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function checkUserLoginBackend($observer) { diff --git a/app/code/core/Mage/Catalog/Helper/Image.php b/app/code/core/Mage/Catalog/Helper/Image.php index 2d41a6b4b74..0644e28ab28 100644 --- a/app/code/core/Mage/Catalog/Helper/Image.php +++ b/app/code/core/Mage/Catalog/Helper/Image.php @@ -215,6 +215,7 @@ public function keepAspectRatio($flag) * @param bool $flag * @param array $position * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function keepFrame($flag, $position = ['center', 'middle']) { @@ -233,6 +234,7 @@ public function keepFrame($flag, $position = ['center', 'middle']) * @param bool $flag * @param int $alphaOpacity * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function keepTransparency($flag, $alphaOpacity = null) { diff --git a/app/code/core/Mage/Catalog/Helper/Product.php b/app/code/core/Mage/Catalog/Helper/Product.php index 437749115e6..46ae9f590a0 100644 --- a/app/code/core/Mage/Catalog/Helper/Product.php +++ b/app/code/core/Mage/Catalog/Helper/Product.php @@ -188,6 +188,7 @@ public function getStatuses() * @param Mage_Catalog_Model_Product|int $product * @param string $where * @return bool + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function canShow($product, $where = 'catalog') { diff --git a/app/code/core/Mage/Catalog/Model/Api2/Product/Rest.php b/app/code/core/Mage/Catalog/Model/Api2/Product/Rest.php index 4e36f312dfd..83f65977698 100644 --- a/app/code/core/Mage/Catalog/Model/Api2/Product/Rest.php +++ b/app/code/core/Mage/Catalog/Model/Api2/Product/Rest.php @@ -150,6 +150,8 @@ protected function _prepareProductForResponse(Mage_Catalog_Model_Product $produc /** * Product create only available for admin + * + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _create(array $data) { @@ -158,6 +160,8 @@ protected function _create(array $data) /** * Product update only available for admin + * + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _update(array $data) { @@ -388,6 +392,7 @@ protected function _getCustomerGroupId() * @param float $price * @param bool $withTax * @return float + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _applyTaxToPrice($price, $withTax = true) { diff --git a/app/code/core/Mage/Catalog/Model/Api2/Product/Website/Rest.php b/app/code/core/Mage/Catalog/Model/Api2/Product/Website/Rest.php index 8ea9292ee76..0317d20e895 100644 --- a/app/code/core/Mage/Catalog/Model/Api2/Product/Website/Rest.php +++ b/app/code/core/Mage/Catalog/Model/Api2/Product/Website/Rest.php @@ -173,6 +173,8 @@ protected function _multiCreate(array $data) /** * Product websites update is not available + * + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _update(array $data) { diff --git a/app/code/core/Mage/Catalog/Model/Attribute/Backend/Urlkey/Abstract.php b/app/code/core/Mage/Catalog/Model/Attribute/Backend/Urlkey/Abstract.php index 94b4b2fcd96..0657771c781 100644 --- a/app/code/core/Mage/Catalog/Model/Attribute/Backend/Urlkey/Abstract.php +++ b/app/code/core/Mage/Catalog/Model/Attribute/Backend/Urlkey/Abstract.php @@ -54,8 +54,8 @@ public function beforeSave($object) * Executes after url attribute save. * * @param Varien_Object $object - * * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function afterSave($object) { diff --git a/app/code/core/Mage/Catalog/Model/Layer/Filter/Abstract.php b/app/code/core/Mage/Catalog/Model/Layer/Filter/Abstract.php index 4b8f678792e..043c8a14ff5 100644 --- a/app/code/core/Mage/Catalog/Model/Layer/Filter/Abstract.php +++ b/app/code/core/Mage/Catalog/Model/Layer/Filter/Abstract.php @@ -83,6 +83,7 @@ public function getCleanValue() * * @param null $filterBlock deprecated * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function apply(Zend_Controller_Request_Abstract $request, $filterBlock) { diff --git a/app/code/core/Mage/Catalog/Model/Observer.php b/app/code/core/Mage/Catalog/Model/Observer.php index 1dac955cc34..6d2bba7db5a 100644 --- a/app/code/core/Mage/Catalog/Model/Observer.php +++ b/app/code/core/Mage/Catalog/Model/Observer.php @@ -123,6 +123,7 @@ public function categoryMove(Varien_Event_Observer $observer) * Process catalog data after products import * * @return Mage_Catalog_Model_Observer + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function catalogProductImportAfter(Varien_Event_Observer $observer) { @@ -135,6 +136,7 @@ public function catalogProductImportAfter(Varien_Event_Observer $observer) * Catalog Product Compare Items Clean * * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function catalogProductCompareClean(Varien_Event_Observer $observer) { @@ -170,6 +172,8 @@ public function catalogCheckIsUsingStaticUrlsAllowed(Varien_Event_Observer $obse /** * Cron job method for product prices to reindex + * + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function reindexProductPrices(Mage_Cron_Model_Schedule $schedule) { diff --git a/app/code/core/Mage/Catalog/Model/Product.php b/app/code/core/Mage/Catalog/Model/Product.php index 6575b88c859..47e5b6c6d90 100644 --- a/app/code/core/Mage/Catalog/Model/Product.php +++ b/app/code/core/Mage/Catalog/Model/Product.php @@ -664,6 +664,7 @@ public function getStoreIds() * @param int $groupId Retrieve attributes of the specified group * @param bool $skipSuper Not used * @return array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getAttributes($groupId = null, $skipSuper = false) { diff --git a/app/code/core/Mage/Catalog/Model/Product/Attribute/Backend/Groupprice/Abstract.php b/app/code/core/Mage/Catalog/Model/Product/Attribute/Backend/Groupprice/Abstract.php index f38f7f3ad31..41575ea249e 100644 --- a/app/code/core/Mage/Catalog/Model/Product/Attribute/Backend/Groupprice/Abstract.php +++ b/app/code/core/Mage/Catalog/Model/Product/Attribute/Backend/Groupprice/Abstract.php @@ -88,6 +88,7 @@ protected function _getWebsiteCurrencyRates($websiteId = null) * * @param array $objectArray * @return array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _getAdditionalUniqueFields($objectArray) { diff --git a/app/code/core/Mage/Catalog/Model/Product/Compare/Item.php b/app/code/core/Mage/Catalog/Model/Product/Compare/Item.php index 5b3633e7b1d..b102a1ab65d 100644 --- a/app/code/core/Mage/Catalog/Model/Product/Compare/Item.php +++ b/app/code/core/Mage/Catalog/Model/Product/Compare/Item.php @@ -175,6 +175,7 @@ public function bindCustomerLogin() * Customer logout bind process * * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function bindCustomerLogout(?Varien_Event_Observer $observer = null) { diff --git a/app/code/core/Mage/Catalog/Model/Product/Flat/Observer.php b/app/code/core/Mage/Catalog/Model/Product/Flat/Observer.php index 283233a8bb7..6fe1c864955 100644 --- a/app/code/core/Mage/Catalog/Model/Product/Flat/Observer.php +++ b/app/code/core/Mage/Catalog/Model/Product/Flat/Observer.php @@ -232,6 +232,7 @@ public function storeGroupSave(Varien_Event_Observer $observer) * Catalog Product Import After process * * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function catalogProductImportAfter(Varien_Event_Observer $observer) { @@ -270,6 +271,7 @@ public function customerGroupSaveAfter(Varien_Event_Observer $observer) * * @deprecated 1.3.2.2 * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function catalogCategoryChangeProducts(Varien_Event_Observer $observer) { diff --git a/app/code/core/Mage/Catalog/Model/Product/Option/Type/Default.php b/app/code/core/Mage/Catalog/Model/Product/Option/Type/Default.php index 1ac1af5364b..25fa5d48e91 100644 --- a/app/code/core/Mage/Catalog/Model/Product/Option/Type/Default.php +++ b/app/code/core/Mage/Catalog/Model/Product/Option/Type/Default.php @@ -303,6 +303,7 @@ public function getEditableOptionValue($optionValue) * @param string $optionValue * @param array $productOptionValues Values for product option * @return string|null + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function parseOptionValue($optionValue, $productOptionValues) { @@ -326,6 +327,7 @@ public function prepareOptionValueForRequest($optionValue) * @param string $optionValue Prepared for cart option value * @param float $basePrice For percent price type * @return float + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getOptionPrice($optionValue, $basePrice) { @@ -344,6 +346,7 @@ public function getOptionPrice($optionValue, $basePrice) * @param string $optionValue Prepared for cart option value * @param string $skuDelimiter Delimiter for Sku parts * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getOptionSku($optionValue, $skuDelimiter) { diff --git a/app/code/core/Mage/Catalog/Model/Product/Status.php b/app/code/core/Mage/Catalog/Model/Product/Status.php index 6afc769a3b1..89cd2237e41 100644 --- a/app/code/core/Mage/Catalog/Model/Product/Status.php +++ b/app/code/core/Mage/Catalog/Model/Product/Status.php @@ -62,6 +62,7 @@ public function getProductAttribute($attributeCode) * * @deprecated remove on new builds * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function addVisibleFilterToCollection(Mage_Eav_Model_Entity_Collection_Abstract $collection) { @@ -73,6 +74,7 @@ public function addVisibleFilterToCollection(Mage_Eav_Model_Entity_Collection_Ab * * @deprecated remove on new builds * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function addSaleableFilterToCollection(Mage_Eav_Model_Entity_Collection_Abstract $collection) { diff --git a/app/code/core/Mage/Catalog/Model/Product/Type/Abstract.php b/app/code/core/Mage/Catalog/Model/Product/Type/Abstract.php index a2a574e9758..fc86e4cf738 100644 --- a/app/code/core/Mage/Catalog/Model/Product/Type/Abstract.php +++ b/app/code/core/Mage/Catalog/Model/Product/Type/Abstract.php @@ -173,6 +173,7 @@ public function getRelationInfo() * @param int $parentId * @param bool $required * @return array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getChildrenIds($parentId, $required = true) { @@ -184,6 +185,7 @@ public function getChildrenIds($parentId, $required = true) * * @param int|array $childId * @return array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getParentIdsByChild($childId) { @@ -270,6 +272,7 @@ public function getAttributeById($attributeId, $product = null) * * @param Mage_Catalog_Model_Product $product * @return false + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function isVirtual($product = null) { @@ -629,6 +632,7 @@ public function getOrderOptions($product = null) * * @param Mage_Catalog_Model_Product $product * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function save($product = null) { @@ -672,6 +676,7 @@ public function beforeSave($product = null) * * @param Mage_Catalog_Model_Product $product * @return bool + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function isComposite($product = null) { @@ -683,6 +688,7 @@ public function isComposite($product = null) * * @param Mage_Catalog_Model_Product $product * @return bool + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function canConfigure($product = null) { @@ -789,6 +795,7 @@ public function hasOptions($product = null) * @param mixed $value * @param Mage_Catalog_Model_Product $product * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function updateQtyOption($options, Varien_Object $option, $value, $product = null) { @@ -841,6 +848,7 @@ public function setStoreFilter($store = null, $product = null) * * @param Mage_Catalog_Model_Product|null $product * @return bool + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getForceChildItemQtyChanges($product = null) { @@ -853,6 +861,7 @@ public function getForceChildItemQtyChanges($product = null) * @param mixed $qty * @param Mage_Catalog_Model_Product|null $product * @return float + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function prepareQuoteItemQty($qty, $product = null) { @@ -934,6 +943,7 @@ public function getProductsToPurchaseByReqGroups($product = null) * @param Mage_Catalog_Model_Product $product * @param Varien_Object $buyRequest * @return array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function processBuyRequest($product, $buyRequest) { @@ -978,6 +988,7 @@ public function checkProductConfiguration($product, $buyRequest) * @param Mage_Catalog_Model_Product $product * @param int $visibility * @return false + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function isMapEnabledInOptions($product, $visibility = null) { diff --git a/app/code/core/Mage/Catalog/Model/Product/Type/Price.php b/app/code/core/Mage/Catalog/Model/Product/Type/Price.php index 765f4f3b170..e15f1bbae92 100644 --- a/app/code/core/Mage/Catalog/Model/Product/Type/Price.php +++ b/app/code/core/Mage/Catalog/Model/Product/Type/Price.php @@ -86,6 +86,7 @@ public function getFinalPrice($qty, $product) * @param Mage_Catalog_Model_Product $childProduct * @param float $childProductQty * @return float + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getChildFinalPrice($product, $productQty, $childProduct, $childProductQty) { @@ -333,6 +334,7 @@ public function getFormatedPrice($product) * @param int $qty * @param float $finalPrice * @return float + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _applyOptionsPrice($product, $qty, $finalPrice) { diff --git a/app/code/core/Mage/Catalog/Model/Resource/Abstract.php b/app/code/core/Mage/Catalog/Model/Resource/Abstract.php index 298ad27dd21..8212773409b 100644 --- a/app/code/core/Mage/Catalog/Model/Resource/Abstract.php +++ b/app/code/core/Mage/Catalog/Model/Resource/Abstract.php @@ -139,6 +139,7 @@ protected function _getLoadAttributesSelect($object, $table) * @param string $table * @param string $type * @return Varien_Db_Select + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _addLoadAttributesSelectFields($select, $table, $type) { @@ -315,6 +316,7 @@ protected function _insertAttribute($object, $attribute, $value) * @param mixed $valueId * @param mixed $value * @return Mage_Catalog_Model_Resource_Abstract + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _updateAttribute($object, $attribute, $valueId, $value) { @@ -513,6 +515,7 @@ protected function _collectOrigData($object) * * @param mixed $value * @return bool + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _isAttributeValueEmpty(Mage_Eav_Model_Entity_Attribute_Abstract $attribute, $value) { diff --git a/app/code/core/Mage/Catalog/Model/Resource/Category/Attribute/Collection.php b/app/code/core/Mage/Catalog/Model/Resource/Category/Attribute/Collection.php index e8d8354d4d0..37dbbf42633 100644 --- a/app/code/core/Mage/Catalog/Model/Resource/Category/Attribute/Collection.php +++ b/app/code/core/Mage/Catalog/Model/Resource/Category/Attribute/Collection.php @@ -44,6 +44,7 @@ protected function _initSelect() * * @param int $typeId * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function setEntityTypeFilter($typeId) { diff --git a/app/code/core/Mage/Catalog/Model/Resource/Category/Indexer/Product.php b/app/code/core/Mage/Catalog/Model/Resource/Category/Indexer/Product.php index e7903f65d7b..ffc3928c4de 100644 --- a/app/code/core/Mage/Catalog/Model/Resource/Category/Indexer/Product.php +++ b/app/code/core/Mage/Catalog/Model/Resource/Category/Indexer/Product.php @@ -1168,6 +1168,7 @@ protected function _getAnchorCategoriesProductsTemporaryTable() * * @param string $table * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getIdxTable($table = null) { diff --git a/app/code/core/Mage/Catalog/Model/Resource/Helper/Mysql4.php b/app/code/core/Mage/Catalog/Model/Resource/Helper/Mysql4.php index 745cdd0fa9d..ad743b7c123 100644 --- a/app/code/core/Mage/Catalog/Model/Resource/Helper/Mysql4.php +++ b/app/code/core/Mage/Catalog/Model/Resource/Helper/Mysql4.php @@ -28,6 +28,7 @@ class Mage_Catalog_Model_Resource_Helper_Mysql4 extends Mage_Eav_Model_Resource_ * @param string $tableAlias * @param string $eavType * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function attributeSelectFields($tableAlias, $eavType) { diff --git a/app/code/core/Mage/Catalog/Model/Resource/Product.php b/app/code/core/Mage/Catalog/Model/Resource/Product.php index 8e4984c7e56..74cd102f337 100644 --- a/app/code/core/Mage/Catalog/Model/Resource/Product.php +++ b/app/code/core/Mage/Catalog/Model/Resource/Product.php @@ -626,6 +626,7 @@ public function getProductsSku(array $productIds) * @param Mage_Catalog_Model_Product $object * @return array * @deprecated after 1.4.2.0 + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getParentProductIds($object) { diff --git a/app/code/core/Mage/Catalog/Model/Resource/Product/Attribute/Collection.php b/app/code/core/Mage/Catalog/Model/Resource/Product/Attribute/Collection.php index 8cf405b2911..903b3a91757 100644 --- a/app/code/core/Mage/Catalog/Model/Resource/Product/Attribute/Collection.php +++ b/app/code/core/Mage/Catalog/Model/Resource/Product/Attribute/Collection.php @@ -66,6 +66,8 @@ protected function _initSelect() * * @param int $typeId * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") + * */ public function setEntityTypeFilter($typeId) { diff --git a/app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Eav.php b/app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Eav.php index 63cee0d0a77..0c6cca7bd09 100644 --- a/app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Eav.php +++ b/app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Eav.php @@ -177,6 +177,7 @@ public function reindexAll() * * @param string $table * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getIdxTable($table = null) { diff --git a/app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Eav/Abstract.php b/app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Eav/Abstract.php index cb9450bdf3b..25306e10d5d 100644 --- a/app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Eav/Abstract.php +++ b/app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Eav/Abstract.php @@ -25,7 +25,6 @@ abstract class Mage_Catalog_Model_Resource_Product_Indexer_Eav_Abstract extends /** * Rebuild all index data * - * * @return Mage_Catalog_Model_Resource_Product_Indexer_Eav_Abstract */ public function reindexAll() @@ -51,7 +50,6 @@ public function reindexAll() /** * Rebuild index data by entities * - * * @param int|array $processIds * @return Mage_Catalog_Model_Resource_Product_Indexer_Eav_Abstract * @throws Exception @@ -101,7 +99,6 @@ public function reindexEntities($processIds) * Rebuild index data by attribute id * If attribute is not indexable remove data by attribute * - * * @param int $attributeId * @param bool $isIndexable * @return Mage_Catalog_Model_Resource_Product_Indexer_Eav_Abstract diff --git a/app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Eav/Decimal.php b/app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Eav/Decimal.php index 49e256c5c04..31be302f75b 100644 --- a/app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Eav/Decimal.php +++ b/app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Eav/Decimal.php @@ -121,6 +121,7 @@ protected function _getIndexableAttributes() * * @param string $table * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getIdxTable($table = null) { diff --git a/app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Eav/Source.php b/app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Eav/Source.php index eeac3506258..2cacefa60a9 100644 --- a/app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Eav/Source.php +++ b/app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Eav/Source.php @@ -274,6 +274,7 @@ protected function _saveIndexData(array $data) * * @param string $table * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getIdxTable($table = null) { diff --git a/app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Price.php b/app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Price.php index eb6c8599c18..3801f238e38 100644 --- a/app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Price.php +++ b/app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Price.php @@ -601,6 +601,7 @@ protected function _prepareWebsiteDateTable() * * @param string $table * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getIdxTable($table = null) { diff --git a/app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Price/Default.php b/app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Price/Default.php index 6b3b7d7c688..1c2f287e869 100644 --- a/app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Price/Default.php +++ b/app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Price/Default.php @@ -595,6 +595,8 @@ protected function _getGroupPriceIndexTable() /** * Register data required by product type process in event object + * + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function registerEvent(Mage_Index_Model_Event $event) {} @@ -603,6 +605,7 @@ public function registerEvent(Mage_Index_Model_Event $event) {} * * @param string $table * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getIdxTable($table = null) { diff --git a/app/code/core/Mage/Catalog/Model/Resource/Product/Option/Value/Collection.php b/app/code/core/Mage/Catalog/Model/Resource/Product/Option/Value/Collection.php index 2a863f806e0..ffb1c99b5cb 100644 --- a/app/code/core/Mage/Catalog/Model/Resource/Product/Option/Value/Collection.php +++ b/app/code/core/Mage/Catalog/Model/Resource/Product/Option/Value/Collection.php @@ -193,6 +193,7 @@ public function addPriceToResult($storeId) * @param array $optionIds * @param int $storeId * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getValuesByOption($optionIds, $storeId = null) { diff --git a/app/code/core/Mage/Catalog/Model/Resource/Product/Type/Configurable.php b/app/code/core/Mage/Catalog/Model/Resource/Product/Type/Configurable.php index bbfc2fd3e2e..80740bbe1aa 100644 --- a/app/code/core/Mage/Catalog/Model/Resource/Product/Type/Configurable.php +++ b/app/code/core/Mage/Catalog/Model/Resource/Product/Type/Configurable.php @@ -92,6 +92,7 @@ public function saveProducts($mainProduct, $productIds) * @param int $parentId * @param bool $required * @return array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getChildrenIds($parentId, $required = true) { diff --git a/app/code/core/Mage/Catalog/Model/Resource/Product/Type/Configurable/Attribute.php b/app/code/core/Mage/Catalog/Model/Resource/Product/Type/Configurable/Attribute.php index 7f3278706ee..52d1c9eba52 100644 --- a/app/code/core/Mage/Catalog/Model/Resource/Product/Type/Configurable/Attribute.php +++ b/app/code/core/Mage/Catalog/Model/Resource/Product/Type/Configurable/Attribute.php @@ -63,6 +63,7 @@ public function getCatalogHelper() * * @param Mage_Eav_Model_Entity_Attribute_Abstract $attribute * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function loadLabel($attribute) { @@ -75,6 +76,7 @@ public function loadLabel($attribute) * * @param Mage_Eav_Model_Entity_Attribute_Abstract $attribute * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function loadPrices($attribute) { diff --git a/app/code/core/Mage/CatalogIndex/Model/Indexer.php b/app/code/core/Mage/CatalogIndex/Model/Indexer.php index 4b766abedfc..5f9b5f7aad6 100644 --- a/app/code/core/Mage/CatalogIndex/Model/Indexer.php +++ b/app/code/core/Mage/CatalogIndex/Model/Indexer.php @@ -579,6 +579,7 @@ protected function _getBaseToSpecifiedCurrencyRate($code) * @param array $filteredAttributes * @param Mage_Catalog_Model_Resource_Product_Collection $productCollection * @return array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function buildEntityPriceFilter($attributes, $values, &$filteredAttributes, $productCollection) { @@ -679,6 +680,7 @@ public function buildEntityPriceFilter($attributes, $values, &$filteredAttribute * @param array $filteredAttributes * @param Mage_Catalog_Model_Resource_Product_Collection $productCollection * @return array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function buildEntityFilter($attributes, $values, &$filteredAttributes, $productCollection) { diff --git a/app/code/core/Mage/CatalogIndex/Model/Indexer/Abstract.php b/app/code/core/Mage/CatalogIndex/Model/Indexer/Abstract.php index 5666bb8ec60..9fccdb3484f 100644 --- a/app/code/core/Mage/CatalogIndex/Model/Indexer/Abstract.php +++ b/app/code/core/Mage/CatalogIndex/Model/Indexer/Abstract.php @@ -139,6 +139,7 @@ public function isAttributeIndexable(Mage_Eav_Model_Entity_Attribute_Abstract $a /** * @return bool + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _isAttributeIndexable(Mage_Eav_Model_Entity_Attribute_Abstract $attribute) { diff --git a/app/code/core/Mage/CatalogIndex/Model/Observer.php b/app/code/core/Mage/CatalogIndex/Model/Observer.php index 067e11b5346..aeaa57e73fd 100644 --- a/app/code/core/Mage/CatalogIndex/Model/Observer.php +++ b/app/code/core/Mage/CatalogIndex/Model/Observer.php @@ -205,7 +205,8 @@ public function processStoreAdd(Varien_Event_Observer $observer) /** * Rebuild index after catalog import * - * @return Mage_CatalogIndex_Model_Observer + * @return Mage_CatalogIndex_Model_Observer + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function catalogProductImportAfter(Varien_Event_Observer $observer) { diff --git a/app/code/core/Mage/CatalogIndex/Model/Resource/Data/Abstract.php b/app/code/core/Mage/CatalogIndex/Model/Resource/Data/Abstract.php index bdcc7950276..0439b83c291 100644 --- a/app/code/core/Mage/CatalogIndex/Model/Resource/Data/Abstract.php +++ b/app/code/core/Mage/CatalogIndex/Model/Resource/Data/Abstract.php @@ -167,6 +167,7 @@ public function fetchLinkInformation($store, $table, $idField, $whereField, $id, * @param string $whereField * @param int $id * @param array $additionalWheres + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _prepareLinkFetchSelect($store, $table, $idField, $whereField, $id, $additionalWheres = []) {} diff --git a/app/code/core/Mage/CatalogIndex/Model/Resource/Indexer.php b/app/code/core/Mage/CatalogIndex/Model/Resource/Indexer.php index 261c2167bb8..37858398752 100644 --- a/app/code/core/Mage/CatalogIndex/Model/Resource/Indexer.php +++ b/app/code/core/Mage/CatalogIndex/Model/Resource/Indexer.php @@ -65,6 +65,7 @@ protected function _loadAttribute($id) * @param bool $tierPrice clear tier price index data flag * @param Mage_Catalog_Model_Product|Mage_Catalog_Model_Product_Condition_Interface|int|array|null $products applicable products * @param mixed $store applicable stores + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function clear( $eav = true, diff --git a/app/code/core/Mage/CatalogIndex/Model/Resource/Indexer/Abstract.php b/app/code/core/Mage/CatalogIndex/Model/Resource/Indexer/Abstract.php index 7f220922d7a..e8068c1cb3f 100644 --- a/app/code/core/Mage/CatalogIndex/Model/Resource/Indexer/Abstract.php +++ b/app/code/core/Mage/CatalogIndex/Model/Resource/Indexer/Abstract.php @@ -68,6 +68,7 @@ public function saveIndices(array $data, $storeId, $productId) * @param int $storeId * @param int $productId * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _executeReplace($data, $storeId, $productId) { diff --git a/app/code/core/Mage/CatalogInventory/Model/Observer.php b/app/code/core/Mage/CatalogInventory/Model/Observer.php index 44f00f632f5..7b93b1d1ec8 100644 --- a/app/code/core/Mage/CatalogInventory/Model/Observer.php +++ b/app/code/core/Mage/CatalogInventory/Model/Observer.php @@ -848,7 +848,8 @@ public function cancelOrderItem($observer) * Update items stock status and low stock date. * * @param Varien_Event_Observer $observer - * @return $this + * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function updateItemsStockUponConfigChange($observer) { @@ -1035,6 +1036,7 @@ public function refundOrderItem($observer) * * @param Varien_Event_Observer $observer * @throws Exception + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function reindexProductsMassAction($observer) { diff --git a/app/code/core/Mage/CatalogInventory/Model/Resource/Indexer/Stock.php b/app/code/core/Mage/CatalogInventory/Model/Resource/Indexer/Stock.php index da69d84bcff..36cc71e1fee 100644 --- a/app/code/core/Mage/CatalogInventory/Model/Resource/Indexer/Stock.php +++ b/app/code/core/Mage/CatalogInventory/Model/Resource/Indexer/Stock.php @@ -300,6 +300,7 @@ public function getProductParentsByChild($childId) * * @param string $table * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getIdxTable($table = null) { diff --git a/app/code/core/Mage/CatalogInventory/Model/Resource/Indexer/Stock/Default.php b/app/code/core/Mage/CatalogInventory/Model/Resource/Indexer/Stock/Default.php index e8d408e33be..a2d2f97fae0 100644 --- a/app/code/core/Mage/CatalogInventory/Model/Resource/Indexer/Stock/Default.php +++ b/app/code/core/Mage/CatalogInventory/Model/Resource/Indexer/Stock/Default.php @@ -137,6 +137,7 @@ protected function _isManageStock() * @param int|array $entityIds * @param bool $usePrimaryTable use primary or temporary index table * @return Varien_Db_Select + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _getStockStatusSelect($entityIds = null, $usePrimaryTable = false) { @@ -263,6 +264,7 @@ protected function _updateIndexTable($data) * * @param string $table * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getIdxTable($table = null) { diff --git a/app/code/core/Mage/CatalogRule/Model/Observer.php b/app/code/core/Mage/CatalogRule/Model/Observer.php index 30a1889ed23..32c3129696a 100644 --- a/app/code/core/Mage/CatalogRule/Model/Observer.php +++ b/app/code/core/Mage/CatalogRule/Model/Observer.php @@ -79,8 +79,8 @@ public function loadProductRules($observer) * Handle catalog_product_import_after event * * @param Varien_Event_Observer $observer - * * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function applyAllRules($observer) { @@ -97,7 +97,6 @@ public function applyAllRules($observer) /** * Preload all price rules for all items in quote * - * * @return $this */ public function preloadPriceRules(Varien_Event_Observer $observer) @@ -221,7 +220,6 @@ public function processAdminFinalPrice($observer) /** * Calculate price using catalog price rules of configurable product * - * * @return $this */ public function catalogProductTypeConfigurablePrice(Varien_Event_Observer $observer) @@ -248,8 +246,8 @@ public function catalogProductTypeConfigurablePrice(Varien_Event_Observer $obser * we should generate data for interval -1 day ... +1 day * * @param Varien_Event_Observer $observer - * * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function dailyCatalogUpdate($observer) { @@ -359,7 +357,6 @@ protected function _removeAttributeFromConditions($combine, $attributeCode) /** * After save attribute if it is not used for promo rules already check rules for containing this attribute * - * * @return $this */ public function catalogAttributeSaveAfter(Varien_Event_Observer $observer) @@ -462,6 +459,8 @@ public function createCatalogRulesRelations(Varien_Event_Observer $observer) /** * Runs Catalog Product Price Reindex + * + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function runCatalogProductPriceReindex(Varien_Event_Observer $observer) { diff --git a/app/code/core/Mage/CatalogRule/Model/Resource/Rule.php b/app/code/core/Mage/CatalogRule/Model/Resource/Rule.php index c486b8ab2a2..75c54bd23af 100644 --- a/app/code/core/Mage/CatalogRule/Model/Resource/Rule.php +++ b/app/code/core/Mage/CatalogRule/Model/Resource/Rule.php @@ -88,7 +88,6 @@ protected function _construct() /** * Add customer group ids and website ids to rule data after load * - * * @inheritDoc */ protected function _afterLoad(Mage_Core_Model_Abstract $object) @@ -103,7 +102,6 @@ protected function _afterLoad(Mage_Core_Model_Abstract $object) * Bind catalog rule to customer group(s) and website(s). * Update products which are matched for rule. * - * * @return $this */ protected function _afterSave(Mage_Core_Model_Abstract $object) @@ -307,7 +305,6 @@ public function insertRuleData(Mage_CatalogRule_Model_Rule $rule, array $website /** * Update products which are matched for rule * - * * @throws Exception * @return $this */ @@ -547,6 +544,7 @@ public function applyAllRules($product = null) * @deprecated after 1.7.0.2 use method applyAllRules * * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function applyAllRulesForDateRange($fromDate = null, $toDate = null, $productId = null) { diff --git a/app/code/core/Mage/CatalogRule/Model/Rule.php b/app/code/core/Mage/CatalogRule/Model/Rule.php index 7cae8e9606e..2d3f1a9c2e6 100644 --- a/app/code/core/Mage/CatalogRule/Model/Rule.php +++ b/app/code/core/Mage/CatalogRule/Model/Rule.php @@ -441,8 +441,8 @@ protected function _invalidateCache() * @deprecated after 1.11.2.0 * * @param string $format - * * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function toString($format = '') { diff --git a/app/code/core/Mage/CatalogSearch/Block/Advanced/Form.php b/app/code/core/Mage/CatalogSearch/Block/Advanced/Form.php index 6b07cf28913..16f5f9cdc34 100644 --- a/app/code/core/Mage/CatalogSearch/Block/Advanced/Form.php +++ b/app/code/core/Mage/CatalogSearch/Block/Advanced/Form.php @@ -135,6 +135,7 @@ public function getCurrencyCount() * * @param Mage_Eav_Model_Entity_Attribute_Abstract $attribute * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getCurrency($attribute) { diff --git a/app/code/core/Mage/CatalogSearch/Helper/Data.php b/app/code/core/Mage/CatalogSearch/Helper/Data.php index 311782b2abf..98cdd56472e 100644 --- a/app/code/core/Mage/CatalogSearch/Helper/Data.php +++ b/app/code/core/Mage/CatalogSearch/Helper/Data.php @@ -280,6 +280,7 @@ public function getNoteMessages() * Check query of a warnings * * @param mixed $store + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function checkNotes($store = null) { diff --git a/app/code/core/Mage/CatalogSearch/Model/Resource/Advanced.php b/app/code/core/Mage/CatalogSearch/Model/Resource/Advanced.php index cd5946ba578..1f0a7786ff3 100644 --- a/app/code/core/Mage/CatalogSearch/Model/Resource/Advanced.php +++ b/app/code/core/Mage/CatalogSearch/Model/Resource/Advanced.php @@ -60,6 +60,7 @@ protected function _dispatchPreparePriceEvent($select) * @param string|array $value * @param Mage_CatalogSearch_Model_Resource_Advanced_Collection $collection * @return array|false|string|string[] + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function prepareCondition($attribute, $value, $collection) { @@ -94,6 +95,7 @@ public function prepareCondition($attribute, $value, $collection) * @param string|array $value * @param int $rate * @return bool + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function addRatedPriceFilter($collection, $attribute, $value, $rate = 1) { diff --git a/app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext.php b/app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext.php index 51e433d58ab..36039e20278 100644 --- a/app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext.php +++ b/app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext.php @@ -847,6 +847,7 @@ public function setAllowTableChanges($value = true) * @param array $productIds * @param array $categoryIds * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function updateCategoryIndex($productIds, $categoryIds) { diff --git a/app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext/Collection.php b/app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext/Collection.php index 85ff963043e..f09809c646b 100644 --- a/app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext/Collection.php +++ b/app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext/Collection.php @@ -70,6 +70,7 @@ protected function _getQuery() * * @param string $query * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function addSearchFilter($query) { diff --git a/app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext/Engine.php b/app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext/Engine.php index 3a4736b6d88..6fd466ae6ec 100644 --- a/app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext/Engine.php +++ b/app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext/Engine.php @@ -39,6 +39,7 @@ protected function _construct() * @param array $index * @param string $entity 'product'|'cms' * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function saveEntityIndex($entityId, $storeId, $index, $entity = 'product') { @@ -57,6 +58,7 @@ public function saveEntityIndex($entityId, $storeId, $index, $entity = 'product' * @param array $entityIndexes * @param string $entity 'product'|'cms' * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function saveEntityIndexes($storeId, $entityIndexes, $entity = 'product') { @@ -106,6 +108,7 @@ public function allowAdvancedIndex() * @param int $entityId * @param string $entity 'product'|'cms' * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function cleanIndex($storeId = null, $entityId = null, $entity = 'product') { diff --git a/app/code/core/Mage/CatalogSearch/Model/Resource/Helper/Mysql4.php b/app/code/core/Mage/CatalogSearch/Model/Resource/Helper/Mysql4.php index d0fe91ac9c0..92ad41dc902 100644 --- a/app/code/core/Mage/CatalogSearch/Model/Resource/Helper/Mysql4.php +++ b/app/code/core/Mage/CatalogSearch/Model/Resource/Helper/Mysql4.php @@ -28,7 +28,8 @@ class Mage_CatalogSearch_Model_Resource_Helper_Mysql4 extends Mage_Eav_Model_Res * @param string $table * @param string $alias * @param Varien_Db_Select $select - * @return Zend_Db_Expr $select + * @return Zend_Db_Expr + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function chooseFulltext($table, $alias, $select) { diff --git a/app/code/core/Mage/CatalogSearch/Model/Resource/Search/Collection.php b/app/code/core/Mage/CatalogSearch/Model/Resource/Search/Collection.php index 38e2691028a..38e9f69076a 100644 --- a/app/code/core/Mage/CatalogSearch/Model/Resource/Search/Collection.php +++ b/app/code/core/Mage/CatalogSearch/Model/Resource/Search/Collection.php @@ -168,6 +168,7 @@ protected function _getSearchEntityIdsSql($query) * * @param string $query * @return false|Varien_Db_Select + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _getSearchInOptionSql($query) { diff --git a/app/code/core/Mage/Centinel/Model/Api/Client.php b/app/code/core/Mage/Centinel/Model/Api/Client.php index 4aaec5b48fe..4c745f1a3a5 100644 --- a/app/code/core/Mage/Centinel/Model/Api/Client.php +++ b/app/code/core/Mage/Centinel/Model/Api/Client.php @@ -27,6 +27,9 @@ */ class Mage_Centinel_Model_Api_Client extends CentinelClient { + /** + * @SuppressWarnings("PHPMD.UnusedFormalParameter") + */ public function sendHttp($url, $connectTimeout, $timeout) { // verify that the URL uses a supported protocol. diff --git a/app/code/core/Mage/Centinel/Model/StateAbstract.php b/app/code/core/Mage/Centinel/Model/StateAbstract.php index 552bbe3c53e..83776dc2d1a 100644 --- a/app/code/core/Mage/Centinel/Model/StateAbstract.php +++ b/app/code/core/Mage/Centinel/Model/StateAbstract.php @@ -63,6 +63,7 @@ public function getDataStorage() * @param string $key * @param string|int $index * @return mixed + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getData($key = '', $index = null) { diff --git a/app/code/core/Mage/Checkout/Model/Session.php b/app/code/core/Mage/Checkout/Model/Session.php index aee6c546a9e..03bbb43f886 100644 --- a/app/code/core/Mage/Checkout/Model/Session.php +++ b/app/code/core/Mage/Checkout/Model/Session.php @@ -76,8 +76,8 @@ * * @method string getSharedWishlist() * @method $this setSharedWishlist(string $value) - * @method int getSingleWishlistId() - * @method $this setSingleWishlistId(int $value) + * @method int|null getSingleWishlistId() + * @method $this setSingleWishlistId(int|null $value) * @method array getSteps() * @method $this setSteps(array $value) * diff --git a/app/code/core/Mage/Cms/controllers/IndexController.php b/app/code/core/Mage/Cms/controllers/IndexController.php index d4b5a485070..d93acb1b337 100644 --- a/app/code/core/Mage/Cms/controllers/IndexController.php +++ b/app/code/core/Mage/Cms/controllers/IndexController.php @@ -26,6 +26,7 @@ class Mage_Cms_IndexController extends Mage_Core_Controller_Front_Action * Renders CMS Home page * * @param string $coreRoute + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function indexAction($coreRoute = null) { @@ -53,6 +54,7 @@ public function defaultIndexAction() * Render CMS 404 Not found page * * @param string $coreRoute + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function noRouteAction($coreRoute = null) { diff --git a/app/code/core/Mage/ConfigurableSwatches/Model/Observer.php b/app/code/core/Mage/ConfigurableSwatches/Model/Observer.php index a8d6739ae51..80f9508900e 100644 --- a/app/code/core/Mage/ConfigurableSwatches/Model/Observer.php +++ b/app/code/core/Mage/ConfigurableSwatches/Model/Observer.php @@ -135,6 +135,7 @@ public function loadChildProductImagesOnMediaLoad(Varien_Event_Observer $observe /** * Convert a catalog layer block with the right templates * Observes: controller_action_layout_generate_blocks_after + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function convertLayerBlock(Varien_Event_Observer $observer) { diff --git a/app/code/core/Mage/Core/Block/Abstract.php b/app/code/core/Mage/Core/Block/Abstract.php index 2477a32543e..95be796a1d2 100644 --- a/app/code/core/Mage/Core/Block/Abstract.php +++ b/app/code/core/Mage/Core/Block/Abstract.php @@ -650,6 +650,7 @@ protected function _getChildHtml($name, $useCache = true) * * @param string $name * @param Mage_Core_Block_Abstract $child + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _beforeChildToHtml($name, $child) {} diff --git a/app/code/core/Mage/Core/Block/Html/Date.php b/app/code/core/Mage/Core/Block/Html/Date.php index b075ce37376..a1f203e4b8e 100644 --- a/app/code/core/Mage/Core/Block/Html/Date.php +++ b/app/code/core/Mage/Core/Block/Html/Date.php @@ -81,6 +81,7 @@ protected function _toHtml() /** * @param null $index deprecated * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getEscapedValue($index = null) { diff --git a/app/code/core/Mage/Core/Controller/Varien/Action.php b/app/code/core/Mage/Core/Controller/Varien/Action.php index 5c36b16ba40..02cb5b63556 100644 --- a/app/code/core/Mage/Core/Controller/Varien/Action.php +++ b/app/code/core/Mage/Core/Controller/Varien/Action.php @@ -116,6 +116,9 @@ abstract class Mage_Core_Controller_Varien_Action */ protected $_removeDefaultTitle = false; + /** + * @SuppressWarnings("PHPMD.UnusedFormalParameter") + */ public function __construct(Zend_Controller_Request_Abstract $request, Zend_Controller_Response_Abstract $response, array $invokeArgs = []) { $this->_request = $request; diff --git a/app/code/core/Mage/Core/Helper/Security.php b/app/code/core/Mage/Core/Helper/Security.php index d96289e398c..c26ea184019 100644 --- a/app/code/core/Mage/Core/Helper/Security.php +++ b/app/code/core/Mage/Core/Helper/Security.php @@ -30,6 +30,7 @@ class Mage_Core_Helper_Security * @param string $method * @param string[] $args * @throws Mage_Core_Exception + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function validateAgainstBlockMethodBlacklist(Mage_Core_Block_Abstract $block, $method, array $args) { diff --git a/app/code/core/Mage/Core/Model/App/Emulation.php b/app/code/core/Mage/Core/Model/App/Emulation.php index 29bcc2dd8f7..fbcb894c742 100644 --- a/app/code/core/Mage/Core/Model/App/Emulation.php +++ b/app/code/core/Mage/Core/Model/App/Emulation.php @@ -198,7 +198,6 @@ protected function _restoreInitialInlineTranslation($initialTranslateInline) /** * Restore design of the initial store * - * * @return $this */ protected function _restoreInitialDesign(array $initialDesign) diff --git a/app/code/core/Mage/Core/Model/Config.php b/app/code/core/Mage/Core/Model/Config.php index f88d34aa119..4746243acf5 100644 --- a/app/code/core/Mage/Core/Model/Config.php +++ b/app/code/core/Mage/Core/Model/Config.php @@ -877,12 +877,13 @@ protected function _isAllowedModule($moduleName) * * @param null $mergeConfig deprecated * @return $this|void + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _loadDeclaredModules($mergeConfig = null) { $moduleFiles = $this->_getDeclaredModuleFiles(); if (!$moduleFiles) { - return ; + return; } Varien_Profiler::start('config/load-modules-declaration'); @@ -1318,6 +1319,7 @@ public function loadEventObservers($area) * * @param array|string $args Module name if string * @return array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getPathVars($args = null) { diff --git a/app/code/core/Mage/Core/Model/Date.php b/app/code/core/Mage/Core/Model/Date.php index 9260e371875..f638adf7756 100644 --- a/app/code/core/Mage/Core/Model/Date.php +++ b/app/code/core/Mage/Core/Model/Date.php @@ -210,6 +210,7 @@ public function getGmtOffset($type = 'seconds') * @param int $second * @return bool * @deprecated since 1.1.7 + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function checkDateTime($year, $month, $day, $hour = 0, $minute = 0, $second = 0) { diff --git a/app/code/core/Mage/Core/Model/Email/Queue.php b/app/code/core/Mage/Core/Model/Email/Queue.php index 5d3a84f4a3d..b7a7ac87ba5 100644 --- a/app/code/core/Mage/Core/Model/Email/Queue.php +++ b/app/code/core/Mage/Core/Model/Email/Queue.php @@ -153,7 +153,6 @@ public function clearRecipients() /** * Set message recipients data * - * * @return $this */ public function setRecipients(array $recipients) diff --git a/app/code/core/Mage/Core/Model/File/Storage/Flag.php b/app/code/core/Mage/Core/Model/File/Storage/Flag.php index e371b02bda4..953eaa86e96 100644 --- a/app/code/core/Mage/Core/Model/File/Storage/Flag.php +++ b/app/code/core/Mage/Core/Model/File/Storage/Flag.php @@ -55,6 +55,7 @@ class Mage_Core_Model_File_Storage_Flag extends Mage_Core_Model_Flag * Pass error to flag * * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function passError(Exception $e) { diff --git a/app/code/core/Mage/Core/Model/Layout.php b/app/code/core/Mage/Core/Model/Layout.php index 576c5a32476..4f0347c8d01 100644 --- a/app/code/core/Mage/Core/Model/Layout.php +++ b/app/code/core/Mage/Core/Model/Layout.php @@ -358,7 +358,8 @@ protected function _generateAction($node, $parent) * @param string[] $args * @throws Mage_Core_Exception * @deprecated - * @see Mage_Core_Helper_Security::validateAgainstBlockMethodBlacklist() + * @see Mage_Core_Helper_Security::validateAgainstBlockMethodBlacklist( + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function validateAgainstBlacklist(Mage_Core_Block_Abstract $block, $method, array $args) { diff --git a/app/code/core/Mage/Core/Model/Layout/Element.php b/app/code/core/Mage/Core/Model/Layout/Element.php index c8acaf58eed..c74ff2822d1 100644 --- a/app/code/core/Mage/Core/Model/Layout/Element.php +++ b/app/code/core/Mage/Core/Model/Layout/Element.php @@ -77,6 +77,7 @@ public function getBlockName() /** * @param array $args * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function prepareBlock($args) { @@ -100,6 +101,7 @@ public function prepareBlock($args) /** * @param array $args * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function prepareReference($args) { @@ -109,6 +111,7 @@ public function prepareReference($args) /** * @param array $args * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function prepareAction($args) { @@ -121,6 +124,7 @@ public function prepareAction($args) /** * @param array $args * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function prepareActionArgument($args) { diff --git a/app/code/core/Mage/Core/Model/Observer.php b/app/code/core/Mage/Core/Model/Observer.php index 1ae6b8ae942..a98aeea5b01 100644 --- a/app/code/core/Mage/Core/Model/Observer.php +++ b/app/code/core/Mage/Core/Model/Observer.php @@ -26,6 +26,7 @@ class Mage_Core_Model_Observer * Check if synchronize process is finished and generate notification message * * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function addSynchronizeNotification(Varien_Event_Observer $observer) { @@ -84,6 +85,8 @@ public function addSynchronizeNotification(Varien_Event_Observer $observer) /** * Cron job method to clean old cache resources + * + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function cleanCache(Mage_Cron_Model_Schedule $schedule) { @@ -114,6 +117,7 @@ public function cleanCacheByTags(Varien_Event_Observer $observer) * * @throws Exception * @return Mage_Core_Model_Observer + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function secureVarProcessing(Varien_Event_Observer $observer) { diff --git a/app/code/core/Mage/Core/Model/Resource.php b/app/code/core/Mage/Core/Model/Resource.php index 11ef2212c3f..ba8683ff545 100644 --- a/app/code/core/Mage/Core/Model/Resource.php +++ b/app/code/core/Mage/Core/Model/Resource.php @@ -378,6 +378,7 @@ public function getAutoUpdate() /** * @param mixed $value * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function setAutoUpdate($value) { diff --git a/app/code/core/Mage/Core/Model/Resource/Db/Abstract.php b/app/code/core/Mage/Core/Model/Resource/Db/Abstract.php index de7998fe5b6..ffedc7bc7bc 100644 --- a/app/code/core/Mage/Core/Model/Resource/Db/Abstract.php +++ b/app/code/core/Mage/Core/Model/Resource/Db/Abstract.php @@ -396,6 +396,7 @@ public function load(Mage_Core_Model_Abstract $object, $value, $field = null) * @param Mage_Core_Model_Abstract $object * @return Varien_Db_Select * @throws Exception + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _getLoadSelect($field, $value, $object) { @@ -690,6 +691,7 @@ public function afterLoad(Mage_Core_Model_Abstract $object) * Perform actions after object load * * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _afterLoad(Mage_Core_Model_Abstract $object) { @@ -700,6 +702,7 @@ protected function _afterLoad(Mage_Core_Model_Abstract $object) * Perform actions before object save * * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _beforeSave(Mage_Core_Model_Abstract $object) { @@ -710,6 +713,7 @@ protected function _beforeSave(Mage_Core_Model_Abstract $object) * Perform actions after object save * * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _afterSave(Mage_Core_Model_Abstract $object) { @@ -720,6 +724,7 @@ protected function _afterSave(Mage_Core_Model_Abstract $object) * Perform actions before object delete * * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _beforeDelete(Mage_Core_Model_Abstract $object) { @@ -730,6 +735,7 @@ protected function _beforeDelete(Mage_Core_Model_Abstract $object) * Perform actions after object delete * * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _afterDelete(Mage_Core_Model_Abstract $object) { diff --git a/app/code/core/Mage/Core/Model/Resource/Db/Collection/Abstract.php b/app/code/core/Mage/Core/Model/Resource/Db/Collection/Abstract.php index f2c8f74a8a0..47010206ed1 100644 --- a/app/code/core/Mage/Core/Model/Resource/Db/Collection/Abstract.php +++ b/app/code/core/Mage/Core/Model/Resource/Db/Collection/Abstract.php @@ -423,6 +423,7 @@ public function setModel($model) * * @param array $args * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getModelName($args = []) { diff --git a/app/code/core/Mage/Core/Model/Resource/Email/Queue.php b/app/code/core/Mage/Core/Model/Resource/Email/Queue.php index 70340dc91fc..a13ec87ab74 100644 --- a/app/code/core/Mage/Core/Model/Resource/Email/Queue.php +++ b/app/code/core/Mage/Core/Model/Resource/Email/Queue.php @@ -62,7 +62,6 @@ protected function _beforeSave(Mage_Core_Model_Abstract $object) /** * Check if email was added to queue for requested recipients * - * * @return bool */ public function wasEmailQueued(Mage_Core_Model_Email_Queue $queue) diff --git a/app/code/core/Mage/Core/Model/Resource/Helper/Mysql4.php b/app/code/core/Mage/Core/Model/Resource/Helper/Mysql4.php index dd134f40aa9..589ea83db51 100644 --- a/app/code/core/Mage/Core/Model/Resource/Helper/Mysql4.php +++ b/app/code/core/Mage/Core/Model/Resource/Helper/Mysql4.php @@ -39,6 +39,7 @@ public function castField($field) * @param string $groupAliasName OPTIONAL * @param string $orderBy OPTIONAL * @return Zend_Db_Expr + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function prepareColumn($column, $groupAliasName = null, $orderBy = null) { diff --git a/app/code/core/Mage/Core/Model/Resource/Session.php b/app/code/core/Mage/Core/Model/Resource/Session.php index a125cedf358..6bf260656ba 100644 --- a/app/code/core/Mage/Core/Model/Resource/Session.php +++ b/app/code/core/Mage/Core/Model/Resource/Session.php @@ -162,6 +162,7 @@ public static function setStaticSaveHandler() * @param string $savePath ignored * @param string $sessName ignored * @return bool + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ #[\ReturnTypeWillChange] public function open($savePath, $sessName) @@ -260,6 +261,7 @@ public function destroy($sessId) * @param int $sessMaxLifeTime ignored * @return bool * @SuppressWarnings("PHPMD.ShortMethodName") + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ #[\ReturnTypeWillChange] public function gc($sessMaxLifeTime) diff --git a/app/code/core/Mage/Core/Model/Resource/Setup.php b/app/code/core/Mage/Core/Model/Resource/Setup.php index 96a7dd1d32a..1ec44e4d8ff 100644 --- a/app/code/core/Mage/Core/Model/Resource/Setup.php +++ b/app/code/core/Mage/Core/Model/Resource/Setup.php @@ -773,6 +773,7 @@ public function deleteTableRow($table, $idField, $id, $parentField = null, $pare * @param string $parentField * @param string|int $parentId * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function updateTableRow($table, $idField, $id, $field, $value = null, $parentField = null, $parentId = 0) { @@ -853,6 +854,7 @@ public function tableExists($table) * @param string $default * @return $this * @deprecated since 1.4.0.1 + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function addConfigField($path, $label, array $data = [], $default = null) { @@ -868,6 +870,7 @@ public function addConfigField($path, $label, array $data = [], $default = null) * @param int $scopeId * @param int $inherit * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function setConfigData($path, $value, $scope = 'default', $scopeId = 0, $inherit = 0) { diff --git a/app/code/core/Mage/Core/Model/Resource/Setup/Query/Modifier.php b/app/code/core/Mage/Core/Model/Resource/Setup/Query/Modifier.php index 79b181c519a..5297aa74a94 100644 --- a/app/code/core/Mage/Core/Model/Resource/Setup/Query/Modifier.php +++ b/app/code/core/Mage/Core/Model/Resource/Setup/Query/Modifier.php @@ -255,6 +255,7 @@ protected function _prepareIdentifier($identifier) * @param string $sql * @param array $bind * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function processQuery(&$sql, &$bind) { diff --git a/app/code/core/Mage/Core/Model/Translate.php b/app/code/core/Mage/Core/Model/Translate.php index 35fda12c0cf..e1c5436fe15 100644 --- a/app/code/core/Mage/Core/Model/Translate.php +++ b/app/code/core/Mage/Core/Model/Translate.php @@ -291,6 +291,7 @@ protected function _loadDbTranslation($forceReload = false) * @param string $module * @param string $fileName * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _getModuleFilePath($module, $fileName) { diff --git a/app/code/core/Mage/Core/Model/Translate/Inline.php b/app/code/core/Mage/Core/Model/Translate/Inline.php index d9a98071b4c..ae15f3859d8 100644 --- a/app/code/core/Mage/Core/Model/Translate/Inline.php +++ b/app/code/core/Mage/Core/Model/Translate/Inline.php @@ -288,6 +288,7 @@ protected function _escape($string) * @param array $matches * @param array $options * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _getAttributeLocation($matches, $options) { @@ -300,6 +301,7 @@ protected function _getAttributeLocation($matches, $options) * @param array $matches * @param array $options * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _getTagLocation($matches, $options) { @@ -447,6 +449,7 @@ protected function _applySimpleTagsFormat($tagHtml, $tagName, $trArr) * @param array $tagsList * @param string|array $formatCallback * @param bool $isNeedTranslateAttributes + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _translateTags(&$content, $tagsList, $formatCallback, $isNeedTranslateAttributes) { diff --git a/app/code/core/Mage/Core/functions.php b/app/code/core/Mage/Core/functions.php index 47698522792..98fcaa0fec3 100644 --- a/app/code/core/Mage/Core/functions.php +++ b/app/code/core/Mage/Core/functions.php @@ -259,6 +259,7 @@ function mageDelTree($path) * @param string $enclosure * @param string $escape * @return array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ function mageParseCsv($string, $delimiter = ',', $enclosure = '"', $escape = '\\') { diff --git a/app/code/core/Mage/Cron/Model/Observer.php b/app/code/core/Mage/Cron/Model/Observer.php index 66b374e1bd6..b5dbc62b6a3 100644 --- a/app/code/core/Mage/Cron/Model/Observer.php +++ b/app/code/core/Mage/Cron/Model/Observer.php @@ -42,6 +42,7 @@ class Mage_Cron_Model_Observer * Cleanup tasks schedule * * @param Varien_Event_Observer $observer + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function dispatch($observer) { @@ -69,6 +70,7 @@ public function dispatch($observer) * Process cron queue for tasks marked as always * * @param Varien_Event_Observer $observer + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function dispatchAlways($observer) { diff --git a/app/code/core/Mage/Customer/Model/Api2/Customer/Rest/Customer/V1.php b/app/code/core/Mage/Customer/Model/Api2/Customer/Rest/Customer/V1.php index 775912f3886..f85c75224ba 100644 --- a/app/code/core/Mage/Customer/Model/Api2/Customer/Rest/Customer/V1.php +++ b/app/code/core/Mage/Customer/Model/Api2/Customer/Rest/Customer/V1.php @@ -74,8 +74,9 @@ protected function _update(array $data) * Update customers * * @throws Mage_Api2_Exception + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ - protected function _multiUpdate(array $data) + protected function _multiUpdate(array $filteredData) { $this->_critical(self::RESOURCE_METHOD_NOT_ALLOWED, Mage_Api2_Model_Server::HTTP_FORBIDDEN); } diff --git a/app/code/core/Mage/Customer/Model/Customer/Attribute/Source/Group.php b/app/code/core/Mage/Customer/Model/Customer/Attribute/Source/Group.php index a4b71231008..12c96d0d31b 100644 --- a/app/code/core/Mage/Customer/Model/Customer/Attribute/Source/Group.php +++ b/app/code/core/Mage/Customer/Model/Customer/Attribute/Source/Group.php @@ -28,6 +28,7 @@ class Mage_Customer_Model_Customer_Attribute_Source_Group extends Mage_Eav_Model * @param bool $withEmpty Argument has no effect, included for PHP 7.2 method signature compatibility * @param bool $defaultValues Argument has no effect, included for PHP 7.2 method signature compatibility * @return array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getAllOptions($withEmpty = true, $defaultValues = false) { diff --git a/app/code/core/Mage/Customer/Model/Customer/Attribute/Source/Store.php b/app/code/core/Mage/Customer/Model/Customer/Attribute/Source/Store.php index b1ab9d20e79..b8be1aab1cb 100644 --- a/app/code/core/Mage/Customer/Model/Customer/Attribute/Source/Store.php +++ b/app/code/core/Mage/Customer/Model/Customer/Attribute/Source/Store.php @@ -28,6 +28,7 @@ class Mage_Customer_Model_Customer_Attribute_Source_Store extends Mage_Eav_Model * @param bool $withEmpty Argument has no effect, included for PHP 7.2 method signature compatibility * @param bool $defaultValues Argument has no effect, included for PHP 7.2 method signature compatibility * @return array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getAllOptions($withEmpty = true, $defaultValues = false) { diff --git a/app/code/core/Mage/Customer/Model/Customer/Attribute/Source/Website.php b/app/code/core/Mage/Customer/Model/Customer/Attribute/Source/Website.php index 016d9c12fa4..7e10f7d1046 100644 --- a/app/code/core/Mage/Customer/Model/Customer/Attribute/Source/Website.php +++ b/app/code/core/Mage/Customer/Model/Customer/Attribute/Source/Website.php @@ -28,6 +28,7 @@ class Mage_Customer_Model_Customer_Attribute_Source_Website extends Mage_Eav_Mod * @param bool $withEmpty Argument has no effect, included for PHP 7.2 method signature compatibility * @param bool $defaultValues Argument has no effect, included for PHP 7.2 method signature compatibility * @return array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getAllOptions($withEmpty = true, $defaultValues = false) { diff --git a/app/code/core/Mage/Customer/Model/Resource/Address.php b/app/code/core/Mage/Customer/Model/Resource/Address.php index ab28aee7274..9a7ca1d5707 100644 --- a/app/code/core/Mage/Customer/Model/Resource/Address.php +++ b/app/code/core/Mage/Customer/Model/Resource/Address.php @@ -75,6 +75,7 @@ public function getCustomerId($object) * @param Mage_Customer_Model_Address $object * @param int $id * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function setCustomerId($object, $id) { diff --git a/app/code/core/Mage/Customer/Model/Resource/Address/Attribute/Source/Country.php b/app/code/core/Mage/Customer/Model/Resource/Address/Attribute/Source/Country.php index fea0c374105..7d8951861bf 100644 --- a/app/code/core/Mage/Customer/Model/Resource/Address/Attribute/Source/Country.php +++ b/app/code/core/Mage/Customer/Model/Resource/Address/Attribute/Source/Country.php @@ -28,6 +28,7 @@ class Mage_Customer_Model_Resource_Address_Attribute_Source_Country extends Mage * @param bool $withEmpty Argument has no effect, included for PHP 7.2 method signature compatibility * @param bool $defaultValues Argument has no effect, included for PHP 7.2 method signature compatibility * @return array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getAllOptions($withEmpty = true, $defaultValues = false) { diff --git a/app/code/core/Mage/Customer/Model/Resource/Address/Attribute/Source/Region.php b/app/code/core/Mage/Customer/Model/Resource/Address/Attribute/Source/Region.php index 4986acd18ad..a8fa5335fd2 100644 --- a/app/code/core/Mage/Customer/Model/Resource/Address/Attribute/Source/Region.php +++ b/app/code/core/Mage/Customer/Model/Resource/Address/Attribute/Source/Region.php @@ -28,6 +28,7 @@ class Mage_Customer_Model_Resource_Address_Attribute_Source_Region extends Mage_ * @param bool $withEmpty Argument has no effect, included for PHP 7.2 method signature compatibility * @param bool $defaultValues Argument has no effect, included for PHP 7.2 method signature compatibility * @return array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getAllOptions($withEmpty = true, $defaultValues = false) { diff --git a/app/code/core/Mage/Customer/Model/Resource/Customer.php b/app/code/core/Mage/Customer/Model/Resource/Customer.php index 05afecc9299..b13857f8546 100644 --- a/app/code/core/Mage/Customer/Model/Resource/Customer.php +++ b/app/code/core/Mage/Customer/Model/Resource/Customer.php @@ -102,12 +102,13 @@ protected function _beforeSave(Varien_Object $customer) /** * Save customer addresses and set default addresses in attributes backend * + * @param Mage_Customer_Model_Customer $object * @return Mage_Eav_Model_Entity_Abstract */ - protected function _afterSave(Varien_Object $customer) + protected function _afterSave(Varien_Object $object) { - $this->_saveAddresses($customer); - return parent::_afterSave($customer); + $this->_saveAddresses($object); + return parent::_afterSave($object); } /** @@ -189,6 +190,7 @@ protected function _getLoadRowSelect($object, $rowId) * @param string $email * @param bool $testOnly * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function loadByEmail(Mage_Customer_Model_Customer $customer, $email, $testOnly = false) { diff --git a/app/code/core/Mage/Dataflow/Model/Convert/Profile/Abstract.php b/app/code/core/Mage/Dataflow/Model/Convert/Profile/Abstract.php index c8ff4449861..d94d6bdb6f8 100644 --- a/app/code/core/Mage/Dataflow/Model/Convert/Profile/Abstract.php +++ b/app/code/core/Mage/Dataflow/Model/Convert/Profile/Abstract.php @@ -124,7 +124,7 @@ public function run() $dfe = new Mage_Dataflow_Model_Convert_Exception($e->getMessage()); $dfe->setLevel(Mage_Dataflow_Model_Convert_Exception::FATAL); $this->addException($dfe); - return ; + return; } } return $this; diff --git a/app/code/core/Mage/Dataflow/Model/Mysql4/Catalogold.php b/app/code/core/Mage/Dataflow/Model/Mysql4/Catalogold.php index f46e76841ef..de3f5585db4 100644 --- a/app/code/core/Mage/Dataflow/Model/Mysql4/Catalogold.php +++ b/app/code/core/Mage/Dataflow/Model/Mysql4/Catalogold.php @@ -233,11 +233,17 @@ public function exportImageGallery() return []; } + /** + * @SuppressWarnings("PHPMD.UnusedFormalParameter") + */ public function getProductAttributeOption($attribute, $value) { #$attribute = Mage::get } + /** + * @SuppressWarnings("PHPMD.UnusedFormalParameter") + */ public function importProducts(array $data) { /* diff --git a/app/code/core/Mage/Directory/Model/Currency.php b/app/code/core/Mage/Directory/Model/Currency.php index a67e48e7dcb..c0be65fbf6f 100644 --- a/app/code/core/Mage/Directory/Model/Currency.php +++ b/app/code/core/Mage/Directory/Model/Currency.php @@ -106,6 +106,7 @@ public function setRates(array $rates) * @param string $id * @param string $field * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function load($id, $field = null) { diff --git a/app/code/core/Mage/Directory/Model/Resource/Currency.php b/app/code/core/Mage/Directory/Model/Resource/Currency.php index e6b6cf855d4..831e4c4e5ea 100644 --- a/app/code/core/Mage/Directory/Model/Resource/Currency.php +++ b/app/code/core/Mage/Directory/Model/Resource/Currency.php @@ -166,8 +166,8 @@ public function saveRates($rates) * * @param Mage_Directory_Model_Currency $model * @param string $path - * * @return array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getConfigCurrencies($model, $path) { diff --git a/app/code/core/Mage/Downloadable/Model/Product/Type.php b/app/code/core/Mage/Downloadable/Model/Product/Type.php index f4aeab5a6af..9e667db7c9c 100644 --- a/app/code/core/Mage/Downloadable/Model/Product/Type.php +++ b/app/code/core/Mage/Downloadable/Model/Product/Type.php @@ -449,6 +449,7 @@ public function isSalable($product = null) * @param Mage_Catalog_Model_Product $product * @param Varien_Object $buyRequest * @return array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function processBuyRequest($product, $buyRequest) { diff --git a/app/code/core/Mage/Eav/Model/Config.php b/app/code/core/Mage/Eav/Model/Config.php index 7fa34d1c60a..e29f4c1735b 100644 --- a/app/code/core/Mage/Eav/Model/Config.php +++ b/app/code/core/Mage/Eav/Model/Config.php @@ -643,6 +643,7 @@ public function getCollectionAttribute($entityType, $attribute) * @deprecated No longer required to preload only collection attributes explicitly * Prepare attributes for usage in EAV collection * + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function loadCollectionAttributes($entityType, $attributes) { @@ -653,6 +654,7 @@ public function loadCollectionAttributes($entityType, $attributes) * @param string|Mage_Eav_Model_Entity_Type $entityType * @return $this * @deprecated No longer required. All attribute data is cached on-access. + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function importAttributesData($entityType, array $attributes) { diff --git a/app/code/core/Mage/Eav/Model/Entity/Abstract.php b/app/code/core/Mage/Eav/Model/Entity/Abstract.php index 2afd0c8245f..3cefef3e7b4 100644 --- a/app/code/core/Mage/Eav/Model/Entity/Abstract.php +++ b/app/code/core/Mage/Eav/Model/Entity/Abstract.php @@ -572,7 +572,8 @@ public function attributesCompare($attribute1, $attribute2) * * @param Varien_Object $object * @param Mage_Eav_Model_Entity_Attribute_Abstract $attribute - * @return bool + * @return bool + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _isApplicableAttribute($object, $attribute) { @@ -654,6 +655,7 @@ public function walkAttributes($partMethod, array $args = []) * @param string $method * @param array $args array of arguments * @return bool + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _isCallableAttributeInstance($instance, $method, $args) { @@ -1002,6 +1004,7 @@ protected function _prepareLoadSelect(array $selects) * @param Varien_Object $object * @param mixed $rowId * @return Zend_Db_Select + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _getLoadRowSelect($object, $rowId) { @@ -1214,6 +1217,7 @@ protected function _collectSaveData($newObject) * * @param mixed $v New value of the attribute. Can be used in subclasses. * @return bool + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _canUpdateAttribute(Mage_Eav_Model_Entity_Attribute_Abstract $attribute, $v, array &$origData) { @@ -1386,6 +1390,7 @@ protected function _insertAttribute($object, $attribute, $value) * @param mixed $valueId * @param mixed $value * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _updateAttribute($object, $attribute, $valueId, $value) { @@ -1480,6 +1485,7 @@ protected function _prepareValueForSave($value, Mage_Eav_Model_Entity_Attribute_ * @param string $table * @param array $info * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _deleteAttributes($object, $table, $info) { diff --git a/app/code/core/Mage/Eav/Model/Entity/Attribute/Source/Abstract.php b/app/code/core/Mage/Eav/Model/Entity/Attribute/Source/Abstract.php index 638e49af429..5d47bed7f29 100644 --- a/app/code/core/Mage/Eav/Model/Entity/Attribute/Source/Abstract.php +++ b/app/code/core/Mage/Eav/Model/Entity/Attribute/Source/Abstract.php @@ -108,6 +108,7 @@ public function getOptionId($value) * @param Mage_Eav_Model_Entity_Collection_Abstract $collection * @param string $dir direction * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function addValueSortToCollection($collection, $dir = Varien_Data_Collection::SORT_ORDER_DESC) { @@ -139,6 +140,7 @@ public function getFlatIndexes() * * @param int $store * @return Varien_Db_Select|null + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getFlatUpdateSelect($store) { diff --git a/app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php b/app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php index 5e2b41da7e2..048b6c09a96 100644 --- a/app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php +++ b/app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php @@ -106,6 +106,7 @@ abstract class Mage_Eav_Model_Entity_Collection_Abstract extends Varien_Data_Col * Collection constructor * * @param Mage_Core_Model_Resource_Abstract $resource + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function __construct($resource = null) { @@ -1080,6 +1081,7 @@ public function _loadEntities($printQuery = false, $logQuery = false) * @return $this * @throws Mage_Core_Exception * @throws Mage_Eav_Exception + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function _loadAttributes($printQuery = false, $logQuery = false) { diff --git a/app/code/core/Mage/Eav/Model/Resource/Helper/Mysql4.php b/app/code/core/Mage/Eav/Model/Resource/Helper/Mysql4.php index 8439b7c9849..1b849277c81 100644 --- a/app/code/core/Mage/Eav/Model/Resource/Helper/Mysql4.php +++ b/app/code/core/Mage/Eav/Model/Resource/Helper/Mysql4.php @@ -49,6 +49,7 @@ class Mage_Eav_Model_Resource_Helper_Mysql4 extends Mage_Core_Model_Resource_Hel * @param string $tableAlias * @param string $eavType * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function attributeSelectFields($tableAlias, $eavType) { @@ -85,6 +86,7 @@ public function getDdlTypeByColumnType($columnType) * @param string $value * @param string $eavType * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function prepareEavAttributeValue($value, $eavType) { diff --git a/app/code/core/Mage/GoogleAnalytics/Block/Ga.php b/app/code/core/Mage/GoogleAnalytics/Block/Ga.php index 336fee12a96..6328e7bede3 100644 --- a/app/code/core/Mage/GoogleAnalytics/Block/Ga.php +++ b/app/code/core/Mage/GoogleAnalytics/Block/Ga.php @@ -87,6 +87,7 @@ protected function _getPageTrackingCodeAnalytics4($accountId) * @param string $accountId * @return string * @deprecated + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _getPageTrackingCodeUniversal($accountId) { @@ -102,6 +103,7 @@ protected function _getPageTrackingCodeUniversal($accountId) * @param string $accountId * @return string * @deprecated + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _getPageTrackingCodeAnalytics($accountId) { diff --git a/app/code/core/Mage/GoogleAnalytics/Helper/Data.php b/app/code/core/Mage/GoogleAnalytics/Helper/Data.php index ed7be17d7d5..6d885caebbb 100644 --- a/app/code/core/Mage/GoogleAnalytics/Helper/Data.php +++ b/app/code/core/Mage/GoogleAnalytics/Helper/Data.php @@ -74,6 +74,7 @@ public function isGoogleAnalyticsAvailable($store = null) * @param null|string|bool|int|Mage_Core_Model_Store $store $store * @return bool * @deprecated + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function isIpAnonymizationEnabled($store = null) { @@ -106,8 +107,9 @@ public function getGoogleTagManagerContainerId($store = null) * Returns true if should use Google Universal Analytics * * @param string $store - * @return bool + * @return false * @deprecated + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function isUseUniversalAnalytics($store = null) { diff --git a/app/code/core/Mage/GoogleCheckout/Model/Payment.php b/app/code/core/Mage/GoogleCheckout/Model/Payment.php index 6dad5e09f83..b15d38c3770 100644 --- a/app/code/core/Mage/GoogleCheckout/Model/Payment.php +++ b/app/code/core/Mage/GoogleCheckout/Model/Payment.php @@ -51,6 +51,7 @@ public function getOrderPlaceRedirectUrl() * * @param float $amount * @return void + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function authorize(Varien_Object $payment, $amount) { @@ -63,6 +64,7 @@ public function authorize(Varien_Object $payment, $amount) * @param float $amount * @throws Exception * @return void + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function capture(Varien_Object $payment, $amount) { @@ -75,6 +77,7 @@ public function capture(Varien_Object $payment, $amount) * @param float $amount * @throws Exception * @return void + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function refund(Varien_Object $payment, $amount) { @@ -84,6 +87,7 @@ public function refund(Varien_Object $payment, $amount) /** * @throws Exception * @return void + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function void(Varien_Object $payment) { @@ -95,6 +99,7 @@ public function void(Varien_Object $payment) * * @throws Exception * @return void + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function cancel(Varien_Object $payment) { @@ -106,8 +111,8 @@ public function cancel(Varien_Object $payment) * * @param string $field * @param int|string|null|Mage_Core_Model_Store $storeId - * * @return null + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getConfigData($field, $storeId = null) { @@ -117,7 +122,8 @@ public function getConfigData($field, $storeId = null) /** * Check void availability * - * @return bool + * @return false + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function canVoid(Varien_Object $payment) { diff --git a/app/code/core/Mage/ImportExport/Block/Adminhtml/Export/Filter.php b/app/code/core/Mage/ImportExport/Block/Adminhtml/Export/Filter.php index 412cc9d7c7b..d0e82e7c288 100644 --- a/app/code/core/Mage/ImportExport/Block/Adminhtml/Export/Filter.php +++ b/app/code/core/Mage/ImportExport/Block/Adminhtml/Export/Filter.php @@ -375,6 +375,7 @@ protected function _prepareColumns() * @param mixed $value * @param bool $isExport * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function decorateFilter($value, Mage_Eav_Model_Entity_Attribute $row, Varien_Object $column, $isExport) { @@ -429,6 +430,7 @@ public function getFilterElementName($attributeCode) * * @param Mage_Catalog_Model_Resource_Eav_Attribute $row * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getRowUrl($row) { diff --git a/app/code/core/Mage/ImportExport/Model/Import/Adapter/Abstract.php b/app/code/core/Mage/ImportExport/Model/Import/Adapter/Abstract.php index c1836f2d07f..6255537d35e 100644 --- a/app/code/core/Mage/ImportExport/Model/Import/Adapter/Abstract.php +++ b/app/code/core/Mage/ImportExport/Model/Import/Adapter/Abstract.php @@ -145,6 +145,7 @@ public function key() * Seeks to a position. * * @param int $position The position to seek to. + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ #[\ReturnTypeWillChange] public function seek($position) diff --git a/app/code/core/Mage/ImportExport/Model/Import/Entity/Abstract.php b/app/code/core/Mage/ImportExport/Model/Import/Entity/Abstract.php index 8098e525a24..7d5d35a6d88 100644 --- a/app/code/core/Mage/ImportExport/Model/Import/Entity/Abstract.php +++ b/app/code/core/Mage/ImportExport/Model/Import/Entity/Abstract.php @@ -218,6 +218,7 @@ abstract protected function _importData(); * Returns boolean TRUE if row scope is default (fundamental) scope. * * @return true + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _isRowScopeDefault(array $rowData) { diff --git a/app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php b/app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php index 302a3a3d961..ff7aed757a5 100644 --- a/app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php +++ b/app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php @@ -2180,6 +2180,7 @@ public function validateRow(array $rowData, $rowNum) * @param array $rowData * @param int $rowNum * @param string|false|null $sku + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _validate($rowData, $rowNum, $sku) { diff --git a/app/code/core/Mage/ImportExport/Model/Import/Entity/Product/Type/Abstract.php b/app/code/core/Mage/ImportExport/Model/Import/Entity/Product/Type/Abstract.php index 7f384c62260..cfc73110b19 100644 --- a/app/code/core/Mage/ImportExport/Model/Import/Entity/Product/Type/Abstract.php +++ b/app/code/core/Mage/ImportExport/Model/Import/Entity/Product/Type/Abstract.php @@ -190,6 +190,7 @@ protected function _initAttributes() * * @param string $attrCode * @return bool + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _isAttributeRequiredCheckNeeded($attrCode) { @@ -201,6 +202,7 @@ protected function _isAttributeRequiredCheckNeeded($attrCode) * * @param int $rowNum * @return bool + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _isParticularAttributesValid(array $rowData, $rowNum) { diff --git a/app/code/core/Mage/ImportExport/Model/Product/Attribute/Backend/Urlkey.php b/app/code/core/Mage/ImportExport/Model/Product/Attribute/Backend/Urlkey.php index 280ea1c6da3..1a5c5ae5b9f 100644 --- a/app/code/core/Mage/ImportExport/Model/Product/Attribute/Backend/Urlkey.php +++ b/app/code/core/Mage/ImportExport/Model/Product/Attribute/Backend/Urlkey.php @@ -27,6 +27,7 @@ class Mage_ImportExport_Model_Product_Attribute_Backend_Urlkey extends Mage_Cata * * @param Mage_Catalog_Model_Product $object * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _validateUrlKey($object) { diff --git a/app/code/core/Mage/Index/Block/Adminhtml/Process/Edit/Tab/Main.php b/app/code/core/Mage/Index/Block/Adminhtml/Process/Edit/Tab/Main.php index a1f16303c33..8ed0db16d0e 100644 --- a/app/code/core/Mage/Index/Block/Adminhtml/Process/Edit/Tab/Main.php +++ b/app/code/core/Mage/Index/Block/Adminhtml/Process/Edit/Tab/Main.php @@ -105,6 +105,7 @@ public function isHidden() * * @param string $action * @return bool + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _isAllowedAction($action) { diff --git a/app/code/core/Mage/Index/Block/Adminhtml/Process/Grid.php b/app/code/core/Mage/Index/Block/Adminhtml/Process/Grid.php index 9daee9c0fbd..bda690891a6 100644 --- a/app/code/core/Mage/Index/Block/Adminhtml/Process/Grid.php +++ b/app/code/core/Mage/Index/Block/Adminhtml/Process/Grid.php @@ -175,8 +175,8 @@ protected function _prepareColumns() * @param Mage_Index_Model_Process $row * @param Mage_Adminhtml_Block_Widget_Grid_Column $column * @param bool $isExport - * * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function decorateStatus($value, $row, $column, $isExport) { @@ -202,8 +202,8 @@ public function decorateStatus($value, $row, $column, $isExport) * @param Mage_Index_Model_Process $row * @param Mage_Adminhtml_Block_Widget_Grid_Column $column * @param bool $isExport - * * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function decorateUpdateRequired($value, $row, $column, $isExport) { @@ -226,8 +226,8 @@ public function decorateUpdateRequired($value, $row, $column, $isExport) * @param Mage_Index_Model_Process $row * @param Mage_Adminhtml_Block_Widget_Grid_Column $column * @param bool $isExport - * * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function decorateDate($value, $row, $column, $isExport) { diff --git a/app/code/core/Mage/Index/Model/Event.php b/app/code/core/Mage/Index/Model/Event.php index 7e6c3a597ee..9546f9d0a1e 100644 --- a/app/code/core/Mage/Index/Model/Event.php +++ b/app/code/core/Mage/Index/Model/Event.php @@ -231,6 +231,7 @@ public function cleanNewData() * @deprecated since 1.6.2.0 * @param bool $useNamespace * @return array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getOldData($useNamespace = true) { @@ -264,6 +265,7 @@ public function getNewData($useNamespace = true) * @param null|mixed $value * @return $this * @deprecated since 1.6.2.0 + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function addOldData($key, $value = null) { diff --git a/app/code/core/Mage/Index/Model/Lock.php b/app/code/core/Mage/Index/Model/Lock.php index 64b00178600..36457905049 100644 --- a/app/code/core/Mage/Index/Model/Lock.php +++ b/app/code/core/Mage/Index/Model/Lock.php @@ -152,6 +152,7 @@ protected function _setLockFile($lockName, $block = false) * @param string $lockName * @param bool $block * @return bool + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _setLockDb($lockName, $block = false) { diff --git a/app/code/core/Mage/Index/Model/Resource/Abstract.php b/app/code/core/Mage/Index/Model/Resource/Abstract.php index b9a9cdfc762..dff88b2e66e 100644 --- a/app/code/core/Mage/Index/Model/Resource/Abstract.php +++ b/app/code/core/Mage/Index/Model/Resource/Abstract.php @@ -114,6 +114,7 @@ public function syncData() * @deprecated since 1.5.0.0 * @param bool $asOriginal * @return Mage_Index_Model_Resource_Abstract + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function cloneIndexTable($asOriginal = false) { diff --git a/app/code/core/Mage/Index/Model/Resource/Process.php b/app/code/core/Mage/Index/Model/Resource/Process.php index a58c96f4295..e13bf073b9e 100644 --- a/app/code/core/Mage/Index/Model/Resource/Process.php +++ b/app/code/core/Mage/Index/Model/Resource/Process.php @@ -94,7 +94,6 @@ public function failProcess(Mage_Index_Model_Process $process) /** * Update process status field * - * * @param Mage_Index_Model_Process $process * @param string $status * @return $this diff --git a/app/code/core/Mage/Install/Model/Installer/Filesystem.php b/app/code/core/Mage/Install/Model/Installer/Filesystem.php index 2ca93944327..48b55483f56 100644 --- a/app/code/core/Mage/Install/Model/Installer/Filesystem.php +++ b/app/code/core/Mage/Install/Model/Installer/Filesystem.php @@ -76,6 +76,7 @@ protected function _checkFilesystem() * @param bool $existence * @param string $mode * @return bool + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _checkPath($path, $recursive, $existence, $mode) { diff --git a/app/code/core/Mage/Log/Model/Aggregation.php b/app/code/core/Mage/Log/Model/Aggregation.php index 5a70b23d44c..e3df5ea60fe 100644 --- a/app/code/core/Mage/Log/Model/Aggregation.php +++ b/app/code/core/Mage/Log/Model/Aggregation.php @@ -145,6 +145,7 @@ public function getLastRecordDate() * @param string|int $in * @param null $offset deprecated * @return false|string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ private function _date($in, $offset = null) { @@ -159,6 +160,7 @@ private function _date($in, $offset = null) * @param string|int $in * @param null $offset deprecated * @return false|int + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ private function _timestamp($in, $offset = null) { diff --git a/app/code/core/Mage/Media/Model/File/Image.php b/app/code/core/Mage/Media/Model/File/Image.php index 1f685188738..1941bd9a013 100644 --- a/app/code/core/Mage/Media/Model/File/Image.php +++ b/app/code/core/Mage/Media/Model/File/Image.php @@ -50,6 +50,7 @@ protected function _getWriteAdapter() * @param mixed $file * @param mixed|null $field * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function load(Mage_Media_Model_Image $object, $file, $field = null) { @@ -59,6 +60,7 @@ public function load(Mage_Media_Model_Image $object, $file, $field = null) /** * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function save(Mage_Media_Model_Image $object) { @@ -68,6 +70,7 @@ public function save(Mage_Media_Model_Image $object) /** * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function delete(Mage_Media_Model_Image $object) { @@ -149,6 +152,7 @@ public function resize(Mage_Media_Model_Image $object) * Add watermark for image * * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function watermark(Mage_Media_Model_Image $object) { diff --git a/app/code/core/Mage/Newsletter/Model/Observer.php b/app/code/core/Mage/Newsletter/Model/Observer.php index 46465d36175..c4c55d405e7 100644 --- a/app/code/core/Mage/Newsletter/Model/Observer.php +++ b/app/code/core/Mage/Newsletter/Model/Observer.php @@ -51,6 +51,7 @@ public function customerDeleted(Varien_Event_Observer $observer) /** * @param Varien_Event_Observer $schedule + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function scheduledSend($schedule) { diff --git a/app/code/core/Mage/Newsletter/Model/Queue.php b/app/code/core/Mage/Newsletter/Model/Queue.php index b6ec07909d6..9a392a03fdf 100644 --- a/app/code/core/Mage/Newsletter/Model/Queue.php +++ b/app/code/core/Mage/Newsletter/Model/Queue.php @@ -157,8 +157,9 @@ public function setQueueStartAtByString($startAt) /** * Send messages to subscribers for this queue * - * @param int $count + * @param int $count * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function sendPerSubscriber($count = 20, array $additionalVariables = []) { diff --git a/app/code/core/Mage/Oauth/Block/Adminhtml/Oauth/AuthorizedTokens/Grid.php b/app/code/core/Mage/Oauth/Block/Adminhtml/Oauth/AuthorizedTokens/Grid.php index 20531051527..2327e9aa146 100644 --- a/app/code/core/Mage/Oauth/Block/Adminhtml/Oauth/AuthorizedTokens/Grid.php +++ b/app/code/core/Mage/Oauth/Block/Adminhtml/Oauth/AuthorizedTokens/Grid.php @@ -168,6 +168,7 @@ protected function _prepareMassaction() * @param Mage_Adminhtml_Block_Widget_Grid_Column $column * @param bool $isExport * @return mixed + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function decorateUserType($value, $row, $column, $isExport) { @@ -182,7 +183,8 @@ public function decorateUserType($value, $row, $column, $isExport) * @param Mage_Oauth_Model_Token $row * @param Mage_Adminhtml_Block_Widget_Grid_Column $column * @param bool $isExport - * @return mixed + * @return int + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function decorateUserId($value, $row, $column, $isExport) { diff --git a/app/code/core/Mage/Oauth/Model/Observer.php b/app/code/core/Mage/Oauth/Model/Observer.php index 802c7576e14..22112acb944 100644 --- a/app/code/core/Mage/Oauth/Model/Observer.php +++ b/app/code/core/Mage/Oauth/Model/Observer.php @@ -36,6 +36,7 @@ protected function _getOauthToken() * Redirect customer to callback page after login * * @SuppressWarnings("PHPMD.ExitExpression") + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function afterCustomerLogin(Varien_Event_Observer $observer) { @@ -54,6 +55,7 @@ public function afterCustomerLogin(Varien_Event_Observer $observer) * Redirect admin to authorize controller after login success * * @SuppressWarnings("PHPMD.ExitExpression") + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function afterAdminLogin(Varien_Event_Observer $observer) { diff --git a/app/code/core/Mage/Oauth/Model/Token.php b/app/code/core/Mage/Oauth/Model/Token.php index 129c4c67e4c..00ca49b5c40 100644 --- a/app/code/core/Mage/Oauth/Model/Token.php +++ b/app/code/core/Mage/Oauth/Model/Token.php @@ -196,6 +196,7 @@ public function getUserType() * * @param string $format * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function toString($format = '') { diff --git a/app/code/core/Mage/Page/Block/Html/Head.php b/app/code/core/Mage/Page/Block/Html/Head.php index 79e4b285865..ec6c3d19d94 100644 --- a/app/code/core/Mage/Page/Block/Html/Head.php +++ b/app/code/core/Mage/Page/Block/Html/Head.php @@ -75,6 +75,7 @@ public function addJs($name, $params = '', $referenceName = '*', $before = null) * @param bool $before * @return $this * @deprecated + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function addCssIe($name, $params = '', $referenceName = '*', $before = null) { @@ -90,6 +91,7 @@ public function addCssIe($name, $params = '', $referenceName = '*', $before = nu * @param bool $before * @return $this * @deprecated + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function addJsIe($name, $params = '', $referenceName = '*', $before = null) { @@ -309,6 +311,7 @@ protected function &_prepareStaticAndSkinElements($format, array $staticItems, a * @param string $itemParams * @param string $itemName * @param array $itemThe + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _separateOtherHtmlHeadElements(&$lines, $itemIf, $itemType, $itemParams, $itemName, $itemThe) { diff --git a/app/code/core/Mage/Page/Block/Html/Topmenu/Renderer.php b/app/code/core/Mage/Page/Block/Html/Topmenu/Renderer.php index 3f930560b86..7a71e05e84f 100644 --- a/app/code/core/Mage/Page/Block/Html/Topmenu/Renderer.php +++ b/app/code/core/Mage/Page/Block/Html/Topmenu/Renderer.php @@ -65,6 +65,7 @@ protected function _addCacheTags() * Fetches template. If template has return statement, than its value is used and direct output otherwise. * @param string $childrenWrapClass * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function render(Varien_Data_Tree_Node $menuTree, $childrenWrapClass) { diff --git a/app/code/core/Mage/Payment/Model/Method/Abstract.php b/app/code/core/Mage/Payment/Model/Method/Abstract.php index 8fecb02d2c3..7e67d55f931 100644 --- a/app/code/core/Mage/Payment/Model/Method/Abstract.php +++ b/app/code/core/Mage/Payment/Model/Method/Abstract.php @@ -172,7 +172,8 @@ public function canRefundPartialPerInvoice() /** * Check void availability * - * @return bool + * @return bool + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function canVoid(Varien_Object $payment) { @@ -245,6 +246,7 @@ public function canCreateBillingAgreement() * * @param string $transactionId * @return array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function fetchTransactionInfo(Mage_Payment_Model_Info $payment, $transactionId) { @@ -296,6 +298,7 @@ public function canUseForCountry($country) * * @param string $currencyCode * @return bool + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function canUseForCurrency($currencyCode) { @@ -406,6 +409,7 @@ public function validate() * * @param float $amount * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function order(Varien_Object $payment, $amount) { @@ -420,6 +424,7 @@ public function order(Varien_Object $payment, $amount) * * @param float $amount * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function authorize(Varien_Object $payment, $amount) { @@ -434,6 +439,7 @@ public function authorize(Varien_Object $payment, $amount) * * @param float $amount * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function capture(Varien_Object $payment, $amount) { @@ -476,6 +482,7 @@ public function processBeforeRefund($invoice, $payment) * * @param float $amount * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function refund(Varien_Object $payment, $amount) { @@ -501,8 +508,8 @@ public function processCreditmemo($creditmemo, $payment) /** * Cancel payment abstract method * - * * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function cancel(Varien_Object $payment) { @@ -526,7 +533,6 @@ public function processBeforeVoid($invoice, $payment) /** * Void payment abstract method * - * * @return $this */ public function void(Varien_Object $payment) @@ -540,8 +546,8 @@ public function void(Varien_Object $payment) /** * Whether this method can accept or deny payment * - * * @return bool + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function canReviewPayment(Mage_Payment_Model_Info $payment) { @@ -723,6 +729,7 @@ public function isApplicableToQuote($quote, $checksBitMask) * @param object $stateObject * * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function initialize($paymentAction, $stateObject) { diff --git a/app/code/core/Mage/Paypal/Block/Adminhtml/System/Config/Fieldset/Payment.php b/app/code/core/Mage/Paypal/Block/Adminhtml/System/Config/Fieldset/Payment.php index 9f0794e1ffa..bcc80b6cb83 100644 --- a/app/code/core/Mage/Paypal/Block/Adminhtml/System/Config/Fieldset/Payment.php +++ b/app/code/core/Mage/Paypal/Block/Adminhtml/System/Config/Fieldset/Payment.php @@ -114,6 +114,7 @@ protected function _getHeaderTitleHtml($element) * * @param Varien_Data_Form_Element_Abstract $element * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _getHeaderCommentHtml($element) { @@ -125,6 +126,7 @@ protected function _getHeaderCommentHtml($element) * * @param Varien_Data_Form_Element_Abstract $element * @return bool + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _getCollapseState($element) { diff --git a/app/code/core/Mage/Paypal/Block/Adminhtml/System/Config/Fieldset/Store.php b/app/code/core/Mage/Paypal/Block/Adminhtml/System/Config/Fieldset/Store.php index eda460d8aa0..0064d2b2961 100644 --- a/app/code/core/Mage/Paypal/Block/Adminhtml/System/Config/Fieldset/Store.php +++ b/app/code/core/Mage/Paypal/Block/Adminhtml/System/Config/Fieldset/Store.php @@ -33,6 +33,7 @@ class Mage_Paypal_Block_Adminhtml_System_Config_Fieldset_Store extends Mage_Admi * Render service JavaScript code * * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function render(Varien_Data_Form_Element_Abstract $element) { diff --git a/app/code/core/Mage/Paypal/Model/Api/Standard.php b/app/code/core/Mage/Paypal/Model/Api/Standard.php index 5552d91c71d..fde24e2f986 100644 --- a/app/code/core/Mage/Paypal/Model/Api/Standard.php +++ b/app/code/core/Mage/Paypal/Model/Api/Standard.php @@ -169,6 +169,7 @@ public function getPaymentAction() * @deprecated after 1.4.1.0 * * @param array $request + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function debugRequest($request) {} diff --git a/app/code/core/Mage/Paypal/Model/Express/Checkout.php b/app/code/core/Mage/Paypal/Model/Express/Checkout.php index 0ec6258ad76..03d4435b3fb 100644 --- a/app/code/core/Mage/Paypal/Model/Express/Checkout.php +++ b/app/code/core/Mage/Paypal/Model/Express/Checkout.php @@ -489,6 +489,7 @@ public function returnFromPaypal($token) * * @param string $token * @throws Mage_Core_Exception + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function prepareOrderReview($token = null) { diff --git a/app/code/core/Mage/Paypal/Model/Ipn.php b/app/code/core/Mage/Paypal/Model/Ipn.php index 28c687be827..8831073857e 100644 --- a/app/code/core/Mage/Paypal/Model/Ipn.php +++ b/app/code/core/Mage/Paypal/Model/Ipn.php @@ -169,7 +169,6 @@ protected function _postBack(Zend_Http_Client_Adapter_Interface $httpAdapter) /** * Load and validate order, instantiate proper configuration * - * * @return Mage_Sales_Model_Order * @throws Exception * @SuppressWarnings("PHPMD.ExitExpression") diff --git a/app/code/core/Mage/Paypal/Model/Method/Agreement.php b/app/code/core/Mage/Paypal/Model/Method/Agreement.php index 192e74c3092..4e4c8f59304 100644 --- a/app/code/core/Mage/Paypal/Model/Method/Agreement.php +++ b/app/code/core/Mage/Paypal/Model/Method/Agreement.php @@ -315,6 +315,10 @@ protected function _placeOrder(Mage_Sales_Model_Order_Payment $payment, $amount) return $this; } + /** + * @return bool + * @SuppressWarnings("PHPMD.UnusedFormalParameter") + */ protected function _isAvailable($quote) { return $this->_pro->getConfig()->isMethodAvailable($this->_code); diff --git a/app/code/core/Mage/Paypal/Model/Payflowlink.php b/app/code/core/Mage/Paypal/Model/Payflowlink.php index f783ebcd1e0..005b28ac3da 100644 --- a/app/code/core/Mage/Paypal/Model/Payflowlink.php +++ b/app/code/core/Mage/Paypal/Model/Payflowlink.php @@ -438,6 +438,7 @@ protected function _getStoreId() * Return request object with basic information for gateway request * * @return Mage_Paypal_Model_Payflow_Request + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _buildBasicRequest(Varien_Object $payment) { @@ -555,6 +556,7 @@ protected function _generateSecureSilentPostHash($payment) * @deprecated since 1.6.2.0 * @param Varien_Object $payment * @param string $txnId + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _addTransaction($payment, $txnId) {} @@ -564,6 +566,7 @@ protected function _addTransaction($payment, $txnId) {} * @deprecated since 1.6.2.0 * @param mixed $amount * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _initialize(Varien_Object $payment, $amount) { @@ -575,6 +578,7 @@ protected function _initialize(Varien_Object $payment, $amount) * * @deprecated since 1.6.2.0 * @param string $token + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function prepareOrderReview($token = null) {} @@ -586,6 +590,7 @@ public function prepareOrderReview($token = null) {} * @param Mage_Paypal_Model_Payment_Transaction $transaction * @param string $txnId * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _authorize(Varien_Object $payment, $amount, $transaction, $txnId) { @@ -596,6 +601,7 @@ protected function _authorize(Varien_Object $payment, $amount, $transaction, $tx * Operate with order or quote using information from silent post * * @deprecated since 1.6.2.0 + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _process(Varien_Object $document) {} @@ -606,6 +612,7 @@ protected function _process(Varien_Object $document) {} * @param Mage_Paypal_Model_Payment_Transaction $transaction * @param mixed $amount * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _checkTransaction($transaction, $amount) { diff --git a/app/code/core/Mage/Paypal/Model/Payflowpro.php b/app/code/core/Mage/Paypal/Model/Payflowpro.php index 0fcf420731d..ca8925e203f 100644 --- a/app/code/core/Mage/Paypal/Model/Payflowpro.php +++ b/app/code/core/Mage/Paypal/Model/Payflowpro.php @@ -492,6 +492,7 @@ protected function _buildPlaceRequest(Varien_Object $payment, $amount) * * @param Mage_Sales_Model_Order_Payment $payment * @return Varien_Object + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _buildBasicRequest(Varien_Object $payment) { @@ -552,6 +553,7 @@ protected function _applyCountryWorkarounds(Varien_Object $address) * * @param Varien_Object $request * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _setReferenceTransaction(Varien_Object $payment, $request) { diff --git a/app/code/core/Mage/Paypal/Model/Pro.php b/app/code/core/Mage/Paypal/Model/Pro.php index df3a1c0c2f3..3e6a5cb897a 100644 --- a/app/code/core/Mage/Paypal/Model/Pro.php +++ b/app/code/core/Mage/Paypal/Model/Pro.php @@ -344,6 +344,7 @@ public function validateRecurringProfile(Mage_Payment_Model_Recurring_Profile $p * Submit RP to the gateway * * @throws Mage_Core_Exception + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function submitRecurringProfile( Mage_Payment_Model_Recurring_Profile $profile, @@ -383,6 +384,8 @@ public function getRecurringProfileDetails($referenceId, Varien_Object $result) /** * Update RP data + * + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function updateRecurringProfile(Mage_Payment_Model_Recurring_Profile $profile) {} diff --git a/app/code/core/Mage/PaypalUk/Model/Api/Nvp.php b/app/code/core/Mage/PaypalUk/Model/Api/Nvp.php index 1fc66915721..928b0185437 100644 --- a/app/code/core/Mage/PaypalUk/Model/Api/Nvp.php +++ b/app/code/core/Mage/PaypalUk/Model/Api/Nvp.php @@ -523,6 +523,7 @@ public function callGetTransactionDetails() {} /** * Get FMF results from response, if any + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _importFraudFiltersResult(array $from, array $collectedWarnings) { @@ -538,6 +539,7 @@ protected function _importFraudFiltersResult(array $from, array $collectedWarnin * * @param string $methodName Current method name * @return array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _prepareEachCallRequest($methodName) { diff --git a/app/code/core/Mage/Persistent/Model/Observer.php b/app/code/core/Mage/Persistent/Model/Observer.php index f3ae96c94e5..a4fdf018d5b 100644 --- a/app/code/core/Mage/Persistent/Model/Observer.php +++ b/app/code/core/Mage/Persistent/Model/Observer.php @@ -145,6 +145,7 @@ public function emulateAccountLinks($block) * Emulate 'top links' block with persistent data * * @param Mage_Core_Block_Abstract $block + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function emulateTopLinks($block) { @@ -280,6 +281,7 @@ protected function _checkClearCheckoutSessionNecessity($observer) * Reset session data when customer re-authenticates * * @param Varien_Event_Observer $observer + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function customerAuthenticatedEvent($observer) { @@ -511,6 +513,7 @@ protected function _expirePersistentSession() * Clear expired persistent sessions * * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function clearExpiredCronJob(Mage_Cron_Model_Schedule $schedule) { diff --git a/app/code/core/Mage/ProductAlert/Block/Price.php b/app/code/core/Mage/ProductAlert/Block/Price.php index 29843aa6109..9a081668217 100644 --- a/app/code/core/Mage/ProductAlert/Block/Price.php +++ b/app/code/core/Mage/ProductAlert/Block/Price.php @@ -45,6 +45,7 @@ public function isShow() * @param string $route * @param array $params * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getUrl($route = '', $params = []) { diff --git a/app/code/core/Mage/ProductAlert/Block/Stock.php b/app/code/core/Mage/ProductAlert/Block/Stock.php index ae6489ec313..e3d7f364983 100644 --- a/app/code/core/Mage/ProductAlert/Block/Stock.php +++ b/app/code/core/Mage/ProductAlert/Block/Stock.php @@ -49,6 +49,7 @@ public function isShow() * @param string $route * @param array $params * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getUrl($route = '', $params = []) { diff --git a/app/code/core/Mage/ProductAlert/Model/Resource/Abstract.php b/app/code/core/Mage/ProductAlert/Model/Resource/Abstract.php index 5eec667217d..59e590f104f 100644 --- a/app/code/core/Mage/ProductAlert/Model/Resource/Abstract.php +++ b/app/code/core/Mage/ProductAlert/Model/Resource/Abstract.php @@ -66,6 +66,7 @@ public function loadByParam(Mage_Core_Model_Abstract $object) * @param int $customerId * @param int $websiteId * @return Mage_ProductAlert_Model_Resource_Abstract + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function deleteCustomer(Mage_Core_Model_Abstract $object, $customerId, $websiteId = null) { diff --git a/app/code/core/Mage/ProductAlert/controllers/AddController.php b/app/code/core/Mage/ProductAlert/controllers/AddController.php index 1ba9422fdb8..5ed9f4a105a 100644 --- a/app/code/core/Mage/ProductAlert/controllers/AddController.php +++ b/app/code/core/Mage/ProductAlert/controllers/AddController.php @@ -52,7 +52,7 @@ public function priceAction() $productId = (int) $this->getRequest()->getParam('product_id'); if (!$backUrl || !$productId) { $this->_redirect('/'); - return ; + return; } $product = Mage::getModel('catalog/product')->load($productId); @@ -64,7 +64,7 @@ public function priceAction() } else { $this->_redirect('/'); } - return ; + return; } try { @@ -89,14 +89,14 @@ public function stockAction() $productId = (int) $this->getRequest()->getParam('product_id'); if (!$backUrl || !$productId) { $this->_redirect('/'); - return ; + return; } if (!$product = Mage::getModel('catalog/product')->load($productId)) { /** @var Mage_Catalog_Model_Product $product */ $session->addError($this->__('Not enough parameters.')); $this->_redirectUrl($backUrl); - return ; + return; } try { diff --git a/app/code/core/Mage/ProductAlert/controllers/UnsubscribeController.php b/app/code/core/Mage/ProductAlert/controllers/UnsubscribeController.php index 185810faef4..022852a0f56 100644 --- a/app/code/core/Mage/ProductAlert/controllers/UnsubscribeController.php +++ b/app/code/core/Mage/ProductAlert/controllers/UnsubscribeController.php @@ -51,7 +51,7 @@ public function priceAction() /** @var Mage_Catalog_Model_Product $product */ Mage::getSingleton('customer/session')->addError($this->__('The product is not found.')); $this->_redirect('customer/account/'); - return ; + return; } try { @@ -103,7 +103,7 @@ public function stockAction() if (!$product->getId() || !$product->isVisibleInCatalog()) { Mage::getSingleton('customer/session')->addError($this->__('The product was not found.')); $this->_redirect('customer/account/'); - return ; + return; } try { diff --git a/app/code/core/Mage/Reports/Model/Event/Observer.php b/app/code/core/Mage/Reports/Model/Event/Observer.php index 60542a40562..42e5c5d2dcb 100644 --- a/app/code/core/Mage/Reports/Model/Event/Observer.php +++ b/app/code/core/Mage/Reports/Model/Event/Observer.php @@ -72,6 +72,7 @@ protected function _event($eventTypeId, $objectId, $subjectId = null, $subtype = * Customer login action * * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function customerLogin(Varien_Event_Observer $observer) { @@ -98,6 +99,7 @@ public function customerLogin(Varien_Event_Observer $observer) * Customer logout processing * * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function customerLogout(Varien_Event_Observer $observer) { @@ -157,6 +159,7 @@ public function sendfriendProduct(Varien_Event_Observer $observer) * Reset count of compared products cache * * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function catalogProductCompareRemoveProduct(Varien_Event_Observer $observer) { @@ -173,6 +176,7 @@ public function catalogProductCompareRemoveProduct(Varien_Event_Observer $observ * Reset count of compared products cache * * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function catalogProductCompareClear(Varien_Event_Observer $observer) { @@ -265,6 +269,7 @@ public function wishlistShare(Varien_Event_Observer $observer) * @see Global Log Clean Settings * * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function eventClean(Varien_Event_Observer $observer) { diff --git a/app/code/core/Mage/Reports/Model/Observer.php b/app/code/core/Mage/Reports/Model/Observer.php index 0a1b3f01b7d..383c2a46df3 100644 --- a/app/code/core/Mage/Reports/Model/Observer.php +++ b/app/code/core/Mage/Reports/Model/Observer.php @@ -10,6 +10,7 @@ class Mage_Reports_Model_Observer * * @param Mage_Cron_Model_Schedule $schedule * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function aggregateReportsReportProductViewedData($schedule) { diff --git a/app/code/core/Mage/Reports/Model/Resource/Entity/Summary/Collection/Abstract.php b/app/code/core/Mage/Reports/Model/Resource/Entity/Summary/Collection/Abstract.php index 2a6c8fb818f..b4430efb7c5 100644 --- a/app/code/core/Mage/Reports/Model/Resource/Entity/Summary/Collection/Abstract.php +++ b/app/code/core/Mage/Reports/Model/Resource/Entity/Summary/Collection/Abstract.php @@ -78,6 +78,7 @@ public function setSelectPeriod($periodType, $customStart = null, $customEnd = n * * @param int $period * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function setDatePeriod($period) { @@ -89,6 +90,7 @@ public function setDatePeriod($period) * * @param int $storeId * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function setStoreFilter($storeId) { diff --git a/app/code/core/Mage/Reports/Model/Resource/Event.php b/app/code/core/Mage/Reports/Model/Resource/Event.php index a01096ba97f..60715678fce 100644 --- a/app/code/core/Mage/Reports/Model/Resource/Event.php +++ b/app/code/core/Mage/Reports/Model/Resource/Event.php @@ -38,6 +38,7 @@ protected function _construct() * @param int $customerId * @param array $types * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function updateCustomerType(Mage_Reports_Model_Event $model, $visitorId, $customerId, $types = []) { @@ -150,6 +151,7 @@ public function getCurrentStoreIds(?array $predefinedStoreIds = null) * Clean report event table * * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function clean(Mage_Reports_Model_Event $object) { diff --git a/app/code/core/Mage/Reports/Model/Resource/Order/Collection.php b/app/code/core/Mage/Reports/Model/Resource/Order/Collection.php index 867ffd517af..2dc05a563b0 100644 --- a/app/code/core/Mage/Reports/Model/Resource/Order/Collection.php +++ b/app/code/core/Mage/Reports/Model/Resource/Order/Collection.php @@ -43,6 +43,7 @@ class Mage_Reports_Model_Resource_Order_Collection extends Mage_Sales_Model_Reso * * @param mixed $range * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function checkIsLive($range) { @@ -289,6 +290,7 @@ protected function _getTZRangeOffsetExpression($range, $attribute, $from = null, * @param string $tzFrom * @param string $tzTo * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _getTZRangeExpressionForAttribute($range, $attribute, $tzFrom = '+00:00', $tzTo = null) { @@ -456,6 +458,7 @@ protected function _calculateTotalsLive($isFilter = 0) * * @param int $isFilter * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _calculateTotalsAggregated($isFilter = 0) { diff --git a/app/code/core/Mage/Reports/Model/Resource/Product/Index/Abstract.php b/app/code/core/Mage/Reports/Model/Resource/Product/Index/Abstract.php index 2cfecc8e589..f5ed390bfb8 100644 --- a/app/code/core/Mage/Reports/Model/Resource/Product/Index/Abstract.php +++ b/app/code/core/Mage/Reports/Model/Resource/Product/Index/Abstract.php @@ -176,7 +176,6 @@ public function clean() /** * Add information about product ids to visitor/customer * - * * @param array $productIds * @return Mage_Reports_Model_Resource_Product_Index_Abstract */ diff --git a/app/code/core/Mage/Reports/Model/Resource/Report/Abstract.php b/app/code/core/Mage/Reports/Model/Resource/Report/Abstract.php index 71b1a6713cf..ff384dbf094 100644 --- a/app/code/core/Mage/Reports/Model/Resource/Report/Abstract.php +++ b/app/code/core/Mage/Reports/Model/Resource/Report/Abstract.php @@ -201,7 +201,6 @@ protected function _getTableDateRangeSelect( * Make condition for using in where section * from select statement with single date column * - * * @param Zend_Db_Select|string $select * @param string $periodColumn * @return string|false diff --git a/app/code/core/Mage/Reports/Model/Resource/Shopcart/Product/Collection.php b/app/code/core/Mage/Reports/Model/Resource/Shopcart/Product/Collection.php index 3d56c8c1dfc..ac3f4304f00 100644 --- a/app/code/core/Mage/Reports/Model/Resource/Shopcart/Product/Collection.php +++ b/app/code/core/Mage/Reports/Model/Resource/Shopcart/Product/Collection.php @@ -43,6 +43,7 @@ protected function _joinFields() * @param string $from * @param string $to * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function setDateRange($from, $to) { diff --git a/app/code/core/Mage/Review/Block/Product/View.php b/app/code/core/Mage/Review/Block/Product/View.php index 3bc9638c625..883ca9acf56 100644 --- a/app/code/core/Mage/Review/Block/Product/View.php +++ b/app/code/core/Mage/Review/Block/Product/View.php @@ -45,6 +45,7 @@ protected function _toHtml() * @param bool $displayIfNoReviews * @return string * @throws Mage_Core_Model_Store_Exception|Mage_Core_Exception + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getReviewsSummaryHtml(Mage_Catalog_Model_Product $product, $templateType = false, $displayIfNoReviews = false) { diff --git a/app/code/core/Mage/Rss/Model/Observer.php b/app/code/core/Mage/Rss/Model/Observer.php index a6e443f7728..af387653a19 100644 --- a/app/code/core/Mage/Rss/Model/Observer.php +++ b/app/code/core/Mage/Rss/Model/Observer.php @@ -44,6 +44,8 @@ public function __construct(array $args = []) /** * Clean cache for catalog review rss + * + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function reviewSaveAfter(Varien_Event_Observer $observer) { @@ -52,6 +54,8 @@ public function reviewSaveAfter(Varien_Event_Observer $observer) /** * Clean cache for notify stock rss + * + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function salesOrderItemSaveAfterNotifyStock(Varien_Event_Observer $observer) { @@ -60,6 +64,8 @@ public function salesOrderItemSaveAfterNotifyStock(Varien_Event_Observer $observ /** * Clean cache for catalog new orders rss + * + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function salesOrderItemSaveAfterOrderNew(Varien_Event_Observer $observer) { diff --git a/app/code/core/Mage/Rss/controllers/IndexController.php b/app/code/core/Mage/Rss/controllers/IndexController.php index 957d54a2982..b27cb7a0bd2 100644 --- a/app/code/core/Mage/Rss/controllers/IndexController.php +++ b/app/code/core/Mage/Rss/controllers/IndexController.php @@ -85,7 +85,7 @@ public function wishlistAction() if ($wishlist->getVisibility()) { $this->_showWishlistRss(); - return ; + return; } if (Mage::getSingleton('customer/session')->authenticate($this) diff --git a/app/code/core/Mage/Rule/Model/Abstract.php b/app/code/core/Mage/Rule/Model/Abstract.php index 4a8a6d6eea8..8def2ffed47 100644 --- a/app/code/core/Mage/Rule/Model/Abstract.php +++ b/app/code/core/Mage/Rule/Model/Abstract.php @@ -285,7 +285,6 @@ public function getForm() /** * Initialize rule model data from array * - * * @return Mage_Rule_Model_Abstract */ public function loadPost(array $data) @@ -306,7 +305,6 @@ public function loadPost(array $data) * Set conditions and actions recursively. * Convert dates into Zend_Date. * - * * @return array */ protected function _convertFlatToRecursive(array $data) @@ -346,7 +344,6 @@ protected function _convertFlatToRecursive(array $data) /** * Validate rule conditions to determine if rule can run * - * * @return bool */ public function validate(Varien_Object $object) @@ -357,7 +354,6 @@ public function validate(Varien_Object $object) /** * Validate rule data * - * * @return bool|array - return true if validation passed successfully. Array with errors description otherwise */ public function validateData(Varien_Object $object) @@ -459,8 +455,8 @@ public function getWebsiteIds() * @deprecated since 1.7.0.0 * * @param string $format - * * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function asString($format = '') { @@ -482,8 +478,8 @@ public function asHtml() * * @deprecated since 1.7.0.0 * - * * @return array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function asArray(array $arrAttributes = []) { diff --git a/app/code/core/Mage/Rule/Model/Action/Abstract.php b/app/code/core/Mage/Rule/Model/Action/Abstract.php index 608e9f64f78..0fa6c7f8da1 100644 --- a/app/code/core/Mage/Rule/Model/Action/Abstract.php +++ b/app/code/core/Mage/Rule/Model/Action/Abstract.php @@ -73,6 +73,7 @@ public function getForm() /** * @return array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function asArray(array $arrAttributes = []) { @@ -330,6 +331,7 @@ public function getRemoveLinkHtml() /** * @param string $format * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function asString($format = '') { diff --git a/app/code/core/Mage/Rule/Model/Condition/Abstract.php b/app/code/core/Mage/Rule/Model/Condition/Abstract.php index b55b4630693..52446d95bdc 100644 --- a/app/code/core/Mage/Rule/Model/Condition/Abstract.php +++ b/app/code/core/Mage/Rule/Model/Condition/Abstract.php @@ -176,6 +176,7 @@ public function getForm() /** * @return array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function asArray(array $arrAttributes = []) { @@ -675,6 +676,7 @@ public function getChooserContainerHtml() /** * @param string $format * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function asString($format = '') { diff --git a/app/code/core/Mage/Rule/Model/Resource/Abstract.php b/app/code/core/Mage/Rule/Model/Resource/Abstract.php index 31e256d0436..45c1a0f0009 100644 --- a/app/code/core/Mage/Rule/Model/Resource/Abstract.php +++ b/app/code/core/Mage/Rule/Model/Resource/Abstract.php @@ -47,7 +47,6 @@ abstract class Mage_Rule_Model_Resource_Abstract extends Mage_Core_Model_Resourc /** * Prepare rule's active "from" and "to" dates * - * * @return Mage_Rule_Model_Resource_Abstract */ public function _beforeSave(Mage_Core_Model_Abstract $object) diff --git a/app/code/core/Mage/Sales/Block/Items/Abstract.php b/app/code/core/Mage/Sales/Block/Items/Abstract.php index a707d029736..893c1f0ed24 100644 --- a/app/code/core/Mage/Sales/Block/Items/Abstract.php +++ b/app/code/core/Mage/Sales/Block/Items/Abstract.php @@ -85,6 +85,7 @@ public function getItemRenderer($type) * Prepare item before output * * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _prepareItem(Mage_Core_Block_Abstract $renderer) { diff --git a/app/code/core/Mage/Sales/Block/Order/Totals.php b/app/code/core/Mage/Sales/Block/Order/Totals.php index 8da72dca755..0aa5346da71 100644 --- a/app/code/core/Mage/Sales/Block/Order/Totals.php +++ b/app/code/core/Mage/Sales/Block/Order/Totals.php @@ -257,9 +257,9 @@ public function removeTotal($code) * $totalCode => $totalSortOrder * ) * - * * @param array $order * @return Mage_Sales_Block_Order_Totals + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function applySortOrder($order) { diff --git a/app/code/core/Mage/Sales/Model/Entity/Quote/Address/Attribute/Backend.php b/app/code/core/Mage/Sales/Model/Entity/Quote/Address/Attribute/Backend.php index 7fca3e39d1d..8bd86b84c9d 100644 --- a/app/code/core/Mage/Sales/Model/Entity/Quote/Address/Attribute/Backend.php +++ b/app/code/core/Mage/Sales/Model/Entity/Quote/Address/Attribute/Backend.php @@ -22,6 +22,7 @@ class Mage_Sales_Model_Entity_Quote_Address_Attribute_Backend extends Mage_Eav_M { /** * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function collectTotals(Mage_Sales_Model_Quote_Address $address) { diff --git a/app/code/core/Mage/Sales/Model/Entity/Quote/Address/Attribute/Frontend.php b/app/code/core/Mage/Sales/Model/Entity/Quote/Address/Attribute/Frontend.php index b3eddd5211a..10099aa8961 100644 --- a/app/code/core/Mage/Sales/Model/Entity/Quote/Address/Attribute/Frontend.php +++ b/app/code/core/Mage/Sales/Model/Entity/Quote/Address/Attribute/Frontend.php @@ -22,6 +22,7 @@ class Mage_Sales_Model_Entity_Quote_Address_Attribute_Frontend extends Mage_Eav_ { /** * @return $this|array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function fetchTotals(Mage_Sales_Model_Quote_Address $address) { diff --git a/app/code/core/Mage/Sales/Model/Observer.php b/app/code/core/Mage/Sales/Model/Observer.php index 6863e0111bc..231a04fbe78 100644 --- a/app/code/core/Mage/Sales/Model/Observer.php +++ b/app/code/core/Mage/Sales/Model/Observer.php @@ -34,7 +34,7 @@ class Mage_Sales_Model_Observer * * @param Mage_Cron_Model_Schedule $schedule * @return $this - * @throws Mage_Core_Exception + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function cleanExpiredQuotes($schedule) { @@ -167,6 +167,7 @@ public function catalogProductStatusUpdate(Varien_Event_Observer $observer) * * @param Mage_Cron_Model_Schedule $schedule * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function aggregateSalesReportOrderData($schedule) { @@ -184,6 +185,7 @@ public function aggregateSalesReportOrderData($schedule) * @param Mage_Cron_Model_Schedule $schedule * @return $this * @throws Zend_Date_Exception + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function aggregateSalesReportShipmentData($schedule) { @@ -201,6 +203,7 @@ public function aggregateSalesReportShipmentData($schedule) * @param Mage_Cron_Model_Schedule $schedule * @return $this * @throws Zend_Date_Exception + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function aggregateSalesReportInvoicedData($schedule) { @@ -218,6 +221,7 @@ public function aggregateSalesReportInvoicedData($schedule) * @param Mage_Cron_Model_Schedule $schedule * @return $this * @throws Zend_Date_Exception + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function aggregateSalesReportRefundedData($schedule) { @@ -235,6 +239,7 @@ public function aggregateSalesReportRefundedData($schedule) * @param Mage_Cron_Model_Schedule $schedule * @return $this * @throws Zend_Date_Exception + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function aggregateSalesReportBestsellersData($schedule) { diff --git a/app/code/core/Mage/Sales/Model/Order/Creditmemo/Total/Abstract.php b/app/code/core/Mage/Sales/Model/Order/Creditmemo/Total/Abstract.php index 4038e5edfc2..ca7e0d5b4c5 100644 --- a/app/code/core/Mage/Sales/Model/Order/Creditmemo/Total/Abstract.php +++ b/app/code/core/Mage/Sales/Model/Order/Creditmemo/Total/Abstract.php @@ -26,6 +26,7 @@ abstract class Mage_Sales_Model_Order_Creditmemo_Total_Abstract extends Mage_Sal * Collect credit memo subtotal * * @return Mage_Sales_Model_Order_Creditmemo_Total_Abstract + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function collect(Mage_Sales_Model_Order_Creditmemo $creditmemo) { diff --git a/app/code/core/Mage/Sales/Model/Order/Invoice/Total/Abstract.php b/app/code/core/Mage/Sales/Model/Order/Invoice/Total/Abstract.php index 5140e688c88..4e290307d08 100644 --- a/app/code/core/Mage/Sales/Model/Order/Invoice/Total/Abstract.php +++ b/app/code/core/Mage/Sales/Model/Order/Invoice/Total/Abstract.php @@ -26,6 +26,7 @@ abstract class Mage_Sales_Model_Order_Invoice_Total_Abstract extends Mage_Sales_ * Collect invoice subtotal * * @return Mage_Sales_Model_Order_Invoice_Total_Abstract + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function collect(Mage_Sales_Model_Order_Invoice $invoice) { diff --git a/app/code/core/Mage/Sales/Model/Order/Payment/Transaction.php b/app/code/core/Mage/Sales/Model/Order/Payment/Transaction.php index 66807a4cb48..8c634560465 100644 --- a/app/code/core/Mage/Sales/Model/Order/Payment/Transaction.php +++ b/app/code/core/Mage/Sales/Model/Order/Payment/Transaction.php @@ -234,6 +234,7 @@ public function getParentTransaction($shouldLoad = true) * @param string $txnId * @param bool $recursive * @return $this|array|null + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getChildTransactions($types = null, $txnId = null, $recursive = false) { diff --git a/app/code/core/Mage/Sales/Model/Order/Pdf/Abstract.php b/app/code/core/Mage/Sales/Model/Order/Pdf/Abstract.php index f4552a9a245..3e664285a1c 100644 --- a/app/code/core/Mage/Sales/Model/Order/Pdf/Abstract.php +++ b/app/code/core/Mage/Sales/Model/Order/Pdf/Abstract.php @@ -533,6 +533,7 @@ protected function _sortTotalsList($a, $b) * * @param Mage_Sales_Model_Abstract $source * @return array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _getTotalsList($source) { diff --git a/app/code/core/Mage/Sales/Model/Payment/Method/Billing/AgreementAbstract.php b/app/code/core/Mage/Sales/Model/Payment/Method/Billing/AgreementAbstract.php index 9a2b16cde21..cf477f46f87 100644 --- a/app/code/core/Mage/Sales/Model/Payment/Method/Billing/AgreementAbstract.php +++ b/app/code/core/Mage/Sales/Model/Payment/Method/Billing/AgreementAbstract.php @@ -93,7 +93,6 @@ public function assignData($data) } /** - * * * @param Mage_Sales_Model_Quote $quote */ diff --git a/app/code/core/Mage/Sales/Model/Quote.php b/app/code/core/Mage/Sales/Model/Quote.php index 6e31796a00c..4b308893eaa 100644 --- a/app/code/core/Mage/Sales/Model/Quote.php +++ b/app/code/core/Mage/Sales/Model/Quote.php @@ -64,8 +64,8 @@ * @method string getCustomerGender() * @method $this setCustomerGender(string $value) * @method $this setCustomerGroupId(int $value) - * @method int getCustomerId() - * @method $this setCustomerId(int $value) + * @method int|null getCustomerId() + * @method $this setCustomerId(int|null $value) * @method int getCustomerIsGuest() * @method $this setCustomerIsGuest(int $value) * @method string getCustomerLastname() @@ -798,6 +798,7 @@ public function addShippingAddress(Mage_Sales_Model_Quote_Address $address) * * @param bool $useCache * @return Mage_Sales_Model_Resource_Quote_Item_Collection + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getItemsCollection($useCache = true) { @@ -1122,6 +1123,7 @@ public function addProduct(Mage_Catalog_Model_Product $product, $request = null) * @param int $qty * @return Mage_Sales_Model_Quote_Item * @throws Mage_Core_Model_Store_Exception + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _addCatalogProduct(Mage_Catalog_Model_Product $product, $qty = 1) { diff --git a/app/code/core/Mage/Sales/Model/Quote/Address.php b/app/code/core/Mage/Sales/Model/Quote/Address.php index 08363d23c9d..705659b5e00 100644 --- a/app/code/core/Mage/Sales/Model/Quote/Address.php +++ b/app/code/core/Mage/Sales/Model/Quote/Address.php @@ -1191,6 +1191,7 @@ public function setAppliedTaxes($data) * @param float $value * @param bool $alreadyExclTax * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function setShippingAmount($value, $alreadyExclTax = false) { @@ -1203,6 +1204,7 @@ public function setShippingAmount($value, $alreadyExclTax = false) * @param float $value * @param bool $alreadyExclTax * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function setBaseShippingAmount($value, $alreadyExclTax = false) { diff --git a/app/code/core/Mage/Sales/Model/Quote/Address/Total/Abstract.php b/app/code/core/Mage/Sales/Model/Quote/Address/Total/Abstract.php index c5e10a50b54..a2f261ca991 100644 --- a/app/code/core/Mage/Sales/Model/Quote/Address/Total/Abstract.php +++ b/app/code/core/Mage/Sales/Model/Quote/Address/Total/Abstract.php @@ -246,6 +246,7 @@ public function getIsItemRowTotalCompoundable(Mage_Sales_Model_Quote_Item_Abstra * @param array $config * @param Mage_Core_Model_Store $store * @return array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function processConfigArray($config, $store) { diff --git a/app/code/core/Mage/Sales/Model/Quote/Address/Total/Nominal/RecurringAbstract.php b/app/code/core/Mage/Sales/Model/Quote/Address/Total/Nominal/RecurringAbstract.php index 092a2af5bac..944b9331fbe 100644 --- a/app/code/core/Mage/Sales/Model/Quote/Address/Total/Nominal/RecurringAbstract.php +++ b/app/code/core/Mage/Sales/Model/Quote/Address/Total/Nominal/RecurringAbstract.php @@ -92,6 +92,7 @@ protected function _getAddressItems(Mage_Sales_Model_Quote_Address $address) * * @param Mage_Sales_Model_Quote_Address $address * @param Mage_Sales_Model_Quote_Item_Abstract $item + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _afterCollectSuccess($address, $item) {} } diff --git a/app/code/core/Mage/Sales/Model/Resource/Collection/Abstract.php b/app/code/core/Mage/Sales/Model/Resource/Collection/Abstract.php index 8b0b171184b..d637c9f6625 100644 --- a/app/code/core/Mage/Sales/Model/Resource/Collection/Abstract.php +++ b/app/code/core/Mage/Sales/Model/Resource/Collection/Abstract.php @@ -146,6 +146,7 @@ public function getAllIds($limit = null, $offset = null) * @param string $joinType * @param int $storeId * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function joinAttribute($alias, $attribute, $bind, $filter = null, $joinType = 'inner', $storeId = null) { diff --git a/app/code/core/Mage/Sales/Model/Resource/Quote/Address/Attribute/Backend.php b/app/code/core/Mage/Sales/Model/Resource/Quote/Address/Attribute/Backend.php index d8c08cc94ac..12fa87b6258 100644 --- a/app/code/core/Mage/Sales/Model/Resource/Quote/Address/Attribute/Backend.php +++ b/app/code/core/Mage/Sales/Model/Resource/Quote/Address/Attribute/Backend.php @@ -26,6 +26,7 @@ class Mage_Sales_Model_Resource_Quote_Address_Attribute_Backend extends Mage_Eav * Collect totals * * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function collectTotals(Mage_Sales_Model_Quote_Address $address) { diff --git a/app/code/core/Mage/Sales/Model/Resource/Quote/Address/Attribute/Frontend.php b/app/code/core/Mage/Sales/Model/Resource/Quote/Address/Attribute/Frontend.php index 29e6276b586..d108dcf15d7 100644 --- a/app/code/core/Mage/Sales/Model/Resource/Quote/Address/Attribute/Frontend.php +++ b/app/code/core/Mage/Sales/Model/Resource/Quote/Address/Attribute/Frontend.php @@ -26,6 +26,7 @@ class Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend extends Mage_Ea * Fetch totals * * @return $this|array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function fetchTotals(Mage_Sales_Model_Quote_Address $address) { diff --git a/app/code/core/Mage/Sales/Model/Resource/Recurring/Profile.php b/app/code/core/Mage/Sales/Model/Resource/Recurring/Profile.php index f300f0c2eec..bd07c7b2544 100644 --- a/app/code/core/Mage/Sales/Model/Resource/Recurring/Profile.php +++ b/app/code/core/Mage/Sales/Model/Resource/Recurring/Profile.php @@ -70,7 +70,6 @@ protected function _unserializeField(Varien_Object $object, $field, $defaultValu /** * Return recurring profile child Orders Ids * - * * @param Varien_Object $object * @return array */ diff --git a/app/code/core/Mage/Sales/controllers/OrderController.php b/app/code/core/Mage/Sales/controllers/OrderController.php index c9df472a307..013a8f2a02b 100644 --- a/app/code/core/Mage/Sales/controllers/OrderController.php +++ b/app/code/core/Mage/Sales/controllers/OrderController.php @@ -60,7 +60,8 @@ public function historyAction() * * @deprecated after 1.6.0.0 * @param array $order - * @return bool + * @return false + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _canViewOscommerceOrder($order) { diff --git a/app/code/core/Mage/SalesRule/Model/Coupon.php b/app/code/core/Mage/SalesRule/Model/Coupon.php index 92495f415be..3afaafec6f2 100644 --- a/app/code/core/Mage/SalesRule/Model/Coupon.php +++ b/app/code/core/Mage/SalesRule/Model/Coupon.php @@ -34,8 +34,8 @@ * @method $this setUsagePerCustomer(int $value) * @method int getTimesUsed() * @method $this setTimesUsed(int $value) - * @method Zend_Date getExpirationDate() - * @method $this setExpirationDate(Zend_Date $value) + * @method string getExpirationDate() + * @method $this setExpirationDate(string $value) * @method int getIsPrimary() * @method $this setIsPrimary(int $value) * @method int getType() diff --git a/app/code/core/Mage/SalesRule/Model/Observer.php b/app/code/core/Mage/SalesRule/Model/Observer.php index c97c4f2336c..1f56c385a38 100644 --- a/app/code/core/Mage/SalesRule/Model/Observer.php +++ b/app/code/core/Mage/SalesRule/Model/Observer.php @@ -179,6 +179,7 @@ public function sales_order_paymentCancel($observer) * * @param Mage_Cron_Model_Schedule $schedule * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function aggregateSalesReportCouponsData($schedule) { diff --git a/app/code/core/Mage/SalesRule/Model/Resource/Coupon.php b/app/code/core/Mage/SalesRule/Model/Resource/Coupon.php index 1c8f8b1636e..224eaa1b73e 100644 --- a/app/code/core/Mage/SalesRule/Model/Resource/Coupon.php +++ b/app/code/core/Mage/SalesRule/Model/Resource/Coupon.php @@ -53,7 +53,6 @@ public function _beforeSave(Mage_Core_Model_Abstract $object) /** * Load primary coupon (is_primary = 1) for specified rule * - * * @param Mage_SalesRule_Model_Rule|int $rule * @return bool */ diff --git a/app/code/core/Mage/SalesRule/Model/Resource/Coupon/Collection.php b/app/code/core/Mage/SalesRule/Model/Resource/Coupon/Collection.php index b255e5ce8df..6244422b020 100644 --- a/app/code/core/Mage/SalesRule/Model/Resource/Coupon/Collection.php +++ b/app/code/core/Mage/SalesRule/Model/Resource/Coupon/Collection.php @@ -51,7 +51,6 @@ public function addRuleToFilter($rule) /** * Add rule IDs to filter * - * * @return $this */ public function addRuleIdsToFilter(array $ruleIds) diff --git a/app/code/core/Mage/SalesRule/Model/Resource/Coupon/Usage.php b/app/code/core/Mage/SalesRule/Model/Resource/Coupon/Usage.php index db5f35df0ff..48781c6a903 100644 --- a/app/code/core/Mage/SalesRule/Model/Resource/Coupon/Usage.php +++ b/app/code/core/Mage/SalesRule/Model/Resource/Coupon/Usage.php @@ -30,7 +30,6 @@ protected function _construct() /** * Increment times_used counter * - * * @param int $customerId * @param int $couponId * @param bool $decrement Decrement instead of increment times_used @@ -74,7 +73,6 @@ public function updateCustomerCouponTimesUsed($customerId, $couponId, $decrement /** * Load an object by customer_id & coupon_id * - * * @param int $customerId * @param int $couponId * @return $this diff --git a/app/code/core/Mage/SalesRule/Model/Resource/Rule.php b/app/code/core/Mage/SalesRule/Model/Resource/Rule.php index 908e9d3a380..de3181db555 100644 --- a/app/code/core/Mage/SalesRule/Model/Resource/Rule.php +++ b/app/code/core/Mage/SalesRule/Model/Resource/Rule.php @@ -51,7 +51,6 @@ protected function _construct() /** * Add customer group ids and website ids to rule data after load * - * * @return $this */ protected function _afterLoad(Mage_Core_Model_Abstract $object) @@ -66,7 +65,6 @@ protected function _afterLoad(Mage_Core_Model_Abstract $object) /** * Prepare sales rule's discount quantity * - * * @return $this */ public function _beforeSave(Mage_Core_Model_Abstract $object) @@ -226,7 +224,8 @@ public function getStoreLabel($ruleId, $storeId) * * @param int $websiteId * @param int $customerGroupId - * @return mixed + * @return array|null + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getActiveAttributes($websiteId, $customerGroupId) { diff --git a/app/code/core/Mage/SalesRule/Model/Rule.php b/app/code/core/Mage/SalesRule/Model/Rule.php index 2acb66e1d08..0e6a5cee5be 100644 --- a/app/code/core/Mage/SalesRule/Model/Rule.php +++ b/app/code/core/Mage/SalesRule/Model/Rule.php @@ -224,7 +224,6 @@ protected function _afterSave() * Initialize rule model data from array. * Set store labels if applicable. * - * * @return $this */ public function loadPost(array $data) @@ -509,8 +508,8 @@ protected function _getUsedAttributes($serializedString) * @deprecated after 1.6.2.0 * * @param string $format - * * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function toString($format = '') { diff --git a/app/code/core/Mage/SalesRule/Model/Rule/Condition/Product.php b/app/code/core/Mage/SalesRule/Model/Rule/Condition/Product.php index 1bdee85fe4a..46a9cb4ba7e 100644 --- a/app/code/core/Mage/SalesRule/Model/Rule/Condition/Product.php +++ b/app/code/core/Mage/SalesRule/Model/Rule/Condition/Product.php @@ -36,7 +36,6 @@ protected function _addSpecialAttributes(array &$attributes) /** * Validate Product Rule Condition * - * * @return bool */ public function validate(Varien_Object $object) diff --git a/app/code/core/Mage/Shipping/Model/Carrier/Abstract.php b/app/code/core/Mage/Shipping/Model/Carrier/Abstract.php index 8e14ecdf741..26fc7646837 100644 --- a/app/code/core/Mage/Shipping/Model/Carrier/Abstract.php +++ b/app/code/core/Mage/Shipping/Model/Carrier/Abstract.php @@ -145,6 +145,7 @@ abstract public function collectRates(Mage_Shipping_Model_Rate_Request $request) * Implementation must be in overridden method * * @return Varien_Object + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function requestToShipment(Mage_Shipping_Model_Shipment_Request $request) { @@ -157,6 +158,7 @@ public function requestToShipment(Mage_Shipping_Model_Shipment_Request $request) * * @param mixed $request * @return Varien_Object + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function returnOfShipment($request) { @@ -167,6 +169,7 @@ public function returnOfShipment($request) * Return container types of carrier * * @return array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getContainerTypes(?Varien_Object $params = null) { @@ -239,6 +242,7 @@ public function getCustomizableContainerTypes() * Return delivery confirmation types of carrier * * @return array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getDeliveryConfirmationTypes(?Varien_Object $params = null) { @@ -285,6 +289,7 @@ public function checkAvailableShipCountries(Mage_Shipping_Model_Rate_Request $re * Processing additional validation to check is carrier applicable. * * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function proccessAdditionalValidation(Mage_Shipping_Model_Rate_Request $request) { @@ -534,6 +539,7 @@ public function isCityRequired() * * @param string|null $countryId * @return false + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function isZipCodeRequired($countryId = null) { @@ -588,6 +594,7 @@ public function getCarrierCode() * Return content types of package * * @return array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getContentTypes(Varien_Object $params) { diff --git a/app/code/core/Mage/Sitemap/Model/Observer.php b/app/code/core/Mage/Sitemap/Model/Observer.php index 4c6d07e7c8f..164154182f7 100644 --- a/app/code/core/Mage/Sitemap/Model/Observer.php +++ b/app/code/core/Mage/Sitemap/Model/Observer.php @@ -51,6 +51,7 @@ class Mage_Sitemap_Model_Observer * Generate sitemaps * * @param Mage_Cron_Model_Schedule $schedule + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function scheduledGenerateSitemaps($schedule) { diff --git a/app/code/core/Mage/Tax/Helper/Data.php b/app/code/core/Mage/Tax/Helper/Data.php index 5cd4e158f37..c05c04302ce 100644 --- a/app/code/core/Mage/Tax/Helper/Data.php +++ b/app/code/core/Mage/Tax/Helper/Data.php @@ -201,6 +201,7 @@ public function applyTaxAfterDiscount($store = null) * @param bool $flag * @param mixed $store * @return string + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getIncExcText($flag, $store = null) { @@ -231,7 +232,7 @@ public function getPriceDisplayType($store = null) * If its necessary will be returned conversion type (minus or plus) * * @param null|string|bool|int|Mage_Core_Model_Store $store - * @return false|int + * @return bool|int */ public function needPriceConversion($store = null) { @@ -386,6 +387,7 @@ public function displaySalesSubtotalExclTax($store = null) * * @param null|string|bool|int|Mage_Core_Model_Store $store * @return bool + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function displayTaxColumn($store = null) { diff --git a/app/code/core/Mage/Tax/Model/Observer.php b/app/code/core/Mage/Tax/Model/Observer.php index 33ddddcb186..6ce867a29a6 100644 --- a/app/code/core/Mage/Tax/Model/Observer.php +++ b/app/code/core/Mage/Tax/Model/Observer.php @@ -209,6 +209,7 @@ public function addTaxPercentToProductCollection($observer) * * @param Mage_Cron_Model_Schedule $schedule * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function aggregateSalesReportTaxData($schedule) { diff --git a/app/code/core/Mage/Tax/Model/Sales/Total/Quote/Discount.php b/app/code/core/Mage/Tax/Model/Sales/Total/Quote/Discount.php index e3e7c7caaed..4f7c45dc010 100644 --- a/app/code/core/Mage/Tax/Model/Sales/Total/Quote/Discount.php +++ b/app/code/core/Mage/Tax/Model/Sales/Total/Quote/Discount.php @@ -26,6 +26,7 @@ class Mage_Tax_Model_Sales_Total_Quote_Discount extends Mage_Sales_Model_Quote_A * Calculate discount tac amount * * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function collect(Mage_Sales_Model_Quote_Address $address) { diff --git a/app/code/core/Mage/Tax/Model/Sales/Total/Quote/Shipping.php b/app/code/core/Mage/Tax/Model/Sales/Total/Quote/Shipping.php index 5e6b59b97cf..ff89be48c8f 100644 --- a/app/code/core/Mage/Tax/Model/Sales/Total/Quote/Shipping.php +++ b/app/code/core/Mage/Tax/Model/Sales/Total/Quote/Shipping.php @@ -255,6 +255,7 @@ protected function _needSubtractShippingTax($address) * * @param Mage_Sales_Model_Quote_Address $address * @deprecated after 1.4.0.0 + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _processShippingAmount($address) {} } diff --git a/app/code/core/Mage/Tax/Model/Sales/Total/Quote/Subtotal.php b/app/code/core/Mage/Tax/Model/Sales/Total/Quote/Subtotal.php index d0d8d6be910..e8b639a9fba 100644 --- a/app/code/core/Mage/Tax/Model/Sales/Total/Quote/Subtotal.php +++ b/app/code/core/Mage/Tax/Model/Sales/Total/Quote/Subtotal.php @@ -116,7 +116,6 @@ public function __construct() * and subtotal including/excluding tax. * Determine discount price if needed * - * * @return Mage_Tax_Model_Sales_Total_Quote_Subtotal */ public function collect(Mage_Sales_Model_Quote_Address $address) @@ -657,7 +656,6 @@ protected function _totalBaseCalculation($item, $request) * @param float $storePriceInclTax * @param float $storeRate * @param float $customerRate - * * @return float */ protected function _calculatePriceInclTax($storePriceInclTax, $storeRate, $customerRate) @@ -674,7 +672,6 @@ protected function _calculatePriceInclTax($storePriceInclTax, $storeRate, $custo * Used only in case of prices including tax * * @param Varien_Object $request - * * @return bool */ protected function _sameRateAsStore($request) @@ -697,7 +694,6 @@ protected function _sameRateAsStore($request) * @param string $rate * @param bool $direction * @param string $type - * * @return float */ protected function _deltaRound($price, $rate, $direction, $type = 'regular') @@ -717,7 +713,6 @@ protected function _deltaRound($price, $rate, $direction, $type = 'regular') /** * Recalculate row information for item based on children calculation * - * * @return Mage_Tax_Model_Sales_Total_Quote_Subtotal */ protected function _recalculateParent(Mage_Sales_Model_Quote_Item_Abstract $item) @@ -757,7 +752,6 @@ protected function _recalculateParent(Mage_Sales_Model_Quote_Item_Abstract $item * Get request for fetching store tax rate * * @param Mage_Sales_Model_Quote_Address $address - * * @return Varien_Object */ protected function _getStoreTaxRequest($address) @@ -772,7 +766,6 @@ protected function _getStoreTaxRequest($address) * Get request for fetching address tax rate * * @param Mage_Sales_Model_Quote_Address $address - * * @return Varien_Object */ protected function _getAddressTaxRequest($address) @@ -820,6 +813,7 @@ protected function _addSubtotalAmount(Mage_Sales_Model_Quote_Address $address, $ * @deprecated after 1.4.1 * * @return Mage_Tax_Model_Sales_Total_Quote_Subtotal + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _resetItemPriceInclTax(Mage_Sales_Model_Quote_Item_Abstract $item) { @@ -832,6 +826,7 @@ protected function _resetItemPriceInclTax(Mage_Sales_Model_Quote_Item_Abstract $ * * @param Mage_Sales_Model_Quote_Address $address * @return Mage_Tax_Model_Sales_Total_Quote_Subtotal + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _processShippingAmount($address) { @@ -845,7 +840,6 @@ protected function _processShippingAmount($address) * @deprecated after 1.4.1 * * @param Mage_Sales_Model_Quote_Address $address - * * @return Mage_Tax_Model_Sales_Total_Quote_Subtotal */ protected function _recollectItem($address, Mage_Sales_Model_Quote_Item_Abstract $item) @@ -925,7 +919,6 @@ protected function _recollectItem($address, Mage_Sales_Model_Quote_Item_Abstract * @deprecated after 1.4.1 * * @param Mage_Sales_Model_Quote_Address $address - * * @return bool */ protected function _needSubtractTax($address) @@ -943,7 +936,6 @@ protected function _needSubtractTax($address) * @deprecated after 1.4.0.1 * * @param Mage_Sales_Model_Quote_Address $address - * * @return bool */ protected function _needSubtractShippingTax($address) diff --git a/app/code/core/Mage/Usa/Model/Shipping/Carrier/Abstract.php b/app/code/core/Mage/Usa/Model/Shipping/Carrier/Abstract.php index 3c30902a207..1dfa0294f28 100644 --- a/app/code/core/Mage/Usa/Model/Shipping/Carrier/Abstract.php +++ b/app/code/core/Mage/Usa/Model/Shipping/Carrier/Abstract.php @@ -277,7 +277,6 @@ protected function _prepareServiceName($name) * Prepare shipment request. * Validate and correct request information * - * */ protected function _prepareShipmentRequest(Varien_Object $request) { @@ -393,6 +392,7 @@ public function returnOfShipment($request) * @todo implement rollback logic * @param array $data * @return bool + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function rollBack($data) { @@ -444,6 +444,7 @@ protected function _isCanada($countryId) * * @param null|string $countyDest * @return bool + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function isGirthAllowed($countyDest = null) { diff --git a/app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl.php b/app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl.php index 93ee932b9f1..308e7d52879 100644 --- a/app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl.php +++ b/app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl.php @@ -1311,6 +1311,7 @@ protected function _doShipmentRequest(Varien_Object $request) * Return container types of carrier * * @return array|bool + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getContainerTypes(?Varien_Object $params = null) { diff --git a/app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl/International.php b/app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl/International.php index 447bef796f1..f2e03fc52e3 100644 --- a/app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl/International.php +++ b/app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl/International.php @@ -1167,6 +1167,7 @@ protected function _showError() * Return container types of carrier * * @return array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getContainerTypes(?Varien_Object $params = null) { diff --git a/app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl/Label/Pdf/PageBuilder.php b/app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl/Label/Pdf/PageBuilder.php index 79634a09e8f..3cfe4082e9a 100644 --- a/app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl/Label/Pdf/PageBuilder.php +++ b/app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl/Label/Pdf/PageBuilder.php @@ -212,6 +212,7 @@ public function addProductContentCode($code) * * @param int $id * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function addUnitId($id) { @@ -228,6 +229,7 @@ public function addUnitId($id) * * @param $data * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function addReferenceData($data) { diff --git a/app/code/core/Mage/Usa/Model/Shipping/Carrier/Fedex.php b/app/code/core/Mage/Usa/Model/Shipping/Carrier/Fedex.php index 1912f9f3307..d9484beafea 100644 --- a/app/code/core/Mage/Usa/Model/Shipping/Carrier/Fedex.php +++ b/app/code/core/Mage/Usa/Model/Shipping/Carrier/Fedex.php @@ -1600,6 +1600,7 @@ public function getContainerTypesFilter() * Return delivery confirmation types of carrier * * @return array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function getDeliveryConfirmationTypes(?Varien_Object $params = null) { diff --git a/app/code/core/Mage/Usa/Model/Shipping/Carrier/Usps.php b/app/code/core/Mage/Usa/Model/Shipping/Carrier/Usps.php index acc2742bfac..10a1722a41b 100644 --- a/app/code/core/Mage/Usa/Model/Shipping/Carrier/Usps.php +++ b/app/code/core/Mage/Usa/Model/Shipping/Carrier/Usps.php @@ -1914,6 +1914,7 @@ protected function _parseZip($zipString, $returnFull = false) /** * @deprecated + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _methodsMapper($method, $valuesToLabels = true) { diff --git a/app/code/core/Mage/Weee/Block/Renderer/Weee/Tax.php b/app/code/core/Mage/Weee/Block/Renderer/Weee/Tax.php index 9168a2862c8..26e1db6a69f 100644 --- a/app/code/core/Mage/Weee/Block/Renderer/Weee/Tax.php +++ b/app/code/core/Mage/Weee/Block/Renderer/Weee/Tax.php @@ -64,7 +64,6 @@ public function getProduct() /** * Renders html of block * - * * @return string */ public function render(Varien_Data_Form_Element_Abstract $element) @@ -77,7 +76,6 @@ public function render(Varien_Data_Form_Element_Abstract $element) /** * Sets internal reference to element * - * * @return $this */ public function setElement(Varien_Data_Form_Element_Abstract $element) diff --git a/app/code/core/Mage/Weee/Helper/Data.php b/app/code/core/Mage/Weee/Helper/Data.php index 55e2703c907..e1e350182ed 100644 --- a/app/code/core/Mage/Weee/Helper/Data.php +++ b/app/code/core/Mage/Weee/Helper/Data.php @@ -176,6 +176,7 @@ public function getAmount($product, $shipping = null, $billing = null, $website * @param string $zone * @param Mage_Core_Model_Store $store * @return bool|int + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function typeOfDisplay($product, $compareTo = null, $zone = null, $store = null) { diff --git a/app/code/core/Mage/Weee/Model/Total/Quote/Weee.php b/app/code/core/Mage/Weee/Model/Total/Quote/Weee.php index 63536207fb3..f9fa70efc67 100644 --- a/app/code/core/Mage/Weee/Model/Total/Quote/Weee.php +++ b/app/code/core/Mage/Weee/Model/Total/Quote/Weee.php @@ -334,6 +334,7 @@ protected function _processTotalAmount($address, $rowValue, $baseRowValue) * Recalculate parent item amounts based on children results * * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _recalculateParent(Mage_Sales_Model_Quote_Item_Abstract $item) { @@ -366,6 +367,7 @@ protected function _resetItemData($item) * Fetch FPT data to address object for display in totals block * * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function fetch(Mage_Sales_Model_Quote_Address $address) { @@ -379,6 +381,7 @@ public function fetch(Mage_Sales_Model_Quote_Address $address) * @param array $config * @param Mage_Core_Model_Store $store * @return array + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function processConfigArray($config, $store) { diff --git a/app/code/core/Mage/Wishlist/Block/Abstract.php b/app/code/core/Mage/Wishlist/Block/Abstract.php index 7081e6cc6b4..36622f77f01 100644 --- a/app/code/core/Mage/Wishlist/Block/Abstract.php +++ b/app/code/core/Mage/Wishlist/Block/Abstract.php @@ -95,6 +95,7 @@ protected function _getWishlist() * * @param Mage_Wishlist_Model_Resource_Item_Collection $collection * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _prepareCollection($collection) { diff --git a/app/code/core/Mage/Wishlist/Block/Customer/Wishlist/Item/Column.php b/app/code/core/Mage/Wishlist/Block/Customer/Wishlist/Item/Column.php index 589d17a6aef..b998126d4f3 100644 --- a/app/code/core/Mage/Wishlist/Block/Customer/Wishlist/Item/Column.php +++ b/app/code/core/Mage/Wishlist/Block/Customer/Wishlist/Item/Column.php @@ -50,6 +50,7 @@ protected function _toHtml() * * @param string $name * @param Mage_Core_Block_Abstract $child + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ protected function _beforeChildToHtml($name, $child) { diff --git a/app/code/core/Mage/Wishlist/Model/Observer.php b/app/code/core/Mage/Wishlist/Model/Observer.php index 4f858ff7f0f..09ba9257070 100644 --- a/app/code/core/Mage/Wishlist/Model/Observer.php +++ b/app/code/core/Mage/Wishlist/Model/Observer.php @@ -138,6 +138,7 @@ public function processAddToCart($observer) * Customer login processing * * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function customerLogin(Varien_Event_Observer $observer) { @@ -150,6 +151,7 @@ public function customerLogin(Varien_Event_Observer $observer) * Customer logout processing * * @return $this + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function customerLogout(Varien_Event_Observer $observer) { diff --git a/app/code/core/Mage/Wishlist/Model/Resource/Product/Collection.php b/app/code/core/Mage/Wishlist/Model/Resource/Product/Collection.php index f74ad1739f2..d17c3d462c3 100644 --- a/app/code/core/Mage/Wishlist/Model/Resource/Product/Collection.php +++ b/app/code/core/Mage/Wishlist/Model/Resource/Product/Collection.php @@ -165,6 +165,7 @@ protected function _getAttributeFieldName($attributeCode) * @param bool $printQuery * @param bool $logQuery * @return Mage_Wishlist_Model_Resource_Product_Collection + * @SuppressWarnings("PHPMD.UnusedFormalParameter") */ public function load($printQuery = false, $logQuery = false) { diff --git a/app/code/core/Mage/Wishlist/Model/Resource/Wishlist.php b/app/code/core/Mage/Wishlist/Model/Resource/Wishlist.php index b21dda17ef0..6bd1c2f3c6e 100644 --- a/app/code/core/Mage/Wishlist/Model/Resource/Wishlist.php +++ b/app/code/core/Mage/Wishlist/Model/Resource/Wishlist.php @@ -90,7 +90,6 @@ public function setCustomerIdFieldName($fieldName) * @deprecated after 1.6.0.0-rc2 * @see Mage_Wishlist_Model_Wishlist::getItemsCount() * - * * @return int */ public function fetchItemsCount(Mage_Wishlist_Model_Wishlist $wishlist) diff --git a/js/lib/uploader/flow.js b/js/lib/uploader/flow.js index e61f0a75bcd..92afe2b5fa3 100644 --- a/js/lib/uploader/flow.js +++ b/js/lib/uploader/flow.js @@ -54,7 +54,7 @@ ); if (!this.support) { - return ; + return; } /** @@ -236,7 +236,7 @@ var entry = item.webkitGetAsEntry(); if (!entry) { decrement(); - return ; + return; } if (entry.isFile) { // due to a bug in Chrome's File System API impl - #149735 @@ -821,7 +821,7 @@ measureSpeed: function () { var timeSpan = Date.now() - this._lastProgressCallback; if (!timeSpan) { - return ; + return; } var smoothingFactor = this.flowObj.opts.speedSmoothingFactor; var uploaded = this.sizeUploaded(); @@ -1601,7 +1601,7 @@ */ function each(obj, callback, context) { if (!obj) { - return ; + return; } var key; // Is Array? @@ -1609,13 +1609,13 @@ if (typeof(obj.length) !== 'undefined') { for (key = 0; key < obj.length; key++) { if (callback.call(context, obj[key], key) === false) { - return ; + return; } } } else { for (key in obj) { if (obj.hasOwnProperty(key) && callback.call(context, obj[key], key) === false) { - return ; + return; } } } diff --git a/js/mage/adminhtml/sales.js b/js/mage/adminhtml/sales.js index 7e9facb8308..1a766ae76fb 100644 --- a/js/mage/adminhtml/sales.js +++ b/js/mage/adminhtml/sales.js @@ -42,7 +42,7 @@ AdminOrder.prototype = { var buttons = controlButtonArea.childElements(); for (var i = 0; i < buttons.length; i++) { if (buttons[i].innerHTML.include(button.label)) { - return ; + return; } } button.insertIn(controlButtonArea, 'top'); diff --git a/lib/Varien/Data/Form/Element/Checkboxes.php b/lib/Varien/Data/Form/Element/Checkboxes.php index 722f0ae836a..f037840c266 100644 --- a/lib/Varien/Data/Form/Element/Checkboxes.php +++ b/lib/Varien/Data/Form/Element/Checkboxes.php @@ -128,7 +128,7 @@ public function getChecked($value) if (in_array((string) $value, $checked)) { return 'checked'; } - return ; + return; } /** @@ -181,7 +181,7 @@ public function getOnchange($value) // if ($name = $this->getData('name')) { // return str_replace('$value', $value, $name); // } - // return ; + // return; // } /** diff --git a/lib/Varien/Db/Adapter/Mysqli.php b/lib/Varien/Db/Adapter/Mysqli.php index 3cf02e2515a..3b966003f03 100644 --- a/lib/Varien/Db/Adapter/Mysqli.php +++ b/lib/Varien/Db/Adapter/Mysqli.php @@ -195,7 +195,6 @@ public function dropKey($table, $key) /** * ADD CONSTRAINT * - * * @param string $fkName * @param string $tableName * @param string $keyName diff --git a/lib/Varien/Http/Adapter/Curl.php b/lib/Varien/Http/Adapter/Curl.php index e5518fdd6c7..4213b0fd9d1 100644 --- a/lib/Varien/Http/Adapter/Curl.php +++ b/lib/Varien/Http/Adapter/Curl.php @@ -111,7 +111,6 @@ public function addOption($option, $value) /** * Add additional options list to curl * - * * @return Varien_Http_Adapter_Curl */ public function addOptions(array $options)